Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-25 Thread sebb
On 25/05/2009, Henri Yandell wrote: > On Sat, May 23, 2009 at 3:33 AM, sebb wrote: > > On 23/05/2009, Henri Yandell wrote: > > > >> Maven release plugin is the one doing the copy to the branch. So I > >> don't see the commit message (well.. it's probably somewhere in the > >> huge load of t

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-25 Thread Henri Yandell
On Sat, May 23, 2009 at 3:33 AM, sebb wrote: > On 23/05/2009, Henri Yandell wrote: >> Maven release plugin is the one doing the copy to the branch. So I >>  don't see the commit message (well.. it's probably somewhere in the >>  huge load of text that passes through). It also changes things befo

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-23 Thread sebb
On 23/05/2009, Henri Yandell wrote: > On Fri, May 22, 2009 at 3:56 AM, sebb wrote: > > On 22/05/2009, Henri Yandell wrote: > >> On Thu, May 21, 2009 at 8:24 AM, sebb wrote: > >> > On 21/05/2009, Henri Yandell wrote: > >> >> I don't expect this to pass the first vote - they never do :) >

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-22 Thread Henri Yandell
On Fri, May 22, 2009 at 3:56 AM, sebb wrote: > On 22/05/2009, Henri Yandell wrote: >> On Thu, May 21, 2009 at 8:24 AM, sebb wrote: >>  > On 21/05/2009, Henri Yandell wrote: >>  >> I don't expect this to pass the first vote - they never do :) >>  >> >>  >>  --- >>  >> >>  >>  Tag: >>  >> >>  >>

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-22 Thread sebb
On 22/05/2009, Henri Yandell wrote: > On Thu, May 21, 2009 at 8:24 AM, sebb wrote: > > On 21/05/2009, Henri Yandell wrote: > >> I don't expect this to pass the first vote - they never do :) > >> > >> --- > >> > >> Tag: > >> > >> > https://svn.apache.org/repos/asf/commons/proper/colle

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Henri Yandell
gmail.com] >> Sent: Thursday, May 21, 2009 1:24 AM >> To: Commons Developers List >> Subject: [COLLECTIONS] 3.3 RC1 for review >> >> I don't expect this to pass the first vote - they never do :) >> >> --- >> >> Tag: >> >> https://svn

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Henri Yandell
On Thu, May 21, 2009 at 8:24 AM, sebb wrote: > On 21/05/2009, Henri Yandell wrote: >> I don't expect this to pass the first vote - they never do :) >> >>  --- >> >>  Tag: >> >>  https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_3_3_RC1 > > Which revision is this? I'm as

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Henri Yandell
On Thu, May 21, 2009 at 6:41 AM, Christian Grobmeier wrote: >> I don't expect this to pass the first vote - they never do :) > > :-) > >> Site: >> >> http://people.apache.org/builds/commons/collections/3.3/RC1/site/index.html > > On the left side, start page: > * Javadoc (3.2 release) (should be 3

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Rahul Akolkar
On Thu, May 21, 2009 at 4:23 AM, Henri Yandell wrote: > I don't expect this to pass the first vote - they never do :) > Minor nit IMO is that the release plugin took out the pom license header. Dry running release:prepare will help fix the glitch. -Rahul > --- > > Tag: > > https://svn.apache.

RE: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Gary Gregory
On the site: "CollectionUtils - sizeIsEmpty(null) return trues" Should be "true" Gary > -Original Message- > From: Henri Yandell [mailto:flame...@gmail.com] > Sent: Thursday, May 21, 2009 1:24 AM > To: Commons Developers List > Subject: [COLLECTIO

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread sebb
On 21/05/2009, Henri Yandell wrote: > I don't expect this to pass the first vote - they never do :) > > --- > > Tag: > > > https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_3_3_RC1 Which revision is this? I'm assuming r777000 (nice number!) Two files don't have AL

Re: [COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Christian Grobmeier
> I don't expect this to pass the first vote - they never do :) :-) > Site: > > http://people.apache.org/builds/commons/collections/3.3/RC1/site/index.html On the left side, start page: * Javadoc (3.2 release) (should be 3.3 release) * startedUser's Guide (should have a space between) More: * D

[COLLECTIONS] 3.3 RC1 for review

2009-05-21 Thread Henri Yandell
I don't expect this to pass the first vote - they never do :) --- Tag: https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_3_3_RC1 Site: http://people.apache.org/builds/commons/collections/3.3/RC1/site/index.html Binaries: http://people.apache.org/builds/commons/coll