Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-28 Thread Emmanuel Bourg
Le 28/10/2024 à 14:30, Gilles Sadowski a écrit : The last part involves the trade-off between "code reuse" and "dependency". 20 lines is small, sure, but every "bloat" has always started small; then the same argument applied for every new small bit of code: Not worth adding a dependency). So t

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-28 Thread Gilles Sadowski
Hi. Le lun. 28 oct. 2024 à 14:36, Bernd Eckenfels a écrit : > > Hello, > > I don’t think a new shared library for HexFormat is a good idea here and > removing codec with a simple code inline would be my preference as well. Do > we really want to maintain a new lib Yes, if it solves the problem

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-28 Thread Bernd Eckenfels
Hello, I don’t think a new shared library for HexFormat is a good idea here and removing codec with a simple code inline would be my preference as well. Do we really want to maintain a new lib for code which hasn’t changed in ages as it has a trivial specification. Maybe to add another datapo

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-28 Thread Gilles Sadowski
Hi. Le lun. 28 oct. 2024 à 13:38, Emmanuel Bourg a écrit : > > Le 26/10/2024 à 20:32, Elliotte Rusty Harold a écrit : > > > That's exactly backwards. Code changes have to be technically > > justified. The responsibility is on the proposer, not the vetoer, to > > demonstrate that the change os wor

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-28 Thread Emmanuel Bourg
Le 26/10/2024 à 20:32, Elliotte Rusty Harold a écrit : That's exactly backwards. Code changes have to be technically justified. The responsibility is on the proposer, not the vetoer, to demonstrate that the change os worthwhile. Code changes are not accepted by default unless there's good and va

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-26 Thread Elliotte Rusty Harold
On Fri, Oct 25, 2024 at 11:25 PM Emmanuel Bourg wrote: > > Le 25/10/2024 à 12:57, Gary Gregory a écrit : > > -1, please revert and stop inlining Commons methods all over itself. > > Could you elaborate why in this case please? Vetos to code changes have > to be technically justified. You can't jus

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-25 Thread Gary Gregory
On Fri, Oct 25, 2024 at 7:25 PM Emmanuel Bourg wrote: > Le 25/10/2024 à 12:57, Gary Gregory a écrit : > > -1, please revert and stop inlining Commons methods all over itself. > Allow me to restate and elaborate on what I said in the Compress commit reply and in the thread titled "[All] Usage of

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-25 Thread Emmanuel Bourg
Le 25/10/2024 à 12:57, Gary Gregory a écrit : -1, please revert and stop inlining Commons methods all over itself. Could you elaborate why in this case please? Vetos to code changes have to be technically justified. You can't just say that you don't like them. In this specific case, Commons

Re: (commons-configuration) 05/05: Remove the dependency on commons-codec

2024-10-25 Thread Gary Gregory
-1, please revert and stop inlining Commons methods all over itself. Thank you, Gary On Fri, Oct 25, 2024 at 6:06 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > ebourg pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/com