Le 25/10/2024 à 12:57, Gary Gregory a écrit :
-1, please revert and stop inlining Commons methods all over itself.
Could you elaborate why in this case please? Vetos to code changes have to be technically justified. You can't just say that you don't like them.
In this specific case, Commons Codec was used for the Base64 codec which has now a standard equivalent in Java 8, and for the Hex class only used in the PList implementations that will be replaced by the Java 17 HexFormat class. Since Commons Configuration still supports Java 8 I suggest using a trimmed down copy of the Commons Codec class to avoid the extra dependency.
Ironically, I authored the PList configurations 19 years ago, I hope I can still have a say on how they are implemented today :)
Emmanuel Bourg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
