Re: [LANG] [DISCUSS] Java Modularity support in commons-lang3

2024-12-15 Thread Mark Struberg
> Am 14.12.2024 um 12:00 schrieb Piotr P. Karwasz : > > Hi Mark, > > On 9.12.2024 17:37, Mark Struberg wrote: >> c) try using this on a class which contains e.g. an ArrayList, a Set or a >> Map. It will e.g. use List#equals() which also does equals() on it's

[LANG] [DISCUSS] Java Modularity support in commons-lang3

2024-12-09 Thread Mark Struberg
Hi! I created a PR which aims to fix commons-lang behaviour which is broken since quite a few years. To be more precise: commons-lang doesn't fully support anything beyond Java8 due to not acknowledging the java module system (leading to InaccessibleObjectException). And no, adding --add-opens

Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

2024-12-07 Thread Mark Struberg
Could you please also take a look? I peeked at commits@ and notifications@ and didn't see it. So maybe I overlooked them or they are not there. txs and LieGrue, strub > Am 07.12.2024 um 17:05 schrieb sebb : > > On Sat, 7 Dec 2024 at 14:00, Mark Struberg <mailto:strub...

Re: [Lang] Method name (Was: [PR] Fb jpms - fixes for [...])

2024-12-07 Thread Mark Struberg
Hi Gilles! > Maybe something like `isNonIntrospectibleClass()`? Thanks, that's a really good name! I've changed it and pushed it to the PR. Btw, on a more general level. It seems that the discussions on the PRs are NOT mirrored on any ASF lists? Nor does the discussions on slack obviously. And

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-08 Thread Mark Struberg
anges. LieGrue, strub > Am 08.03.2024 um 13:19 schrieb Gary Gregory : > > The next question is whether any of this should be mentioned/recorded in > the Javadoc or at least in a code comment. > > Gary > > On Fri, Mar 8, 2024, 5:24 AM Mark Struberg > wrote: > &g

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-08 Thread Mark Struberg
maller? Not > sure about this though. > > > > On Thu, Mar 7, 2024 at 8:55 AM Gary D. Gregory wrote: > >> On 2024/03/07 06:58:30 Mark Struberg wrote: >>> The question to me is how we can make it more robust. >>> In a Collection (but actually also in most

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-08 Thread Mark Struberg
he same. And further thinking about it: what if we *always* invoke equals() first, and if it returns true -> return true and skip the rest for this tree? LieGrue, strub > Am 07.03.2024 um 14:55 schrieb Gary D. Gregory : > > On 2024/03/07 06:58:30 Mark Struberg wrote: >> The que

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
x27;d suggest you test and iterable over a Collection > instead of a List. > > Then you'd need a separate test and traversal for Map instances. > > (Still no common super-interface in Java 21 for Collections and Maps...) > > Gary > > On Wed, Mar 6, 2024 at 7:40 AM Ma

Re: [LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
about > "useEqualsIfPresent". > > Gary > > On Wed, Mar 6, 2024, 5:03 AM Mark Struberg > wrote: > >> Hi! >> >> I have a question about EqualsBuilder#reflectionEquals. From Java9 onwards >> we get more and more nasty module problems.

[LANG] EqualsBuilder#reflectionEquals feature brainstorming

2024-03-06 Thread Mark Struberg
Hi! I have a question about EqualsBuilder#reflectionEquals. From Java9 onwards we get more and more nasty module problems. Mainly because the code tries to recurse into java.util.* classes as well. I know that I can use setBypassReflectionClasses for those. But wouldn't it be fine to have an ad

Re: [EXTERNAL] [exec][email] Java 7 to 8

2021-03-23 Thread Mark Struberg
Oracle changed the license past Java8. Oracle Java is not free anymore. OpenJDK is though. So for anything later people have to move to AdoptOpenJDK. And company executives seem to be not sure about that move yet. Also the half year cadence leads to way less testing on a specific Java Version. E

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-28 Thread Mark Struberg
at's why I opted for calling create(). But of course, that has other potential issues :/ LieGrue, strub > Am 28.11.2018 um 04:21 schrieb Phil Steitz : > > On 11/26/18 1:23 PM, Phil Steitz wrote: >> On 11/26/18 8:29 AM, Phil Steitz wrote: >>> On 11/26/18 6:19 AM, M

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-26 Thread Mark Struberg
I think we still need to address what happens if null gets returned in create(). This was something I missed. Not sure if it got addressed in the meantime? LieGrue, strub > Am 26.11.2018 um 14:26 schrieb Rob Tompkins : > > > >> On Nov 26, 2018, at 8:16 AM, Mark Struberg

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-26 Thread Mark Struberg
en. So I fear we really need to tackle this. Stackoverflow and our own bug tracker is full of such reports :( LieGrue, strub > Am 23.11.2018 um 16:51 schrieb Phil Steitz : > > On 11/23/18 2:57 AM, Mark Struberg wrote: >> should read: This change (putting a new item back to the i

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-26 Thread Mark Struberg
ments. LieGrue, strub > Am 23.11.2018 um 16:18 schrieb Gary Gregory : > > On Fri, Nov 23, 2018 at 2:57 AM Mark Struberg > wrote: > >> should read: This change (putting a new item back to the idle pool) was >> needed to prevent a dead-lock >> >> *grabbing a

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-23 Thread Mark Struberg
ror: expected:<5> but was:<4> >at > org.apache.commons.pool2.impl.TestAbandonedObjectPool.testAbandonedInvalidate(TestAbandonedObjectPool.java:202) > > Maybe this is due to my busy CPU, not sure. > > Gary > > >> >> Phil >> >> On 11/19

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-23 Thread Mark Struberg
should read: This change (putting a new item back to the idle pool) was needed to prevent a dead-lock *grabbing a fresh coffee* > Am 23.11.2018 um 10:49 schrieb Mark Struberg : > > This change (putting a new item back to the idle pool was needed to prevent a &g

Re: [IO] Provenance of copied code in InfiniteCircularInputStream

2018-11-21 Thread Mark Struberg
+1. This is so trivial that it doesn't pass the threshold of originality. LieGrue, strub > Am 19.11.2018 um 18:15 schrieb Mark Thomas : > > I'd image the comment is referring to the use of "... & 0xFF" but it > seems to be a fairly pointless comment as that is just the standard way > to switch f

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-19 Thread Mark Struberg
tem.outs made it into the test code in one of the > commits related to POOL-340. > > Phil >> >> Gary >> >> >>> Cheers, >>> -Rob >>> >>>> On Nov 19, 2018, at 7:18 AM, Mark Struberg >>> wrote: >>>> Oki,

Re: [VOTE] [CANCEL] Release Apache Commons Pool2 2.6.1

2018-11-19 Thread Mark Struberg
regory a >> écrit >>> : >>> >>>> On Wed, Nov 14, 2018 at 8:59 AM Mark Struberg >> >>> >>>> wrote: >>>> >>>>> Oki, now the full VOTE text! >>>>> >>>>> I'd like to

Re: Release Managers?

2018-11-14 Thread Mark Struberg
Let's see how the commons-pool2 release works out. If it does then we have significantly reduced the work to run the release. It's basically down to: * ensure jira tickets are resolved and tracked in changes.xml * generate the release_notes updates * create a release branch with %> git checkout

Re: [VOTE] Release Apache Commons Pool2 2.6.1

2018-11-14 Thread Mark Struberg
> to host the RC sources on the Apache Nexus repo instead of the dist tree. > > This is different from how we usually do RCs but is should be OK. > > Not sure about using GitHub though... > > Gary > > On Wed, Nov 14, 2018, 09:00 Mark Struberg >> PS: the V

Re: [VOTE] Release Apache Commons Pool2 2.6.1

2018-11-14 Thread Mark Struberg
PS: the VOTE is open for 72h from now on. LieGrue, strub > Am 14.11.2018 um 16:58 schrieb Mark Struberg : > > Oki, now the full VOTE text! > > I'd like to call a VOTE on releasing Apache Commons pool2 2.6.1 > The release was run with JDK-1.7 to ensure Java7 compati

Re: [VOTE] Release Apache Commons Pool2 2.6.1

2018-11-14 Thread Mark Struberg
JDKs LieGrue, strub > Am 14.11.2018 um 10:13 schrieb Mark Struberg : > > PS: I've created the release in a GIT manner and pushed the according changes > to my ASF-linked github repo > > https://github.com/struberg/commons-pool/tree/release_branch_2.6.1 > the s

Re: [all] Amazon Corretto

2018-11-14 Thread Mark Struberg
One more option. Which is good for the Java ecosystem. LieGrue, strub > Am 14.11.2018 um 15:14 schrieb Rob Tompkins : > > Curious to see what people’s thoughts are to this: > > https://aws.amazon.com/corretto/ > > -Rob > - >

Re: [VOTE] Release Apache Commons Pool2 2.6.1

2018-11-14 Thread Mark Struberg
board level a long time ago (when we did DeltaSpike and CouchDB as the very first GIT repos at the ASF) and is perfectly fine as all this is based on cryptographically strong steps. LieGrue, strub > Am 14.11.2018 um 09:17 schrieb Mark Struberg : > > Hi folks! > > I'm curren

[VOTE] Release Apache Commons Pool2 2.6.1

2018-11-14 Thread Mark Struberg
Hi folks! I'm currently preparing the release for commons-pool2-2.6.1 So far I did * fix the missing parts in changes.xml * generate + copy the RELEASE_NOTES * run the maven release (after fixing the setup...) The ASF staging repository is at https://repository.apache.org/content/repositories/

Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1

2018-11-13 Thread Mark Struberg
ered by unit tests? That should do it I hope. > > Gary > > On Mon, Nov 12, 2018 at 12:56 AM Mark Struberg > wrote: > >> sorry should have read "did anyone TEST my pool fixes". >> >> LieGrue, >> strub >> >> >>> Am 10.11.

Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1

2018-11-11 Thread Mark Struberg
sorry should have read "did anyone TEST my pool fixes". LieGrue, strub > Am 10.11.2018 um 23:24 schrieb Gary Gregory : > > On Sat, Nov 10, 2018 at 1:24 PM Mark Struberg > wrote: > >> Did anyone fix my pool fixes? > > > Hi Mark, > > Can

Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1

2018-11-10 Thread Mark Struberg
Did anyone fix my pool fixes?The latest deployed pool and dbcp2 snapshots do contain them. Would love to start a release but I think I need some guidance. Any docs for how it runs in commons land? txs and LieGrue,strub On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory wrote: I a

Re: [pool] how to move to Java8?

2018-10-29 Thread Mark Struberg
s been added, which is not clear > since it seems changes.xml has not been updated for the commits over the > last week or two. > > Gary > > On Mon, Oct 29, 2018 at 6:49 AM Mark Struberg > wrote: > >> I've went through the list and pretty much the only tic

Re: [pool] how to move to Java8?

2018-10-29 Thread Mark Struberg
y need to bump to j8. LieGrue, strub > Am 29.10.2018 um 09:35 schrieb Mark Thomas : > > On 28/10/18 11:09, Mark Struberg wrote: >> Hi folks! >> I've worked through the open POOL tickets and found a few tickets which >> would like to enhance a few of our interfa

Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1

2018-10-29 Thread Mark Struberg
Txs gary! When will there be a new reelase run? If it's worth I could also do the release manager IF the project is properly set up. Means if it's a straight forward maven release then I gonna run it the same as my other dozen ASF projects. LieGrue, strub > Am 28.10.2018 um 15:29 schrieb Gar

[pool] how to move to Java8?

2018-10-28 Thread Mark Struberg
Hi folks! I've worked through the open POOL tickets and found a few tickets which would like to enhance a few of our interfaces. E.g. in POOL-355 we have a request to add a new method getMaxNumActive() to the ObjectPool interface. Now this would of course be a backward compatibility breaking chan

[pool] ignored but working PoolTest

2018-10-27 Thread Mark Struberg
Hi Gary! I've seen that PoolTest is ignored since you committed it back in 2016. But it's actually all green.Is there still something missing? Or can we simply enable it? txs and LieGrue,strub

Re: [VOTE] Release Apache Commons Configuration 2.4 based on RC2

2018-10-25 Thread Mark Struberg
Looks like a glitch. The class looks exactly the same like in 2.3. LieGrue, strub > Am 25.10.2018 um 00:11 schrieb Gary Gregory : > > I do not understand why Clirr is showing one error here: > https://dist.apache.org/repos/dist/dev/commons/configuration/2.4-RC2/site/clirr-report.html > > Could

POOL-356 deadlock patch

2018-10-24 Thread Mark Struberg
hi folks! Would be cool if someone firm in this project might review my patch for POOL-356https://github.com/apache/commons-pool/pull/11 I gonna commit it tomorrow morning if there was no negative feedback. txs and LieGrue,strub

usage of System.currentTimeMillis();

2018-10-24 Thread Mark Struberg
Hi folks! While fixing a deadlock in commons-pool I also stumbled across System.currentTimeMillis();quite a few times.It's no biggie but I would still love to get your feedback and experience. If I remember correctly then one should use Sytem.nanoTime() in those cases.a.) afair currentTimeMIllis

Re: [VOTE] Release Apache Commons Weaver 2.0 based on RC1

2018-09-06 Thread Mark Struberg
checked the source zip from https://dist.apache.org/repos/dist/dev/commons/weaver/2.0-RC1/source/ sha512 fine sig fine builds fine RAT passes. +1 LieGrue, strub > Am 04.09.2018 um 17:58 schrieb Matt Benson : > > I would like to release the [weaver] component. > > Apache Commons Weaver 2.0 R

Re: [WEAVER] Incomplete git migration?

2018-09-05 Thread Mark Struberg
The git repo is on ASF gitbox https://gitbox.apache.org/repos/asf/commons-weaver.git It's also listed on the gitbox overview page: https://gitbox.apache.org/repos/asf And here is the ASF mirror on GitHub https://github.com/apache/commons-weaver LieGrue, strub > Am 05.09.2018 um 08:46 schrieb

Re: [weaver] preparing a 1.4 release

2018-08-28 Thread Mark Struberg
+1 for a commons-weaver release. txs and LieGrue, strub > Am 03.08.2018 um 02:04 schrieb Gary Gregory : > > Good luck! :-) > > On Thu, Aug 2, 2018, 17:59 Matt Benson wrote: > >> Hello, >> If it wasn't obvious, I'm gearing up to create a 1.4 RC in the near future. >> I will serve as the relea

Re: [ALL] SHA256/512 hashes

2018-08-28 Thread Mark Struberg
> This is unlikely to happen as long as it does not cover multi-module builds The maven-release-plugin covers multi-module releases since many years. In the projects I'm working on there is no 'release manager'. _Everybody_ can do releases without having to know anything special. This is where th

rolling a commons-weaver release?

2018-06-09 Thread Mark Struberg
Hi folks! I'd like to run a commons-weaver release. We need it for Apache BVal. The new version adds Java9+10 support, etc Any objections? LieGrue, strub - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For addit

Re: [VOTE] Release Apache Commons JCS 2.0-beta-2 based on RC1

2016-10-24 Thread Mark Struberg
+1 LieGrue, strub > Am 24.10.2016 um 14:36 schrieb Johannes Weberhofer > : > > > > Am 21.10.2016 um 19:42 schrieb Thomas Vandahl: >> I would like to beta-release the [jcs] component. >> >> Apache Commons JCS 2.0-beta-2 RC1 is available for review at: >> https://dist.apache.org/repos/dist/d

Re: [collection][security] InvokerTransformer missused in java object serialisation exploits

2015-11-08 Thread Mark Struberg
SecurityManager is an ancient part and heavily slows down the JVM. That’s the reason why almost nobody is using it. LieGrue, strub > Am 08.11.2015 um 20:20 schrieb James Carman : > > I think this entire thing can be prevented with a security manager and a > proper policy in place. Nobody does

Re: [VOTE][JCS] release [jcs] 2.0-beta-1 (take 3)

2015-01-26 Thread Mark Struberg
: >>>>>>>> if that's the case +1 but anyway it doesnt hurt >>>>>>> >>>>>>> But it does have some consequences, because of the > license issues. >>>>>>> >>>>>>>>

Re: [VOTE][JCS] release [jcs] 2.0-beta-1 (take 3)

2015-01-25 Thread Mark Struberg
is that all? https://svn.apache.org/repos/asf/commons/proper/jcs/trunk/commons-jcs-core/src/aspect/org/apache/commons/Trace.aj Wouldn't it be actually quite easy to replace this? LieGrue, strub > On Sunday, 25 January 2015, 19:30, Thomas Vandahl wrote: > > On 25.01.15 17:00, Romain Manni-

Re: Announce: Commons Inject

2015-01-04 Thread Mark Struberg
1, Benedikt Ritter wrote: > > 2015-01-04 17:57 GMT+01:00 Mark Struberg : > >> Hi Jochen! >> >> >> The code is now indeed self-contained. I did not really look at the code >> but like to start with just a few small observations: >> >> 1.) the r

Re: Announce: Commons Inject

2015-01-04 Thread Mark Struberg
gt; > > > On Wed, Dec 17, 2014 at 11:52 AM, Benedikt Ritter > wrote: >> 2014-11-19 8:44 GMT+01:00 Mark Struberg : >>> >>> Jochen, I might have done something wrong so please help me. >>> >>> I've checked out your svn link and bui

Re: commons-parent maven pom highly broken?

2014-12-13 Thread Mark Struberg
ASF parent pom. LieGrue, strub > On Saturday, 13 December 2014, 18:41, sebb wrote: > > On 13 December 2014 at 12:26, Mark Struberg wrote: >> Hi! >> >> I've never seen any other ASF project where it is such a torture to > release. >> This i

commons-parent maven pom highly broken?

2014-12-13 Thread Mark Struberg
Hi! I've never seen any other ASF project where it is such a torture to release. This is partly because the quality level is really high, but a big part of it is that we don't have a mature parent pom. I have no clue why we don't just use the common apache parent pom. I've NEVER experienced s

Re: Announce: Commons Inject

2014-11-18 Thread Mark Struberg
e you using guice and guava for? Also there is an own ASF package for atinject [1]. LieGrue, strub [1] http://repo1.maven.org/maven2/org/apache/geronimo/specs/geronimo-atinject_1.0_spec/1.0/ On Wednesday, 19 November 2014, 8:34, Mark Struberg wrote: >> Sorry, did not mean to step o

Re: Announce: Commons Inject

2014-11-18 Thread Mark Struberg
> Sorry, did not mean to step on somebody's toes. No worries you didn't. It's most probably our fault as our (OpenWebBeans) documentation sucks and we did not properly document all this stuff ;) If one of you guys is at ApacheCon in Budapest right now, then I'd love to give you a quick rush thr

Re: Announce: Commons Inject

2014-11-18 Thread Mark Struberg
>> - I'm under the impression there are already well established >> implementations of JSR 330 Well, the problem I see with this very approach is that it says it 'implements JSR-330'. As an EG member I can tell you that atinject is only the least common denominator of the 'user side' of the stor

Re: Announce: Commons Inject

2014-11-18 Thread Mark Struberg
Hi Olivier! There are ways to just exclude known jars from getting scanned by OpenWebBeans. And if the current solution isn't sufficient then just pop up on our list and we gonna implement it. Maybe I've overlooked you on the list or did you not yet reach out to us? LieGrue, strub -

Re: [jcs] What's next?

2014-05-06 Thread Mark Struberg
Well my personal experience only: 1.) I barely use distributed caches. I use ehcache in most of my projects as of today, but do not use the distribution feature much. Way too complicated 2.) What actually IS useful is distributed cache invalidation. The caching side is fine to just select any

Re: [jcs] building with JSR-107 TCK

2014-05-03 Thread Mark Struberg
Weird, it compiles on my box (Oracle1.7 and 1.8 on Mac) and I get another compile error with Apple java-1.6.0_65 Have to finish a presentation till monday and work on BatchEE for $$dayjob. So I will only be able to help again starting with Thuesday. LieGrue, strub > On Friday, 2 May 2014,

Re: JDK8 compatible javadoc

2014-05-02 Thread Mark Struberg
>so it would be nice if our components do compile and work on Java 8 It does of course. But if you compile with java8 then it _might_ not work with older java versions. So it's fine for packages built by Fedora FOR Fedora. But those jars might not work on any other linux distro. Which is ok from

Re: JDK8 compatible javadoc

2014-05-02 Thread Mark Struberg
-Xdoclint:all -Xdoclint:-missing -Xdoclint:-html That should fix the issue. ATTN: this must ONLY be done in a java8 profile! If you set those params in older java versions (1.7, 1.6) then the build will blow up... LieGrue, strub On Wednesday, 30 April 2014, 7:47, Paul Benedict wrote: Looks

Re: Apache Commons & ApacheCon Europe 2014 ...

2014-05-02 Thread Mark Struberg
what about commons lightning talks? 5 minutes about a certain commons feature. There are plenty to choose from... LieGrue, strub On Friday, 2 May 2014, 10:28, Siegfried Goeschl wrote: Hi Benedikt, > >there might be a lot of different kinds there :-) > >IMHO the problem with "Let people tell u

Re: [ALL] Suppressing Javadoc errors with Java 8 - temporary hack

2014-05-02 Thread Mark Struberg
with additional @todo tags. They are configured in > the project parent, but it seems from the effective pom that they are > not used in all invocations, at least they made the build fail (and I > wrongly corrected them). > > Bernd > > >> >> >> On Thu, May

Re: [jcs] building with JSR-107 TCK

2014-05-01 Thread Mark Struberg
Hi! I've looked at Continuum and it seems like it fails since weeks now. Anyone successfully did run it with jdk-1.6? If so, we should rather look at the Continuum config. LieGrue, strub > On Thursday, 1 May 2014, 16:39, Thomas Vandahl wrote: > > On 01.05.14 09:52, Mark

Re: [jcs] building with JSR-107 TCK

2014-05-01 Thread Mark Struberg
gt; Github: https://github.com/rmannibucau > > > > 2014-05-01 12:24 GMT+02:00 Mark Struberg : >> Well, the TCK runs fine with source and target 1.6. There is nothing in our > code which requires java7 yet. Thus there is imo no reason to force it. >> >> LieGrue, >

Re: [jcs] building with JSR-107 TCK

2014-05-01 Thread Mark Struberg
Well, the TCK runs fine with source and target 1.6. There is nothing in our code which requires java7 yet. Thus there is imo no reason to force it. LieGrue, strub > On Thursday, 1 May 2014, 9:53, Mark Struberg wrote: > > Hi folks! > > I've moved the TCK run into an

Re: [ALL] Suppressing Javadoc errors with Java 8 - temporary hack

2014-05-01 Thread Mark Struberg
Actually the ',' causes a bug in the maven-javadoc-plugin. What seems to work is to split it into 2 parts: -Xdoclint:all -Xdoclint:-missing Already started a discussion about adding it to apache-parent over in maven-dev. LieGrue, strub > On Thursday, 1 May 2014, 11:05,

Re: [ALL] Suppressing Javadoc errors with Java 8 - temporary hack

2014-05-01 Thread Mark Struberg
>I would prefer it if the reports were warnings rather than errors, but >generally they seem sensible. Allow me to disagree. Breaking the javadoc just because a @param is missing is imo plain wrong. Usually parameters should be self-explaining. I personally only document interfaces and methods

[jcs] building with JSR-107 TCK

2014-05-01 Thread Mark Struberg
Hi folks! I've moved the TCK run into an own profile. You can activate it via $> mvn clean install -PjcacheTck We should also activate it by default during a release. Btw, why is this project target 1.7? We do not use anything from java7 right? LieGrue, strub

Re: [jcs] jcache support?

2014-04-30 Thread Mark Struberg
://fr.linkedin.com/in/rmannibucau >Github: https://github.com/rmannibucau > > >2014-04-30 8:26 GMT+02:00 Mark Struberg : >> Btw, fixed a few broken tests yesterday night, fixed the broken pom and >> added a few ALv2 license headers. >> >> Now all builds fine on my

Re: [jcs] jcache support?

2014-04-29 Thread Mark Struberg
Btw, fixed a few broken tests yesterday night, fixed the broken pom and added a few ALv2 license headers. Now all builds fine on my local box (w java8). LieGrue, strub On Tuesday, 29 April 2014, 22:20, Mark Struberg wrote: plz folks do a full build before committing stuff next time. >W

Re: [jcs] jcache support?

2014-04-29 Thread Mark Struberg
plz folks do a full build before committing stuff next time. Will fix the hamcrest deps now. LieGrue, strub On Tuesday, 29 April 2014, 20:58, Thomas Vandahl wrote: On 28.04.14 20:55, Emmanuel Bourg wrote: >> Le 28/04/2014 20:44, Thomas Vandahl a écrit : >> >>> This throws me out of the game.

Re: [VOTE] Release Apache Commons Weaver 1.0 based on RC1

2014-02-20 Thread Mark Struberg
+1 >The poms don't include any groupId definitions. Not needed and sometimes even a source of problems. If you do not need to write something than adding it only raises the chance it gets wrong. > - The jar artifacts contain LICENSE and NOTICE without the .txt extension. That's perfectly fine

Re: [VOTE] Promote [weaver] component out of sandbox

2013-09-20 Thread Mark Struberg
+1 LieGrue, strub - Original Message - > From: Matt Benson > To: dev@commons.apache.org > Cc: > Sent: Friday, 20 September 2013, 19:49 > Subject: [VOTE] Promote [weaver] component out of sandbox > > Hi Commons developers, >   I hereby propose a vote to promote the [weaver] sandbox c

Re: [proxy] and impl

2013-08-04 Thread Mark Struberg
JFTR: in Apache OpenWebBeans we switched to ASM because Javassist caused too much mem leaks and hassles. But we do only use reflection when it's really needed. Means methods which are neither delegated nor intercepted will delegated via native java calls. The same happens for 'NormalScoped' pr

Re: commons-monitoring?

2013-07-28 Thread Mark Struberg
Hi folks! Romain is a great guy, I've now added him to commons-sandbox. LieGrue, strub - Original Message - From: James Carman To: Commons Developers List Cc: Sent: Saturday, 27 July 2013, 3:46 Subject: Re: commons-monitoring? On Fri, Jul 26, 2013 at 9:36 PM, Romain Manni-Bucau w

Re: [VOTE][LAZY] Release Commons Parent 32 from RC1

2013-06-29 Thread Mark Struberg
+1 LieGrue, strub - Original Message - > From: sebb > To: dev@commons.apache.org > Cc: > Sent: Friday, 28 June 2013, 14:18 > Subject: [VOTE][LAZY] Release Commons Parent 32 from RC1 > >T his is a VOTE to release Commons Parent 31-RC2 > > This VOTE by LAZY-CONSENSUS is open for at l

Re: commons-monitoring?

2013-02-13 Thread Mark Struberg
I'm not sure if this is needed in this case. The Java interceptors spec got moved out of EJB a long time a go and is now a standalone spec which is used by CDI, Spring and guice. The package is javax.interceptor and contains all the stuff we need. If we do it in a similar style than Apache MyFac

Re: [weaver] SPI decisions

2013-01-05 Thread Mark Struberg
- Original Message - > From: Matt Benson > > Weaver#weave(): > >   Currently there are separate methods for weaving a class vs. a method.  I > think it would be sufficient and cleaner to have a class weaving method > only; having provided its "interests," the Weaver can presumably >

[privilizer] new idea to improve usability

2012-12-30 Thread Mark Struberg
Hi! Not sure if this is worth doing, but could be nice from a usability pov. Usually projects have a lot of blocks which need doPrivileged copied over from one class to the other. Using @Privileged makes this a lot easier. But you still need to add private methods to all your classes... Now i

Re: [commons-parent] drop cobertura

2012-12-29 Thread Mark Struberg
> Any better suggestions for [math]? Yes, as I see it there are two options. a.) move some parts into a profile b.) create 2 parent pom. One with the infrastructure stuff and one with all the tons of additional goodies only needed for the other projects. LieGrue, strub PS: I find it pretty w

Re: [commons-parent] drop cobertura

2012-12-29 Thread Mark Struberg
or just move it to a profile? In our project we have this enabled via $> mvn clean instal -Pcoverage LieGrue, strub - Original Message - > From: Luc Maisonobe > To: Commons Developers List > Cc: > Sent: Saturday, December 29, 2012 9:43 AM > Subject: Re: [commons-parent] drop cobert

Re: commons-sandbox-parent needs some updates

2012-12-26 Thread Mark Struberg
Can anyone plz commit the pom upgrade for sandbox-parent? https://issues.apache.org/jira/browse/SANDBOX-437 Need this for commons-weaver. LieGrue, strub > > From: Mark Struberg >To: Commons Developers List >Sent: Saturday, December 22,

[weaver] blow up if access level is not correctly set

2012-12-22 Thread Mark Struberg
I changed the privilizer weaver to blow up with an Exception if an access level is set and a @Privileged method which has a wider accesslevel got detected. Imo this is a clear user error if one defines a public @Privileged method and explicitly only wants them being private. Imo this is the onl

commons-sandbox-parent needs some updates

2012-12-22 Thread Mark Struberg
Hi! Seems like our commons-sandbox-parent is stone old. It points to a commons-parent-15 which is now 12 versions old ;) I'll fix this, check a few problems which I had with the old version and ship a patch. LieGrue, strub -

Re: [digester] dropping the annotations-processor module

2012-12-22 Thread Mark Struberg
rate classes? > > TIA, > -Simo > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > On Sat, Dec 22, 2012 at 10:45 AM, Mark Struberg wrote: >> I have no clu

Re: [digester] dropping the annotations-processor module

2012-12-22 Thread Mark Struberg
I have no clue what the annotation processing is for, but might that be a candidate for the upcoming commons-weaver (formerly privilizer) ? It takes CLASS/RUNTIME annotations a modifies the bytecode in the class directly. LieGrue, strub - Original Message - > From: Simone Tripodi >

Re: svn commit: r1424618 - in /commons/sandbox/privilizer/trunk: ./ ant/ ant/lib/ ant/test/ example/ maven-plugin/ modules/ modules/privilizer/ modules/privilizer/api/ modules/privilizer/api/src/main/

2012-12-21 Thread Mark Struberg
committed in r1424835. Please note that weaver alone has 11 modules so far. And it's likely to become more... LieGrue, strub - Original Message - > From: Mark Struberg > To: Commons Developers List > Cc: > Sent: Friday, December 21, 2012 10:43 AM > Sub

Re: svn commit: r1424618 - in /commons/sandbox/privilizer/trunk: ./ ant/ ant/lib/ ant/test/ example/ maven-plugin/ modules/ modules/privilizer/ modules/privilizer/api/ modules/privilizer/api/src/main/

2012-12-21 Thread Mark Struberg
ilizer/ > modules/privilizer/api/ > modules/privilizer/api/src/main/java/org/apache/commons/weaver/privilizer/ > modules/privi... > > Hi Mark, > > Mark Struberg wrote: > >> Jörg, what about all older living projects which used to have own groups >> ev

Re: svn commit: r1424618 - in /commons/sandbox/privilizer/trunk: ./ ant/ ant/lib/ ant/test/ example/ maven-plugin/ modules/ modules/privilizer/ modules/privilizer/api/ modules/privilizer/api/src/main/

2012-12-21 Thread Mark Struberg
Jörg, what about all older living projects which used to have own groups even, like commons-lang:commons-lang? Could you point me to this boilerplate stuff you think off? Maybe we can improve this. I have no problem with moving the packages back, but I personally think this would á la long end

Re: svn commit: r1424618 - in /commons/sandbox/privilizer/trunk: ./ ant/ ant/lib/ ant/test/ example/ maven-plugin/ modules/ modules/privilizer/ modules/privilizer/api/ modules/privilizer/api/src/main/

2012-12-20 Thread Mark Struberg
Hi! Yes, I find it not very handsome to pollute the o.a.commons directory itself with tons of modules which are completely unrelated to each other. That is fine with a single module project but imo definitely not ok for a project which consists of a few sub-modules. Thus I'd rather collect all

Re: [VOTE][CANCEL] Release of commons-email-1.3 based on RC4

2012-12-11 Thread Mark Struberg
we had this over here at UPC as well. This did cost Sigi a release as well if you remember ;) Most times this can be disabled by your provider. Just phone them and explain that they are breaking your computer and this creates costs by them not acting standard conform ;) LieGrue, strub

Re: [weaver]/[bcel] WAS [privilizer] promotion plan

2012-12-06 Thread Mark Struberg
One of the stuff I heard way back was that BCEL still has no native Java7 support. Is this still true? Imo that was one of the reasons why openjpa went for doing parts of the bytecode stuff with ASM... Happy to get proved wrong ;) LieGrue, strub - Original Message - > From: Matt Be

Re: [privilizer] promotion plan

2012-11-28 Thread Mark Struberg
+1 It might fit to any component which does _not_ introduce a runtime dependency but is only needed at compile time. Basically the privilizer is kind of a preprocessor. If such a kind of component already exists in commons, then we can look if it fits to the business of this component. Otherw

Re: [privilizer] new sandbox component

2012-11-21 Thread Mark Struberg
leged block will get added to the callers class and the invocation will get replaced with that method. Maybe I miss something, but for me that sounds safe. LieGrue, strub > > From: Matt Benson >To: Commons Developers List ; Mark Struberg >

Re: [privilizer] new sandbox component

2012-11-21 Thread Mark Struberg
-privilizer in the project could do that. That's of course more work to do than the current approach, but could be worth looking at. That could be done in a v2 release as well. LieGrue, strub > > From: Matt Benson >To: Commons Developers List ;

Re: [privilizer] new sandbox component

2012-11-20 Thread Mark Struberg
: > Sent: Tuesday, November 20, 2012 6:40 AM > Subject: Re: [privilizer] new sandbox component > >G lad to hear it, Phil!  I was originally calling it "privileged method > weaver" but that's a little long for a Commons component.  Mark > Struberg > cam

Re: Proposal Commons-JNDI

2012-08-08 Thread Mark Struberg
+1, such a thingy is needed pretty often! LieGrue, strub - Original Message - > From: Phil Steitz > To: Commons Developers List > Cc: > Sent: Wednesday, August 8, 2012 4:50 PM > Subject: Re: Proposal Commons-JNDI > > On 8/7/12 11:02 PM, Jochen Wiedmann wrote: >> Hi, >> >> I'd lik

Re: another new URL() question

2012-06-13 Thread Mark Struberg
Davids route via an 'Archive' abstraction layer which we could plug-in. LieGrue, strub - Original Message - > From: "Honton, Charles" > To: Commons Developers List ; "gudnabr...@gmail.com" > ; Mark Struberg > Cc: > Sent: Monday, June 11,

another new URL() question

2012-06-10 Thread Mark Struberg
Regarding the new URL() problem some of you might have more experience than I do. I only know the problems on some platforms, and after looking at the URL class in detail, I really wonder whether that was me doing it wrong or a platform bug. My understanding problem is mainly around the URLStre

Re: [ALL] Using a Tool Like Sonar...

2012-06-09 Thread Mark Struberg
we have an own Sonar installation at http://analysis.apache.org already. You just need to tell infra that you like to have your project added. LieGrue, strub - Original Message - > From: Simone Tripodi > To: Commons Developers List > Cc: > Sent: Saturday, June 9, 2012 8:09 AM > Subje

Re: [classscan] Metadata API discussion

2012-06-09 Thread Mark Struberg
Hi folks, quick reply from vacation :) @sebb: yes correct. I was just thinking too complicated. We use the interface only for keeping the metainfo, and not in the metainfo itself. So it should itself not blow up the mem. So +1 for the interface. There are 2 important consideration options left

  1   2   >