Re: [6/8] git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/commons-math

2014-11-03 Thread Dennis Hendriks
Hi all, The mail below seems to suggest a bunch of files were changed, but how from this e-mail can I get a link to the actual diff of this commit? I tried the 'Diff' link below (to http://git-wip-us.apache.org/repos/asf/commons-math/diff/29b19362), but it gives me a page with some metadate (

git commits for common sub components don't identify the sub component in email subject

2014-10-09 Thread Dennis Hendriks
Hi all, From the subject of emails of the git commits (e.g. 'git commit: fixed too long first step in fixed Runge-Kutta integrators.'), it can no longer be seen that the commit is for a specific sub component of commons (e.g. 'commons-math'). It can be seen from the first line of the email its

Re: svn commit: r5188 - in /dev/commons/math: ./ binaries/ source/

2014-04-28 Thread Dennis Hendriks
> [...] see the Apache Apache Commons Math website: I think 'Apache Apache' should be 'Apache', at the end of the changelog? Best regards, Dennis On 04/29/2014 01:31 AM, t...@apache.org wrote: Author: tn Date: Mon Apr 28 23:31:16 2014 New Revision: 5188 Log: Creating distribution files for C

Re: [MATH] Test failure in Continuum

2012-08-06 Thread Dennis Hendriks
See below. On 08/06/2012 05:29 PM, Phil Steitz wrote: On Aug 6, 2012, at 6:06 AM, Dennis Hendriks wrote: See below. Dennis On 08/06/2012 02:48 PM, Phil Steitz wrote: On Aug 5, 2012, at 11:21 PM, Dennis Hendriks wrote: See below. On 08/06/2012 12:49 AM, Gilles Sadowski wrote

Fwd: Re: [MATH] Test failure in Continuum

2012-08-06 Thread Dennis Hendriks
Forward to commons-dev, as the reply was (accidentally?) only sent to me... Dennis Original Message Subject: Re: [MATH] Test failure in Continuum Date: Mon, 6 Aug 2012 17:29:59 +0200 From: Phil Steitz To: Hendriks, D. On Aug 6, 2012, at 6:06 AM, Dennis Hendriks wrote

Re: [MATH] Test failure in Continuum

2012-08-06 Thread Dennis Hendriks
See below. Dennis On 08/06/2012 02:48 PM, Phil Steitz wrote: On Aug 5, 2012, at 11:21 PM, Dennis Hendriks wrote: See below. On 08/06/2012 12:49 AM, Gilles Sadowski wrote: On Sun, Aug 05, 2012 at 12:54:11PM -0700, Phil Steitz wrote: On 8/4/12 10:57 AM, Gilles Sadowski wrote: Hello

Re: [MATH] Test failure in Continuum

2012-08-05 Thread Dennis Hendriks
See below. On 08/06/2012 12:49 AM, Gilles Sadowski wrote: On Sun, Aug 05, 2012 at 12:54:11PM -0700, Phil Steitz wrote: On 8/4/12 10:57 AM, Gilles Sadowski wrote: Hello. Referring to this failed test (cf. messages from Continuum): ---CUT--- org.apache.commons.math3.exception.NumberIsTooLargeEx

Re: [MATH] Test failure in Continuum

2012-08-05 Thread Dennis Hendriks
> What could be done is > 1. create a static method in the distribution class > 2. have the "sample()" method call that one +1. I like that the sample implementation for a distribution is in the actual distribution class. Denis On 08/06/2012 02:30 AM, Gilles Sadowski wrote: [...] The origin

Re: [Math] Package "o.a.c.m.distribution"

2012-07-31 Thread Dennis Hendriks
See answers below. On 07/31/2012 12:00 PM, Gilles Sadowski wrote: On Tue, Jul 31, 2012 at 08:18:13AM +0200, Dennis Hendriks wrote: * Why doesn't "KolmogorovSmirnovDistribution" implement one of the interfaces of the package (and/or inherit from an abstract class)?

Re: [Math] Package "o.a.c.m.distribution"

2012-07-30 Thread Dennis Hendriks
> * Why doesn't "KolmogorovSmirnovDistribution" implement one of the >interfaces of the package (and/or inherit from an abstract class)? See also: http://apache-commons.680414.n4.nabble.com/math-KolmogorovSmirnovDistribution-not-part-of-the-distribution-hierarchy-td4114395.html > * Why is

Re: [math] javadoc unbalanced

2012-03-09 Thread Dennis Hendriks
improvement: According to [2] {@code } should be used in instead of and. Regards, Benedikt [1] https://issues.apache.org/jira [2] https://blogs.oracle.com/darcy/entry/javadoc_tip_code_and_literal Am 9. März 2012 11:34 schrieb Dennis Hendriks: Hi all, See http://commons.apache.org/math/apidocs

[math] javadoc unbalanced

2012-03-09 Thread Dennis Hendriks
Hi all, See http://commons.apache.org/math/apidocs/index-all.html and scroll to the section 'D'. Observe how in method discardMostRecentElements(int) in class org.apache.commons.math3.util.ResizableDoubleArray, the style changes to larger font. This can be fixed using this patch: Index: src

Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-23 Thread Dennis Hendriks
Sébastien Brisard wrote: Hi Dennis, Hi all, Now that I look at this code again, should we not attempt to avoid divide by zero in case a == b, in this method, and perhaps other methods of this class? I think the constructor takes care of this special case. >(...) Yes, you're right. Dennis

Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-22 Thread Dennis Hendriks
Hi all, Now that I look at this code again, should we not attempt to avoid divide by zero in case a == b, in this method, and perhaps other methods of this class? Also, looking that the Wikipedia article, at http://en.wikipedia.org/wiki/Triangular_distribution (which is referenced in the ja

[math] minimal step size exception has inverted numbers?

2012-02-15 Thread Dennis Hendriks
Hi all, I use a minimum integration step size of 1e-15, and got this error message: org.apache.commons.math.exception.NumberIsTooSmallException: minimal step size (8.97E-16) reached, integration needs 1.00E-15 It was generated here in AdaptiveStepSizeIntegrator, at line 326:

Re: [Math] Package "integration" (related to MATH-707)

2012-01-31 Thread Dennis Hendriks
I may be overlooking something, but isn't "BaseAbstractUnivariateIntegrator" double, in the sense that "Base" and "Abstract" both refer to an abstract base class that actual integrators can derive from? In other words, wouldn't "BaseUnivariateIntegrator" or "AbstractUnivariateIntegrator" be eno

[math] testSampleWrongBounds(org.apache.commons.math.analysis.FunctionUtilsTest) unit test failure

2012-01-17 Thread Dennis Hendriks
Hi all, I just tried to build trunk, but got this unit test failure: Results : Tests in error: testSampleWrongBounds(org.apache.commons.math.analysis.FunctionUtilsTest): Unexpected exception, expected but was Tests run: 3485, Failures: 0, Errors: 1, Skipped: 1 [INFO]

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2012-01-11 Thread Dennis Hendriks
** SCM Changes: Changed: celestin @ Thu 12 Jan 2012 07:01:43 + Comment: Implementation of continuous triangular distributions (MATH-731). Patch contributed by Dennis Hendriks. Files changed: /commons/proper/math/tr

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2011-09-22 Thread Dennis Hendriks
rote: Hi Dennis Oh, I guess I needed to log into apache in order to see this log... Sorry, should have thought about it myself. And ExponentialDistributionTest.java is not what I'm working on at the moment. So I guess I come out white clean this time... Sébastien 2011/9/22 Dennis Hendriks :

Re: [continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2011-09-22 Thread Dennis Hendriks
Hi Sébastien, From the log (http://vmbuild.apache.org/continuum/buildResult.action?buildId=12421&projectId=97): """ [INFO] Compiling 336 source files to /home/continuum/continuum-base/data/working-directory/97/target/test-classes [INFO] ---

Re: svn commit: r1165033 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/ode/sampling/StepHandler.java

2011-09-05 Thread Dennis Hendriks
Hi Luc, The FirstOrderDifferentialEquations interface has a method computeDerivatives, which also still throws the MathUserException. Did you forget that one as well, or did you intentionally leave it in? Best regards, Dennis luc.maison...@free.fr wrote: Hi Dennis, - Mail original ---

Re: [math] commit 1165155 results in error

2011-09-05 Thread Dennis Hendriks
Hi Sébastien, thanks for the quick response/commit. Dennis Sébastien Brisard wrote: Thanks Dennis for that! I forgot to commit the changes made to the DecompositionSolver interface (which explains what it compiled locally...). Hope it is now fixed in rev. 1165188. Sébastien 2011/9/5 Dennis

[math] commit 1165155 results in error

2011-09-04 Thread Dennis Hendriks
Hi all, commit 1165155 removed method "solve(double[] b)" from class Solver in org/apache/commons/math/linear/CholeskyDecompositionImpl.java, but it is still in the DecompositionSolver interface that the Solver class implements, thus resulting in an error, as the Solver class now no longer im

Re: svn commit: r1165033 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/ode/sampling/StepHandler.java

2011-09-04 Thread Dennis Hendriks
Hi Luc, question: is there a reason you applied this to StepHandler, but not FixedStepHandler? Best regards, Dennis l...@apache.org wrote: Author: luc Date: Sun Sep 4 14:36:48 2011 New Revision: 1165033 URL: http://svn.apache.org/viewvc?rev=1165033&view=rev Log: removed MathUserException

Re: [math] puzzled by generics in root solvers

2011-07-07 Thread Dennis Hendriks
Hi Gilles, > We also do not have a clear separation between algorithms that take a > bracket (e.g. "BrentSolver") and those that don't (e.g. "NewtonSolver"). > If the "solve" methods called by the user contains more parameters than > needed by the algorithm implemented in the instance, they will

Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/ma

2011-06-27 Thread Dennis Hendriks
;2.6.18-128.1.6.el5pae", arch: "i386", family: "unix" Dennis luc.maison...@free.fr wrote: - "Dennis Hendriks" a écrit : I tried 'mvn clean site', and got this: (...) main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-pl

Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/ma

2011-06-26 Thread Dennis Hendriks
debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException any ideas? Dennis Luc Maisonobe wrote: Le 24/06/2011 11:33, Dennis Hendr

Re: svn commit: r1139223 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/analysis/solvers/AllowedSolutions.java

2011-06-24 Thread Dennis Hendriks
> + * {@link org.apache.commons.math.odeODEIntegrator ODE solvers}, it Seems to be missing a dot between ode and ODEIntegrator... Dennis er...@apache.org wrote: Author: erans Date: Fri Jun 24 09:43:33 2011 New Revision: 1139223 URL: http://svn.apache.org/viewvc?rev=1139223&view=rev Log: Jav

Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/ma

2011-06-24 Thread Dennis Hendriks
> I prefer to have _one_ rule for code formatting. > [Also, you nvere know when you might need an additional statement wihtin > the conditional branch (e.g. when debugging).] I would indeed consider that a reasonable reason to indeed force the braces. Dennis Gilles Sadowski wrote: Hi. I agr

Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/ma

2011-06-24 Thread Dennis Hendriks
rom false > positive. People have to take time to check every warning manually each > time, so allowing warnings really wastes more time in the long term that > it saves in the short term. I agree. Dennis Luc Maisonobe wrote: Le 24/06/2011 09:09, Dennis Hendriks a écrit : I agree with you

Re: svn commit: r1139126 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/analysis/solvers/ site/xdoc/ test/java/org/apache/commons/math/analysis/ test/java/org/apache/commons/ma

2011-06-24 Thread Dennis Hendriks
I agree with you that braces should always be used. Personally, I do have one exception though, and that is if the statement following it is on the same line. That way, it is one line, instead of 3 lines, which makes it more readable. If the 'if' statement spans multiple lines, I always include