Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Emmanuel Bourg
Le 19/11/2024 à 22:26, Piotr P. Karwasz a écrit : As a compromise we could switch to AssertJ, which has parameterized descriptions and more readable:     assertThat(result).as("ValidatorResult for %s", action).isNotNull(); Nice fluent syntax, but let's not waste more time on this futile de

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Emmanuel Bourg
Le 19/11/2024 à 19:12, Emmanuel Bourg a écrit : I ran "mvn clean" and "mvn package" 20 times, ignoring the first 10 runs to warm up the system caches, and noted the total build time reported by Maven. The build machine is a 6 years old laptop (Core i6 7500U, 32GB RAM) on Windows 10, using Java

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Gary Gregory
Please, definitely not assert-j or hamcrest. I'd rather stay with the current mess. I've actually spent time replacing assert-j with JUnit calls because Java is verbose enough without this type of code. JUnit has the right balance and approach IMO. I've seen code using assertj that is silly when a

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Piotr P. Karwasz
Hi Gary, On 18.11.2024 17:11, Gary Gregory wrote: -1 you are undoing the port to JUnit 5. This commit is a classic JUnit mistake imo, please stop, these JUnit APIs exist for a reason: The lambdas avoid construction of failure message strings, which, as a pattern, add processing, can have side ef

[ANNOUNCE] Apache Commons IO 2.18.0

2024-11-19 Thread Gary Gregory
The Apache Commons team is pleased to announce Apache Commons IO 2.18.0. The Apache Commons IO library contains utility classes, stream implementations, file filters, file comparators, endian transformation classes, and more. Java 8 is required. Historical list of changes: https://commons.apache.

[RESULT][VOTE] Release Apache Commons IO 2.18.0 based on RC1

2024-11-19 Thread Gary Gregory
This vote passes with the following binding +1s from: - Bruno Kinoshita (kinow) - Gary Gregory (ggregory) - Henri Biestro (henrib) Thank you all, Gary On Mon, Nov 18, 2024 at 5:21 AM Henri Biestro wrote: > [ +1 ] > > Builds & tests, project reports look good, site ok, nice documentation > ( +1

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Emmanuel Bourg
Le 19/11/2024 à 18:10, Emmanuel Bourg a écrit : If you can prove your claim by demonstrating that this readability improvement degrades the build time of Commons Validator by more than 0.01% I'll happily revert it. Since I was asked privately in undiplomatic terms to do it myself, I'm sharin

Re: (commons-validator) 08/11: Removed unnecessary lambdas in the tests

2024-11-19 Thread Emmanuel Bourg
Le 18/11/2024 à 17:11, Gary Gregory a écrit : -1 you are undoing the port to JUnit 5. This commit is a classic JUnit mistake imo, please stop, these JUnit APIs exist for a reason: The lambdas avoid construction of failure message strings, which, as a pattern, add processing, can have side effects

Re: (commons-compress) branch master updated: Replace org.apache.commons.io.Charsets with org.apache.commons.compress.utils.Charsets

2024-11-19 Thread Gilles Sadowski
Hi. Le lun. 18 nov. 2024 à 11:05, Henri Biestro a écrit : > > > > > > It does not make sense to me to add any dependency (regardless of > > size) for such minor simplifications. > > > > [ +1 ] > > Adding a dependency should be done out of functional necessity, not to avoid > one-liners The disc