Le 19/11/2024 à 18:10, Emmanuel Bourg a écrit :
If you can prove your claim by demonstrating that this readability
improvement degrades the build time of Commons Validator by more than
0.01% I'll happily revert it.
Since I was asked privately in undiplomatic terms to do it myself, I'm
sharing my results.
I ran "mvn clean" and "mvn package" 20 times, ignoring the first 10 runs
to warm up the system caches, and noted the total build time reported by
Maven. The build machine is a 6 years old laptop (Core i6 7500U, 32GB
RAM) on Windows 10, using Java 8:
At commit 7eee2066, before the lambda change, I get:
38,329
39,184
38,875
37,826
38,887
39,952
38,313
38,434
39,277
38,802
Average: 38,788s ±601ms
At commit dfd4a9e4, on the commit removing the lambdas, I get:
37,182
38,614
37,486
38,777
38,242
37,486
38,464
37,436
38,825
38,805
Average: 38,132s ±660ms (1.7% improvement)
At commit cdc0125b, after all my changes, I get:
37,627
38,015
38,236
37,043
38,691
36,404
38,377
37,396
38,751
37,663
Average: 37,820s ±745 (2,5% improvement)
I didn't expect such a noticeable difference but it looks like the build
time actually improved.
Talking about build time, there are some plugins executed in the
compile/test phases (rat, buildnumber, animal-sniffer) that could be
moved to the package or install phases, or to the release profile to
save some time when developing.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
