Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
TY Piotr! Putting your pieces together for a local Commons Compress, this works for me: export TZ=UTC mvn clean install mvn clean package artifact:compare \ -Dreference.repo=apache.snapshots \ -DskipTests \ -Dcommons.spdx.version=0.7.1 -Dspdx.skip Gary On Fri, Dec 29, 2023 at 12:44 

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Piotr P. Karwasz
Hi Gary, On Fri, 29 Dec 2023 at 15:11, Gary Gregory wrote: > I run, copied from the > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/commons/compress/commons-compress-1.25.0.buildspec: > > mvn -Prelease clean package package -DskipTests -Dmaven.javadoc.ski

Re: [BEANUTILS] Is there a good reason for Converter to not be a FunctionalInterface?

2023-12-29 Thread Gary Gregory
Also https://issues.apache.org/jira/browse/BEANUTILS-564 Gary On Fri, Dec 29, 2023 at 7:02 AM Gary Gregory wrote: > > Also: > > - BeanIntrospector > - LocaleConverter > > Gary > > On Fri, Dec 29, 2023 at 6:56 AM Gary Gregory wrote: > > > > No reason aside from the fact that the code base is not

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
I run, copied from the https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/commons/compress/commons-compress-1.25.0.buildspec: mvn -Prelease clean package package -DskipTests -Dmaven.javadoc.skip -Dgpg.skip -Dcyclonedx.skip -Dcommons.release.dryRun -Dcommons.rel

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Piotr P. Karwasz
Hi Gary, On Fri, 29 Dec 2023 at 13:37, Gary Gregory wrote: > I do appreciate the fact that I can ask "Am I reproducible" but the > output is... cryptic. Yes, unfortunately if the check fails, finding the reason of the failure is hard. > For example: > ... > ├── META-INF/MANIFEST.MF > │ @@ -65,1

Re: Reproducibility of Commons artifacts was: [VOTE] Release Apache Commons Logging 1.3.0 based on RC1

2023-12-29 Thread Gary Gregory
Hi Piotr and all, Thank you for the refresher :-) I do appreciate the fact that I can ask "Am I reproducible" but the output is... cryptic. For example: git clone https://gitbox.apache.org/repos/asf/commons-compress.git cd commons-compress mvn clean install -DskipTests mvn package artifact:comp

Re: [BEANUTILS] Is there a good reason for Converter to not be a FunctionalInterface?

2023-12-29 Thread Gary Gregory
Also: - BeanIntrospector - LocaleConverter Gary On Fri, Dec 29, 2023 at 6:56 AM Gary Gregory wrote: > > No reason aside from the fact that the code base is not fully > modernized. You could also ask if Converter should extend BiFunction. > > I would like to create a release candidate for a 2.0.

Re: [BEANUTILS] Is there a good reason for Converter to not be a FunctionalInterface?

2023-12-29 Thread Gary Gregory
No reason aside from the fact that the code base is not fully modernized. You could also ask if Converter should extend BiFunction. I would like to create a release candidate for a 2.0.0-M1 release soon. This would unlock a lot of other work down the line. One item holding us back is that BeanUti

Re: [CLI] DISCUSS: Should Option(Builder) constructor be protected?

2023-12-29 Thread Gary Gregory
This code is probably quite old so the intent of the original author might be hard to come by since they might not be around. Whatever it might be, we can't break binary compatibility within the 1.x release line, so making a public or protected element final is a no-go. Running 'mvn' by itself sh

Re: [BEANUTILS] Is there a good reason for Converter to not be a FunctionalInterface?

2023-12-29 Thread Paul King
The 1.9.x releases are pre-JDK 8. The project looks set up for a 2.0 release where such a change might make sense but I don't think that has happened yet. Cheers, Paul. On Fri, Dec 29, 2023 at 6:12 PM Claude Warren wrote: > > I am looking at BeanUtils as part of the CLI options to parse a comman

[BEANUTILS] Is there a good reason for Converter to not be a FunctionalInterface?

2023-12-29 Thread Claude Warren
I am looking at BeanUtils as part of the CLI options to parse a command line option string into a class. I see that Converter is an interface with one method; converting a String to an Object. Is there a good reason for this not to be annotated as an @FunctionalInterface? Claude -- LinkedIn: ht