Hi Bruno,
Yeah sorry for being impatient, hope I didn't bother anyone, it was not the
point.
I'm not familiar with how such projects are maintained, but happy to learn
more about it every day.
Thanks for the answer by the way.
Both solutions you mention seem right to me too.
I understand the need
Hi Gary,
Fair enough. I only checked on case, in the Functions.java where a generic
type extends Throwable and triggers the issue in Spotbugs [1]
But I agree other cases might be legit code smells that need fixing. I will
revert the change on the master branch, and when/if Dependabot triggers a
n
There you go: https://github.com/apache/commons-text/pull/328 take a look
and feel free to merge it if it's looking OK, please
I tested first by making GH Actions to run just `mvn`, without changing the
pom.xml, and the build failed. Then reverted the change in pom.xml and
push-forced, and now the
Ah, good point. I saw builds in other projects failing, and the PR's being
closed due to the upgrade, but looks like Text's GH Actions set up needs to
be fixed too. The build for checkstyle passed (even though it appears to
include Java 8), maybe it's not calling checkstyle.
https://github.com/apa
On Sat, May 21, 2022 at 11:32 AM Eric Bresie wrote:
>
> So at what point do we consider updating to new required Java version?
Probably soon-ish maybe this year? Next year? Who knows ;-) Java 8 is
still under LTS support and is still widely used:
https://www.infoworld.com/article/3652408/java-8-s
So at what point do we consider updating to new required Java version?
From: Gary Gregory
Sent: Saturday, May 21, 2022 8:48 AM
To: Commons Developers List
Subject: Re: [commons-text] branch master updated: Bump checkstyle from 9.3 to
10.2
-1
Please stop updatin
I suggest the Pom is commented accordingly
On Sat, 21 May 2022 at 14:48, Gary Gregory wrote:
>
> -1
>
> Please stop updating checkstyle to 10.2 because it breaks the build as
> 10.2 requires Java 11.
>
> Gary
>
> On Fri, May 20, 2022 at 7:04 PM wrote:
> >
> > This is an automated email from the
-1
Please do not allow turn off this check. These checks are real
anti-patterns and have allowed me to fix call sites here IIRC and in
other components. If there are spot cases of legitimate code like
"throws new RuntimeException(...)", then the code should be documented
in-line and each call site
-1
Please stop updating checkstyle to 10.2 because it breaks the build as
10.2 requires Java 11.
Gary
On Fri, May 20, 2022 at 7:04 PM wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> kinow pushed a commit to branch master
> in repository https://gitbox.apache.o
