-1 Please do not allow turn off this check. These checks are real anti-patterns and have allowed me to fix call sites here IIRC and in other components. If there are spot cases of legitimate code like "throws new RuntimeException(...)", then the code should be documented in-line and each call site specifically excluded from SpotBugs. Otherwise, PRs and maintainers can add "throws new RuntimeException(..,)" all over the place without SpotBugs rasing this as an anti-pattern.
TY, Gary On Fri, May 20, 2022 at 6:51 PM <ki...@apache.org> wrote: > > This is an automated email from the ASF dual-hosted git repository. > > kinow pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-lang.git > > commit b9f3b72c15508057d93ad2ed9399a18400d1b2d0 > Author: Bruno P. Kinoshita <ki...@users.noreply.github.com> > AuthorDate: Sat May 21 10:44:37 2022 +1200 > > Add Spotbugs exclusions after dependabot update (no code modification) > --- > src/conf/spotbugs-exclude-filter.xml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/conf/spotbugs-exclude-filter.xml > b/src/conf/spotbugs-exclude-filter.xml > index 7cbba7a97..2d4cf12f3 100644 > --- a/src/conf/spotbugs-exclude-filter.xml > +++ b/src/conf/spotbugs-exclude-filter.xml > @@ -30,6 +30,9 @@ > <Bug pattern="EI_EXPOSE_REP" /> > <Bug pattern="EI_EXPOSE_REP2" /> > <Bug pattern="MS_EXPOSE_REP" /> > + <Bug pattern="THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION" /> > + <Bug pattern="THROWS_METHOD_THROWS_CLAUSE_THROWABLE" /> > + <Bug pattern="THROWS_METHOD_THROWS_RUNTIMEEXCEPTION" /> > </Or> > </Match> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
