Re: Re: [math] Discuss: New feature MiniBatchKMeansClusterer

2020-03-04 Thread chentao...@qq.com
Hi, >Hi. > >Le ven. 28 févr. 2020 à 05:04, chentao...@qq.com a écrit : >> >> >> >> >> -- >> chentao...@qq.com >> >Hi. >> > >> >Le jeu. 27 févr. 2020 à 06:17, chentao...@qq.com a >> >écrit : >> >> >> >> Hi, >> >> >> >> > [...] >> >> >> >> >> >> >> >> Do you mean I should fire a JIRA

Re: [lang] NPE vs IAE

2020-03-04 Thread Gilles Sadowski
Le mer. 4 mars 2020 à 15:16, Gilles Sadowski a écrit : > > Le mer. 4 mars 2020 à 15:09, Gary Gregory a écrit : > > > > IMO, until we are all on Java 14 and benefit from its more detailed NPE > > message, we need to call Validate.notNull _with a message_ that says what > > variable blew up. > > No

Re: [lang] NPE vs IAE

2020-03-04 Thread Gilles Sadowski
Le mer. 4 mars 2020 à 15:16, sebb a écrit : > > On Wed, 4 Mar 2020 at 14:09, Gary Gregory wrote: > > > > IMO, until we are all on Java 14 and benefit from its more detailed NPE > > message, we need to call Validate.notNull _with a message_ that says what > > variable blew up. > > +1 > > That is a

Re: [lang] NPE vs IAE

2020-03-04 Thread sebb
On Wed, 4 Mar 2020 at 14:09, Gary Gregory wrote: > > IMO, until we are all on Java 14 and benefit from its more detailed NPE > message, we need to call Validate.notNull _with a message_ that says what > variable blew up. +1 That is another good point. Unless one has access to the exact same ver

Re: [lang] NPE vs IAE

2020-03-04 Thread Gilles Sadowski
Le mer. 4 mars 2020 à 15:09, Gary Gregory a écrit : > > IMO, until we are all on Java 14 and benefit from its more detailed NPE > message, we need to call Validate.notNull _with a message_ that says what > variable blew up. No, we don't *need* to (for the reason stated previously), but you may *w

Re: [lang] NPE vs IAE

2020-03-04 Thread Gary Gregory
IMO, until we are all on Java 14 and benefit from its more detailed NPE message, we need to call Validate.notNull _with a message_ that says what variable blew up. Gary On Wed, Mar 4, 2020 at 9:01 AM Gilles Sadowski wrote: > Le mer. 4 mars 2020 à 14:19, Gary Gregory a > écrit : > > > > On Wed,

Re: [lang] NPE vs IAE

2020-03-04 Thread Gilles Sadowski
Le mer. 4 mars 2020 à 14:19, Gary Gregory a écrit : > > On Wed, Mar 4, 2020 at 7:58 AM sebb wrote: > > > On Sat, 29 Feb 2020 at 18:09, Gilles Sadowski > > wrote: > > > > > > Le sam. 29 févr. 2020 à 18:39, Gary Gregory a > > écrit : > > > > > > > > On Sat, Feb 22, 2020 at 5:25 PM Gary Gregory >

Re: [lang] NPE vs IAE

2020-03-04 Thread Gary Gregory
On Wed, Mar 4, 2020 at 7:58 AM sebb wrote: > On Sat, 29 Feb 2020 at 18:09, Gilles Sadowski > wrote: > > > > Le sam. 29 févr. 2020 à 18:39, Gary Gregory a > écrit : > > > > > > On Sat, Feb 22, 2020 at 5:25 PM Gary Gregory > wrote: > > > > > > > I would like to do the same in Lang as with Collec

Re: [lang] NPE vs IAE

2020-03-04 Thread sebb
On Sat, 29 Feb 2020 at 18:09, Gilles Sadowski wrote: > > Le sam. 29 févr. 2020 à 18:39, Gary Gregory a écrit : > > > > On Sat, Feb 22, 2020 at 5:25 PM Gary Gregory wrote: > > > > > I would like to do the same in Lang as with Collections (see below.)\ > > > > > > We currently perform checks like:

[collections] coveralls default branch is trunk not master

2020-03-04 Thread Alex Herbert
I have fixed coveralls submission for [collections]. So PRs should now report coverage status again. The last report submission was: Master: 05 Jul 2019 Trunk: 25 Jun 2017 However coveralls is tracking trunk as the default branch. This may not effect Github PR coverage reporting but it should