[GitHub] svenrathgeber commented on issue #29: GEOMETRY-32 adds BSPTree.isLeaf, applies method to node.getCut() == n…

2019-02-17 Thread GitBox
svenrathgeber commented on issue #29: GEOMETRY-32 adds BSPTree.isLeaf, applies method to node.getCut() == n… URL: https://github.com/apache/commons-geometry/pull/29#issuecomment-464588253 > Can you add a unit test for this? Seems reasonable to me. You are right. But I don't know enou

Re: [Rng] README.md and broken javadoc link

2019-02-17 Thread Gilles Sadowski
Hello. Le dim. 17 févr. 2019 à 23:57, Alex Herbert a écrit : > > Hi Gilles, > > This is related to the fix I made for MathJax. It apparently is not as simple > as I thought, i.e. this was a hidden tag only for JDK 8. This tag is not > officially documented so there is no official solution, only

Re: [Rng] README.md and broken javadoc link

2019-02-17 Thread Alex Herbert
Hi Gilles, This is related to the fix I made for MathJax. It apparently is not as simple as I thought, i.e. this was a hidden tag only for JDK 8. This tag is not officially documented so there is no official solution, only what you can find on the web. I had installed openJDK 9 on my linux mac

[GitHub] coveralls commented on issue #21: RNG-71: Validate parameters for the distribution samplers

2019-02-17 Thread GitBox
coveralls commented on issue #21: RNG-71: Validate parameters for the distribution samplers URL: https://github.com/apache/commons-rng/pull/21#issuecomment-464518014 [![Coverage Status](https://coveralls.io/builds/21696066/badge)](https://coveralls.io/builds/21696066) Coverage i

[GitHub] aherbert opened a new pull request #21: RNG-71: Validate parameters for the distribution samplers

2019-02-17 Thread GitBox
aherbert opened a new pull request #21: RNG-71: Validate parameters for the distribution samplers URL: https://github.com/apache/commons-rng/pull/21 This adds checks matching those found in the commons-math3 distributions to the samplers. An additional check missing in commons-math3 was

Re: [Rng] README.md and broken javadoc link

2019-02-17 Thread Gilles Sadowski
Hi Alex. I tried to regenerate the site but the build fails: ---CUT--- [INFO] Reactor Summary: [INFO] [INFO] Apache Commons RNG . SUCCESS [ 21.050 s] [INFO] Apache Commons RNG Client API .. FAILURE [ 7.723 s] [INFO] Apache Commons RNG Core .

Re: [LANG] Jenkins Pipeline DSL

2019-02-17 Thread Pascal Schumacher
+1 to using a pipeline Am 17.02.2019 um 18:35 schrieb Benedikt Ritter: Hi all, I feel like maintaining separate build descriptions on Jenkins is a PITA. Any objections against adopting Jenkins Pipeline DSL for Lang? Regards, Benedikt

Re: Jakarta EE TCKs and compatibility logo

2019-02-17 Thread Mark Thomas
Ping. Just a gentle reminder as I haven't seen any emails to jcp-open@ as yet. Mark PS If you don't want to build from source, there are nightly TCK builds available here: https://download.eclipse.org/ee4j/jakartaee-tck/8.0.1/nightly/ On 21/01/2019 10:46, Mark Thomas wrote: > Apologies for the

Re: [LANG] Jenkins Pipeline DSL

2019-02-17 Thread Benedikt Ritter
Am So., 17. Feb. 2019 um 19:48 Uhr schrieb Gary Gregory < garydgreg...@gmail.com>: > This will be versioned in the repo just like we do for Travis? > Yes. It's a description of a jenkins job in a groovy DSL, see https://jenkins.io/solutions/pipeline/ > > Gary > > On Sun, Feb 17, 2019, 12:36 Ben

Re: [LANG] Jenkins Pipeline DSL

2019-02-17 Thread Bruno P. Kinoshita
None from me. +1 Sent from Yahoo Mail on Android On Mon, 18 Feb 2019 at 6:36, Benedikt Ritter wrote: Hi all, I feel like maintaining separate build descriptions on Jenkins is a PITA. Any objections against adopting Jenkins Pipeline DSL for Lang? Regards, Benedikt

Re: [LANG] Jenkins Pipeline DSL

2019-02-17 Thread Gary Gregory
This will be versioned in the repo just like we do for Travis? Gary On Sun, Feb 17, 2019, 12:36 Benedikt Ritter Hi all, > > I feel like maintaining separate build descriptions on Jenkins is a PITA. > Any objections against adopting Jenkins Pipeline DSL for Lang? > > Regards, > Benedikt >

[LANG] Jenkins Pipeline DSL

2019-02-17 Thread Benedikt Ritter
Hi all, I feel like maintaining separate build descriptions on Jenkins is a PITA. Any objections against adopting Jenkins Pipeline DSL for Lang? Regards, Benedikt

Re: [Rng] README.md and broken javadoc link

2019-02-17 Thread Alex Herbert
> On 16 Feb 2019, at 21:31, Gilles Sadowski wrote: > > Hello. > > Le sam. 16 févr. 2019 à 13:12, Alex Herbert a > écrit : >> >> The link to the javadoc on the GitHub homepage is broken. I cannot find a >> link to the javadoc from the official commons RNG homepage. >> >> I have tried to up

[GitHub] asfgit merged pull request #30: GEOMETRY-28: Line API Updates

2019-02-17 Thread GitBox
asfgit merged pull request #30: GEOMETRY-28: Line API Updates URL: https://github.com/apache/commons-geometry/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] britter merged pull request #73: Fix broken build

2019-02-17 Thread GitBox
britter merged pull request #73: Fix broken build URL: https://github.com/apache/commons-io/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] kinow merged pull request #69: Fix site report issues

2019-02-17 Thread GitBox
kinow merged pull request #69: Fix site report issues URL: https://github.com/apache/commons-collections/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] kinow merged pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported

2019-02-17 Thread GitBox
kinow merged pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported URL: https://github.com/apache/commons-dbutils/pull/6 This is an automated message from the Apache Git Service. To re

[GitHub] kinow edited a comment on issue #54: Code cleanup

2019-02-17 Thread GitBox
kinow edited a comment on issue #54: Code cleanup URL: https://github.com/apache/commons-io/pull/54#issuecomment-464307076 Looks good to me! Much more readable! I only would need to consult the documentation (and perhaps other devs) regarding removing exception from public methods. I am no