aherbert opened a new pull request #21: RNG-71: Validate parameters for the distribution samplers URL: https://github.com/apache/commons-rng/pull/21 This adds checks matching those found in the commons-math3 distributions to the samplers. An additional check missing in commons-math3 was added to the `LogNormalSampler` to ensure the mean (scale) parameter was positive. I am unsure why this check is missing in CM as it is defined here [Log-normal_distribution](https://en.wikipedia.org/wiki/Log-normal_distribution). The existing validation checks in the PoissonSampler have had their exception messages changed for consistency across all the samplers. A test for the ContinuousUniformSampler was added to demonstrate no range checks are required.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
