Re: commons-dbcp patch

2017-04-30 Thread Matt Sicker
You can fork the repo and make a PR that way. The GitHub repos are read-only mirrors. On 30 April 2017 at 17:57, Gary Evesson wrote: > I have a potential bugfix/patch for DBCP but I cannot create a PR on the > GitHub site because I cannot push a branch. Any ideas on how I can get it > submitted

Re: commons-dbcp patch

2017-04-30 Thread Bernd Eckenfels
Hello, You need to clone the project to your own repos and there you can push the changes (to a branch) and then create a PR. Gruss Bernd -- http://bernd.eckenfels.net _ From: Gary Evesson mailto:geves...@atlassian.com>> Sent: Montag, Mai 1, 2017 12:57 AM Subject: com

Re: [Numbers] Java version?

2017-04-30 Thread Peter Ansell
Jenkins now requires Java-8 as its base runtime environment on the regular release channel, with its LTS channel moving to Java-8 in a few weeks: https://jenkins.io/blog/2017/04/10/jenkins-has-upgraded-to-java-8/ That one bit me, as there is a bug updating on older Ubuntu versions that don't carr

commons-dbcp patch

2017-04-30 Thread Gary Evesson
I have a potential bugfix/patch for DBCP but I cannot create a PR on the GitHub site because I cannot push a branch. Any ideas on how I can get it submitted? Gary Evesson

Re: StopWatch stop

2017-04-30 Thread Gary Gregory
Sorry, Commons Lang. Gary On Apr 30, 2017 1:47 PM, "Matt Sicker" wrote: > Which subproject are you speaking of anyways? > > On 30 April 2017 at 15:46, Gary Gregory wrote: > > > A new method perhaps or a new class a la fluent? > > > > Gary > > > > On Apr 30, 2017 1:32 PM, "Matt Sicker" wrote:

Re: StopWatch stop

2017-04-30 Thread Matt Sicker
Which subproject are you speaking of anyways? On 30 April 2017 at 15:46, Gary Gregory wrote: > A new method perhaps or a new class a la fluent? > > Gary > > On Apr 30, 2017 1:32 PM, "Matt Sicker" wrote: > > > Yup, here it is: > > 13.4.15. Method Result Type > > > > Changing the result type of a

Re: StopWatch stop

2017-04-30 Thread Gary Gregory
A new method perhaps or a new class a la fluent? Gary On Apr 30, 2017 1:32 PM, "Matt Sicker" wrote: > Yup, here it is: > 13.4.15. Method Result Type > > Changing the result type of a method, or replacing a result type with void, > or replacing void with a result type, has the combined effect of

Re: StopWatch stop

2017-04-30 Thread Matt Sicker
Yup, here it is: 13.4.15. Method Result Type Changing the result type of a method, or replacing a result type with void, or replacing void with a result type, has the combined effect of deleting the old method and adding a new method with the new result type or newly void result (see §13.4.12

Re: StopWatch stop

2017-04-30 Thread Matt Sicker
https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html A reference to a method must be resolved at compile time to a symbolic reference to the erasure (§4.6 ) of the qualifying type of the invocation, plus the erasure of

Re: StopWatch stop

2017-04-30 Thread Gary Gregory
On Apr 30, 2017 1:19 PM, "Oliver Heger" wrote: I think client code has to be recompiled, otherwise a NoSuchMethodError is thrown. Dang it. Are you sure? Gary Oliver Am 30.04.2017 um 21:24 schrieb Matt Sicker: > That sort of thing changes the binary signature, but source compatibility > is

Re: StopWatch stop

2017-04-30 Thread Oliver Heger
I think client code has to be recompiled, otherwise a NoSuchMethodError is thrown. Oliver Am 30.04.2017 um 21:24 schrieb Matt Sicker: > That sort of thing changes the binary signature, but source compatibility > is retained. > > On 30 April 2017 at 14:20, Gary Gregory wrote: > >> Hi, >> >> Wou

Re: StopWatch stop

2017-04-30 Thread Matt Sicker
That sort of thing changes the binary signature, but source compatibility is retained. On 30 April 2017 at 14:20, Gary Gregory wrote: > Hi, > > Would it break BC to change StopWatch.stop() to return "this"? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence

StopWatch stop

2017-04-30 Thread Gary Gregory
Hi, Would it break BC to change StopWatch.stop() to return "this"? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

Re: [Numbers] Java version?

2017-04-30 Thread Matt Sicker
Supporting Java 6 is going to continue to become harder and harder to do with infrastructural upgrades across the board. Recent versions of Gradle require Java 7 to run, for example, just like Jenkins, even though you can still use those to compile for Java 6. Ant has finally moved on from the Java

Re: [Numbers] Java version?

2017-04-30 Thread Gilles
On Sun, 30 Apr 2017 15:39:20 +0100, sebb wrote: On 30 April 2017 at 15:32, Gilles wrote: On Sun, 30 Apr 2017 14:49:56 +0100, sebb wrote: On 29 April 2017 at 19:10, Gilles wrote: Hi. On Sat, 29 Apr 2017 09:46:56 -0400, Raymond DeCampo wrote: Please note I wrote an issue concerning this

Re: [Numbers] Java version?

2017-04-30 Thread sebb
On 30 April 2017 at 15:32, Gilles wrote: > On Sun, 30 Apr 2017 14:49:56 +0100, sebb wrote: >> >> On 29 April 2017 at 19:10, Gilles wrote: >>> >>> Hi. >>> >>> On Sat, 29 Apr 2017 09:46:56 -0400, Raymond DeCampo wrote: Please note I wrote an issue concerning this last week or so. >>>

Re: [Numbers] Java version?

2017-04-30 Thread Gilles
On Sun, 30 Apr 2017 14:49:56 +0100, sebb wrote: On 29 April 2017 at 19:10, Gilles wrote: Hi. On Sat, 29 Apr 2017 09:46:56 -0400, Raymond DeCampo wrote: Please note I wrote an issue concerning this last week or so. https://issues.apache.org/jira/browse/NUMBERS-21 I noticed when moving code

Re: [Numbers] Java version?

2017-04-30 Thread sebb
On 29 April 2017 at 19:10, Gilles wrote: > Hi. > > On Sat, 29 Apr 2017 09:46:56 -0400, Raymond DeCampo wrote: >> >> Please note I wrote an issue concerning this last week or so. >> >> https://issues.apache.org/jira/browse/NUMBERS-21 >> >> I noticed when moving code from [math] to [numbers] that [m