Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Emmanuel Bourg
Le 28/09/2014 02:36, sebb a écrit : > -1 hashes are missing from the directory The directory contains the PGP signatures, that's even better. > Link to KEYS file is needed in the vote e-mail thread As usual that's the KEYS file of the Apache Commons project, no need to repeat it in every vote f

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread sebb
On 27 September 2014 08:50, Emmanuel Bourg wrote: > Hi all, > > The third release candidate of BCEL is ready to pass under your scrutiny. > > Tag: > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/ > (r1627908) > > Release notes: > http://people.apache.org/~ebourg/bcel/RELEAS

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-27 Thread sebb
On 28 September 2014 01:22, sebb wrote: > On 26 September 2014 22:12, Emmanuel Bourg wrote: >> Hi all, >> >> The second release candidate of BCEL is ready to pass under your scrutiny. >> >> Tag: >> http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/ >> (r1627879) >> >> Release

Re: [VOTE] Release BCEL 6.0 based on RC2

2014-09-27 Thread sebb
On 26 September 2014 22:12, Emmanuel Bourg wrote: > Hi all, > > The second release candidate of BCEL is ready to pass under your scrutiny. > > Tag: > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC2/ > (r1627879) > > Release notes: > http://people.apache.org/~ebourg/bcel/RELEA

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Konstantin Kolinko
2014-09-27 11:50 GMT+04:00 Emmanuel Bourg : > Hi all, > > The third release candidate of BCEL is ready to pass under your scrutiny. > > Tag: > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/ > (r1627908) > > Release notes: > http://people.apache.org/~ebourg/bcel/RELEASE-NOTES

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Gary Gregory
Since IANAL, I'll abstain from opining, I think asking @legal would be the safest bet; OTOH, rolling another RC keeps @legal out of the loop and is simple. I realize that rolling RC after RC is a pain and that our release process is not friction free, but it's what we've got for now. Gary On Sat

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Oliver Heger
Hi Gary, can you confirm that a wrong copyright date is not a blocker for a release? If so, I vote +1. Oliver Am 27.09.2014 um 21:27 schrieb Gary Gregory: > I fixed the notice file in svn. > > Gary > > Original message From: Oliver Heger > Date:09/27/2014 09:48 (GMT-05:00)

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Gary Gregory
I fixed the notice file in svn. Gary Original message From: Oliver Heger Date:09/27/2014 09:48 (GMT-05:00) To: Commons Developers List Subject: Re: [VOTE] Release BCEL 6.0 based on RC3 -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Build works fine with Java 1.5 and 1.7 o

Re: [pool] time to cut 2.3

2014-09-27 Thread Phil Steitz
On 9/27/14 10:16 AM, Jacopo Cappellato wrote: > On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote: > >> It is not enough to set them volatile because the class has some invariants >> that include more than one field. > For example, under unlucky thread concurrency the method getIdleTimeMillis() >

Re: svn commit: r1627984 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java

2014-09-27 Thread Matt Benson
:-) On Sep 27, 2014 12:33 PM, wrote: > Author: djones > Date: Sat Sep 27 17:33:00 2014 > New Revision: 1627984 > > URL: http://svn.apache.org/r1627984 > Log: > Removed redundant static modifier (thanks, Matt). > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time

Re: [pool] time to cut 2.3

2014-09-27 Thread Jacopo Cappellato
On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote: > It is not enough to set them volatile because the class has some invariants > that include more than one field. For example, under unlucky thread concurrency the method getIdleTimeMillis() could return a negative value. Jacopo ---

Re: [pool] time to cut 2.3

2014-09-27 Thread Phil Steitz
On 9/27/14 6:04 AM, Gary Gregory wrote: > In org.apache.commons.pool2.impl.DefaultPooledObject.getActiveTimeMillis(), > I see: > > // Take copies to avoid threading issues > long rTime = lastReturnTime; > long bTime = lastBorrowTime; > > But isn't is the case that the object

Re: svn commit: r1627974 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java

2014-09-27 Thread Matt Benson
Note that enums are always static and that this keyword is redundant when used in their declaration. Matt On Sep 27, 2014 10:03 AM, wrote: > Author: djones > Date: Sat Sep 27 15:03:26 2014 > New Revision: 1627974 > > URL: http://svn.apache.org/r1627974 > Log: > Replaced private integer constants

Re: [pool] time to cut 2.3

2014-09-27 Thread Jacopo Cappellato
yes, sure. Should I create a new ticket? Jacopo On Sep 27, 2014, at 6:46 PM, Gary Gregory wrote: > Hi and thanks for chiming in. > > The best path is to use Jira so we can all look and discuss. > > Gary > > Original message > From: Jacopo Cappellato > Date:09/27/2014 12:36

Re: [pool] time to cut 2.3

2014-09-27 Thread Gary Gregory
Hi and thanks for chiming in. The best path is to use Jira so we can all look and discuss.  Gary Original message From: Jacopo Cappellato Date:09/27/2014 12:36 (GMT-05:00) To: Commons Developers List Subject: Re: [pool] time to cut 2.3 Hi Gary, all, I am sorry if I jump in in

Re: [pool] time to cut 2.3

2014-09-27 Thread Jacopo Cappellato
Hi Gary, all, I am sorry if I jump in in this conversation: I am a committer of another ASF project (I am actually the PMC chairman for Apache OFBiz) and my project is using dbcp2/pool2, so thank you for all the work you did and are doing. I am reviewing the code in DefaultPooledObject and Gary

Re: [VOTE] Release Apache Commons Daemon 1.0.15 windows binary package with signed executables

2014-09-27 Thread Gary Gregory
On Sat, Sep 27, 2014 at 11:27 AM, Stefan Bodewig wrote: > On 2014-09-27, Gary Gregory wrote: > > > What is the status of this VOTE? > > > http://mail-archives.apache.org/mod_mbox/commons-dev/201409.mbox/%3C541FF178.1030204%40apache.org%3E > Thanks! Gary > > Stefan > > -

Re: [compress] Closing in on 1.9 Release

2014-09-27 Thread Gary Gregory
I do understand that! As long as it is on your radar with a landing site in mind, we are good ;-) Gary On Sat, Sep 27, 2014 at 11:24 AM, Stefan Bodewig wrote: > On 2014-09-27, Gary Gregory wrote: > > > Still closing in on 1.9 ;-) > > > Stefan, are you ready to cut a released? > > Distracted by

Re: [VOTE] Release Apache Commons Daemon 1.0.15 windows binary package with signed executables

2014-09-27 Thread Stefan Bodewig
On 2014-09-27, Gary Gregory wrote: > What is the status of this VOTE? http://mail-archives.apache.org/mod_mbox/commons-dev/201409.mbox/%3C541FF178.1030204%40apache.org%3E Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons

Re: [compress] Closing in on 1.9 Release

2014-09-27 Thread Stefan Bodewig
On 2014-09-27, Gary Gregory wrote: > Still closing in on 1.9 ;-) > Stefan, are you ready to cut a released? Distracted by real life, might get around to it tomorrow, but it is quite possible I'll have to push it off to the next weekend. Stefan --

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Emmanuel Bourg
Le 27/09/2014 15:48, Oliver Heger a écrit : > - The distribution files of other Commons components start with the > commons- prefix. This is not the case here. Because BCEL wasn't a Commons project and still distributed under it's own org.apache.bcel groupId > I am not sure how problematic the

Re: [VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Oliver Heger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Build works fine with Java 1.5 and 1.7 on Windows 8.1. Artifacts look good. The site shows that the code base probably needs some work to improve quality, but this does not block the release. Nits: - - The NOTICE file states the wrong copyright year.

Re: [compress] Closing in on 1.9 Release

2014-09-27 Thread Gary Gregory
Still closing in on 1.9 ;-) Stefan, are you ready to cut a released? Gary On Sun, Aug 31, 2014 at 9:04 PM, sebb wrote: > On 31 August 2014 20:28, Stefan Bodewig wrote: > > Hi all > > > > it's only four issues we've closed since the 1.8.1 release but I > > consider COMPRESS-286 pretty serious

Re: [pool] time to cut 2.3

2014-09-27 Thread Gary Gregory
In org.apache.commons.pool2.impl.DefaultPooledObject.getActiveTimeMillis(), I see: // Take copies to avoid threading issues long rTime = lastReturnTime; long bTime = lastBorrowTime; But isn't is the case that the object could be returned and borrowed again between the two

Re: [VOTE] Release Apache Commons Daemon 1.0.15 windows binary package with signed executables

2014-09-27 Thread Gary Gregory
What is the status of this VOTE? Gary On Sun, Sep 21, 2014 at 2:50 PM, Mark Thomas wrote: > On 21/09/2014 03:31, Gary Gregory wrote: > > How should reviewers test this RC? > > That is up to the reviewer. My suggestion would be: > > The same way they tested the unsigned released when that was ma

[VOTE] Release BCEL 6.0 based on RC3

2014-09-27 Thread Emmanuel Bourg
Hi all, The third release candidate of BCEL is ready to pass under your scrutiny. Tag: http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC3/ (r1627908) Release notes: http://people.apache.org/~ebourg/bcel/RELEASE-NOTES.txt Distribution files: http://people.apache.org/~ebourg/bc