Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > How about using the current version of FB, 2.5.3? OK, I upgradede findbugs, removed the methods from JarArchiveEntry and commented the new warnings findbugs emits now (default encoding in places where we explicitly want to use it).

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > I've made some adjustments to this file in SVN. My intention was to not > change the bit twiddling expressions, my mistake. Now we have: > value |= nextByte << (8 * i); Thanks Stefan --

[VOTE] Release Commons Codec 1.9-RC1

2013-12-20 Thread Gary Gregory
Hello All: This is a VOTE to release Commons Codec 1.9-RC1 Feature and fix release. Requires a minimum of Java 1.6. Changes in this version include: Performance: CODEC-174: Improve performance of Beider Morse encoder. Thanks to Thomas Champagne. Fixed Bugs: o CODEC-175: Beider Morse does not c

Re: [math] Include test data from netlib

2013-12-20 Thread Ted Dunning
>From the FAQ: > *2.1) What is Netlib? *The Netlib repository contains freely available > software, documents, and databases of interest to the numerical, scientific > computing, and other communities. The repository is maintained by AT&T Bell > Laboratories, the University of Tennessee and Oak

[math] Include test data from netlib

2013-12-20 Thread Thomas Neidhart
Hi, I have a question regarding test data available at http://www.netlib.org/lp/data/. Could this be included in our subversion repository? I could not find a license attached to these files, but it looks like they have been contributed to netlib from various sources. It would be quite valuable

Re: [compress] cutting 1.7?

2013-12-20 Thread sebb
On 20 December 2013 17:57, Stefan Bodewig wrote: > On 2013-12-20, sebb wrote: > >> On 20 December 2013 17:38, Stefan Bodewig wrote: >>> On 2013-12-20, sebb wrote: > On 20 December 2013 17:07, Stefan Bodewig wrote: > On 2013-12-20, Gary Gregory wrote: > >> We get PMD warnings in

Re: [compress] cutting 1.7?

2013-12-20 Thread Gary Gregory
On Fri, Dec 20, 2013 at 12:57 PM, Stefan Bodewig wrote: > On 2013-12-20, sebb wrote: > > > On 20 December 2013 17:38, Stefan Bodewig wrote: > >> On 2013-12-20, sebb wrote: > > >>> On 20 December 2013 17:07, Stefan Bodewig wrote: > On 2013-12-20, Gary Gregory wrote: > > > We get PMD war

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Gary Gregory
On Fri, Dec 20, 2013 at 12:42 PM, Stefan Bodewig wrote: > On 2013-12-20, Gary Gregory wrote: > > > On Fri, Dec 20, 2013 at 12:21 PM, Emmanuel Bourg > wrote: > > >> Le 20/12/2013 18:18, ggreg...@apache.org a écrit : > > >>> Remove some unnecessary parentheses. > > >> I'd argue they make the code

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, sebb wrote: > On 20 December 2013 17:38, Stefan Bodewig wrote: >> On 2013-12-20, sebb wrote: >>> On 20 December 2013 17:07, Stefan Bodewig wrote: On 2013-12-20, Gary Gregory wrote: > We get PMD warnings in > org.apache.commons.compress.archivers.jar.JarArchiveEntry

Re: [compress] cutting 1.7?

2013-12-20 Thread sebb
On 20 December 2013 17:38, Stefan Bodewig wrote: > On 2013-12-20, sebb wrote: > >> On 20 December 2013 17:07, Stefan Bodewig wrote: >>> On 2013-12-20, Gary Gregory wrote: > We get PMD warnings in org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods only calling s

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > On Fri, Dec 20, 2013 at 12:21 PM, Emmanuel Bourg wrote: >> Le 20/12/2013 18:18, ggreg...@apache.org a écrit : >>> Remove some unnecessary parentheses. >> I'd argue they make the code easier to read. Reading bit shifting code >> is quite painful, some parent

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, sebb wrote: > On 20 December 2013 17:07, Stefan Bodewig wrote: >> On 2013-12-20, Gary Gregory wrote: >>> We get PMD warnings in >>> org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods >>> only calling super. >>> Either document that the methods are placeholder

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Emmanuel Bourg wrote: > Le 20/12/2013 18:18, ggreg...@apache.org a écrit : >> Remove some unnecessary parentheses. > I'd argue they make the code easier to read. Reading bit shifting code > is quite painful, some parentheses help greatly. +1 Stefan -

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread sebb
On 20 December 2013 17:21, Emmanuel Bourg wrote: > Le 20/12/2013 18:18, ggreg...@apache.org a écrit : > >> Remove some unnecessary parentheses. > > I'd argue they make the code easier to read. Reading bit shifting code > is quite painful, some parentheses help greatly. In this case, the parenthes

Re: [compress] cutting 1.7?

2013-12-20 Thread sebb
On 20 December 2013 17:07, Stefan Bodewig wrote: > On 2013-12-20, Gary Gregory wrote: > >> We get PMD warnings in >> org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods >> only calling super. > >> Either document that the methods are placeholders for future >> implementations (

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Gary Gregory
On Fri, Dec 20, 2013 at 12:21 PM, Emmanuel Bourg wrote: > Le 20/12/2013 18:18, ggreg...@apache.org a écrit : > > > Remove some unnecessary parentheses. > > I'd argue they make the code easier to read. Reading bit shifting code > is quite painful, some parentheses help greatly. > That's why it's

Re: [compress] Marking a public Class non-Public

2013-12-20 Thread Gary Gregory
I like the .internal. package convention (at least how Eclipse does it) but this will not stop someone from using methods in the class through inheritance but it makes it obvious if a class with a .internal. shows up in an import statement. Using "Private" or "Internal" or "Impl" in the class name

Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java

2013-12-20 Thread Emmanuel Bourg
Le 20/12/2013 18:18, ggreg...@apache.org a écrit : > Remove some unnecessary parentheses. I'd argue they make the code easier to read. Reading bit shifting code is quite painful, some parentheses help greatly. Emmanuel - To un

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, sebb wrote: > On 20 December 2013 16:46, Gary Gregory wrote: >> Either the source level must be set to 1.6 or the @Overrides must be >> removed from org.apache.commons.compress.compressors.snappy.PureJavaCrc32C. > I suspect these were accidentally added. The code is copied from

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > CPD shows some complex code duplication, is it possible to refactor? It has been doing so ever since we added CPD reports. The code is part of a loop (you'll note the braces are not ballanced, there is one more closing than opening brace) that contains and mu

Re: [compress] Marking a public Class non-Public

2013-12-20 Thread sebb
On 20 December 2013 16:53, Stefan Bodewig wrote: > Hi > > in compress' trunk we now have to different stream classes that use > variants of LZW - the UNSHRINKING support in the zip package and the > ZCompresorInputStream. > > They looked so similar (and CPD was rightfully moaning about code > dupl

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > We get PMD warnings in > org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods > only calling super. > Either document that the methods are placeholders for future > implementations (TODO) or remove the methods. Actually it is neither. If y

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
On 2013-12-20, Gary Gregory wrote: > Either the source level must be set to 1.6 or the @Overrides must be > removed from org.apache.commons.compress.compressors.snappy.PureJavaCrc32C. > I'm fine with making the min JRE 1.6. Removing the @Overrides was quicker and less controversial :-) A pity C

Re: [compress] cutting 1.7?

2013-12-20 Thread sebb
On 20 December 2013 16:46, Gary Gregory wrote: > Thank you for the heads up. > > Either the source level must be set to 1.6 or the @Overrides must be > removed from org.apache.commons.compress.compressors.snappy.PureJavaCrc32C. > > I'm fine with making the min JRE 1.6. Unless it really needs 1.6

[compress] Marking a public Class non-Public

2013-12-20 Thread Stefan Bodewig
Hi in compress' trunk we now have to different stream classes that use variants of LZW - the UNSHRINKING support in the zip package and the ZCompresorInputStream. They looked so similar (and CPD was rightfully moaning about code duplication) that I decided to extract the common code into

Re: [compress] cutting 1.7?

2013-12-20 Thread Gary Gregory
CPD shows some complex code duplication, is it possible to refactor? Gary On Fri, Dec 20, 2013 at 10:21 AM, Stefan Bodewig wrote: > OK, this time I'm really trying to get feedback before I spend two hours > on a throw-away RC build :-) > > contains t

Re: [compress] cutting 1.7?

2013-12-20 Thread Gary Gregory
We get PMD warnings in org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods only calling super. Either document that the methods are placeholders for future implementations (TODO) or remove the methods. Gary On Fri, Dec 20, 2013 at 10:21 AM, Stefan Bodewig wrote: > OK, this

Re: [compress] cutting 1.7?

2013-12-20 Thread Gary Gregory
Thank you for the heads up. Either the source level must be set to 1.6 or the @Overrides must be removed from org.apache.commons.compress.compressors.snappy.PureJavaCrc32C. I'm fine with making the min JRE 1.6. Gary On Fri, Dec 20, 2013 at 10:21 AM, Stefan Bodewig wrote: > OK, this time I'm

Re: [compress] cutting 1.7?

2013-12-20 Thread Stefan Bodewig
OK, this time I'm really trying to get feedback before I spend two hours on a throw-away RC build :-) contains the site generated from current trunk. When building the real release I'll be using Java6 so Clirr won't talk about AutoCloseable. And I'll c

[LANG] Preparing RC1 for release 3.2

2013-12-20 Thread Benedikt Ritter
Hi guys, I'm currently cleaning up trunk and I'm planning to cut my first release before christmas. If there's anything you'd like to have included in the next release, please add it now ;-) Regards, Benedikt -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.

Re: [MATH] Eigen decomposition of matrices consisting of RealFieldElements

2013-12-20 Thread Martin Grotle Soukup
Hi, 2013/12/20 Luc Maisonobe > Hi all, > > Le 19/12/2013 20:52, Ted Dunning a écrit : > > I had the same question. > > > > Presumably, it is a reasonable thing to have in the corner case of > needing > > eigenvalues for matrices with extended precision decimal numbers or some > > such, but I wou

Re: [MATH] Eigen decomposition of matrices consisting of RealFieldElements

2013-12-20 Thread Luc Maisonobe
Hi all, Le 19/12/2013 20:52, Ted Dunning a écrit : > I had the same question. > > Presumably, it is a reasonable thing to have in the corner case of needing > eigenvalues for matrices with extended precision decimal numbers or some > such, but I would be very surprised if there measurably non-zer