Re: [VOTE] Release Commons Parent 29 from RC2

2013-05-13 Thread Thomas Neidhart
On 05/14/2013 07:48 AM, Gary Gregory wrote: > Can someone (Luc) try this CP version or trunk with commons [IO]. I was > able to run 'mvn clean site' with M3.0.5 and Java 7 on Win7 but it almost > took an hour! As opposed to a couple of minutes with CP 28. > > I am hoping that this is a weird thing

Re: [VOTE] Release Commons Parent 29 from RC2

2013-05-13 Thread Gary Gregory
Can someone (Luc) try this CP version or trunk with commons [IO]. I was able to run 'mvn clean site' with M3.0.5 and Java 7 on Win7 but it almost took an hour! As opposed to a couple of minutes with CP 28. I am hoping that this is a weird thing with my star alignment because the whole point of JaC

Re: svn commit: r1481509 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz: BoundedRandomAccessFileInputStream.java Coders.java SevenZFile.java

2013-05-13 Thread Damjan Jovanovic
On Mon, May 13, 2013 at 7:14 PM, sebb wrote: > On 12 May 2013 11:12, wrote: >> Author: damjan >> Date: Sun May 12 10:12:16 2013 >> New Revision: 1481509 >> >> URL: http://svn.apache.org/r1481509 >> Log: >> Add support for BZIP2 decompression and AES-256 + SHA-256 decryption >> to the 7z archive

[COMPRESS] SevenZFile - fix debug so boxing is eliminated?

2013-05-13 Thread sebb
The private debug method requires an array of Objects to be passed to System.out.format. Any primitive parameters will be autoboxed. However, the boxing will be performed regardless of whether DEBUG is true or not. This is a bit wasteful as DEBUG is false by default. It may be better to inline t

Re: [DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread William Speirs
Happy to change it back... I'll have another look tomorrow AM after some coffee :-) Bill- On Mon, May 13, 2013 at 7:49 PM, Emmanuel Bourg wrote: > Le 14/05/2013 01:21, sebb a écrit : > > > Not sure I follow - it was William Spiers who changed the class to > generic. > > I suggested this chang

Re: [DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread Emmanuel Bourg
Le 14/05/2013 01:21, sebb a écrit : > Not sure I follow - it was William Spiers who changed the class to generic. I suggested this change last month when Bill asked for feedbacks. Emmanuel Bourg signature.asc Description: OpenPGP digital signature

Re: [DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread sebb
On 13 May 2013 22:50, Emmanuel Bourg wrote: > Le 13/05/2013 23:44, sebb a écrit : > >> I therefore wonder why ArrayHandler should be generic in the first place? > > You are right, my suggestion wasn't a good one. Not sure I follow - it was William Spiers who changed the class to generic. I've ju

Re: [collections] Fix Bag interface

2013-05-13 Thread Thomas Neidhart
On 05/13/2013 09:19 PM, sebb wrote: > On 13 May 2013 19:06, Thomas Neidhart wrote: >> Hi, >> >> currently, the Bag interface states that it violates the Collection >> contract. This is mainly because the interface was defined like that, >> but could be easily changed. >> >> As we are not binary co

Re: [DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread Emmanuel Bourg
Le 13/05/2013 23:44, sebb a écrit : > I therefore wonder why ArrayHandler should be generic in the first place? You are right, my suggestion wasn't a good one. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@commons.a

Re: [DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread sebb
On 13 May 2013 22:16, sebb wrote: > On 10 May 2013 21:23, William Speirs wrote: >> Consider this a pre release candidate for DBUTILS-2.0. I fixed the >> following things from RC1: >> >> - Removed @author tags >> - Changed QueryRunner to be public >> - Made ArrayHandler generic (but it's ugly beca

[DBUTILS] Generic ArrayHandler (was: Pre RC for DBUTILS-2.0)

2013-05-13 Thread sebb
On 10 May 2013 21:23, William Speirs wrote: > Consider this a pre release candidate for DBUTILS-2.0. I fixed the > following things from RC1: > > - Removed @author tags > - Changed QueryRunner to be public > - Made ArrayHandler generic (but it's ugly because I just cast to T[], does > anyone have

Re: [DBUTILS] Pre RC for DBUTILS-2.0

2013-05-13 Thread sebb
On 13 May 2013 21:30, Emmanuel Bourg wrote: > Le 13/05/2013 21:24, William Speirs a écrit : >> >> Yes, I did mean QueryExecutor... sorry. I make my methods protected rather >> than private because I'm not sure how someone (maybe myself) will need to >> change functionality in the future. If I make

Re: [DBUTILS] Pre RC for DBUTILS-2.0

2013-05-13 Thread Emmanuel Bourg
Le 13/05/2013 21:24, William Speirs a écrit : > > Yes, I did mean QueryExecutor... sorry. I make my methods protected rather > than private because I'm not sure how someone (maybe myself) will need to > change functionality in the future. If I make them private, then there's > not going back. If I

Re: [DBUTILS] Pre RC for DBUTILS-2.0

2013-05-13 Thread William Speirs
> You mean QueryExecutor, right? Now it's in line with UpdateExecutor and > InsertExecutor, but I feel a bit uncomfortable with theses classes as > they mostly expose protected methods and don't look like they are meant > to be extended. > Yes, I did mean QueryExecutor... sorry. I make my methods

Re: svn commit: r1481983 - /commons/proper/compress/trunk/pom.xml

2013-05-13 Thread sebb
On 13 May 2013 20:14, Benedikt Ritter wrote: > Hi Sebb, > > > 2013/5/13 > >> Author: sebb >> Date: Mon May 13 17:45:10 2013 >> New Revision: 1481983 >> >> URL: http://svn.apache.org/r1481983 >> Log: >> Latest version of JUnit >> >> Modified: >> commons/proper/compress/trunk/pom.xml >> >> Modi

Re: [collections] Fix Bag interface

2013-05-13 Thread sebb
On 13 May 2013 19:06, Thomas Neidhart wrote: > Hi, > > currently, the Bag interface states that it violates the Collection > contract. This is mainly because the interface was defined like that, > but could be easily changed. > > As we are not binary compatible anymore with previous releases, it w

Re: svn commit: r1481983 - /commons/proper/compress/trunk/pom.xml

2013-05-13 Thread Benedikt Ritter
Hi Sebb, 2013/5/13 > Author: sebb > Date: Mon May 13 17:45:10 2013 > New Revision: 1481983 > > URL: http://svn.apache.org/r1481983 > Log: > Latest version of JUnit > > Modified: > commons/proper/compress/trunk/pom.xml > > Modified: commons/proper/compress/trunk/pom.xml > URL: > http://svn.a

[collections] Fix Bag interface

2013-05-13 Thread Thomas Neidhart
Hi, currently, the Bag interface states that it violates the Collection contract. This is mainly because the interface was defined like that, but could be easily changed. As we are not binary compatible anymore with previous releases, it would be the right time to do this now (or leave it as it i

Re: svn commit: r1481509 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/sevenz: BoundedRandomAccessFileInputStream.java Coders.java SevenZFile.java

2013-05-13 Thread sebb
On 12 May 2013 11:12, wrote: > Author: damjan > Date: Sun May 12 10:12:16 2013 > New Revision: 1481509 > > URL: http://svn.apache.org/r1481509 > Log: > Add support for BZIP2 decompression and AES-256 + SHA-256 decryption > to the 7z archive format. > -0 Please ensure code will compile with the

Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java

2013-05-13 Thread sebb
On 13 May 2013 15:11, Emmanuel Bourg wrote: > Le 13/05/2013 15:49, Benedikt Ritter a écrit : >> Hi Emmanuel, >> >> do you have format lines on save activated? It is harder to see the actual >> changes if they are mixed up with code formatting. > > Hi Benedikt, > > My IDE is not to blame, I did ref

[compress] LZMA (was Re: 7zip)

2013-05-13 Thread Stefan Bodewig
On 2013-05-12, Damjan Jovanovic wrote: > On Sun, May 12, 2013 at 4:27 PM, Damjan Jovanovic > wrote: >> On Sun, May 12, 2013 at 12:34 PM, Stefan Bodewig wrote: >>> As for LZMA compression, the required code in XZ for Java's lzma >>> subpackage doesn't lend itself to streaming support but it may

Re: [compress] 7zip

2013-05-13 Thread Stefan Bodewig
On 2013-05-12, Damjan Jovanovic wrote: > On Sun, May 12, 2013 at 12:34 PM, Stefan Bodewig wrote: >> I'm off to read the format spec so I can have a more detailed look. > The 7zFormat.txt in 7z920.tar.bz2 is more up-to-date than the one in > lzma920.tar.bz2, but neither is decipherable without r

[VOTE] Release Commons Parent 29 from RC2

2013-05-13 Thread Luc Maisonobe
This is a VOTE to release Commons Parent 29 from RC2 Changes in this version include: Changes: o cobertura-maven-plugin 2.5.2 -> removed jacoco-maven-plugin -> 0.6.2.201302030002 maven-surefire-plugin 2.13 -> 2.14.1 maven-su

[CANCEL] Re: [VOTE] Release Commons Parent 29 from RC1

2013-05-13 Thread Luc Maisonobe
Le 13/05/2013 09:51, Luc Maisonobe a écrit : > This is a VOTE to release Commons Parent 29 from RC1 This vote is cancelled in order to update one more plugin (maven-site-plugin). Luc > > Changes in this version include: > > Changes: > o cobertura-maven-plugin 2.5.2 -> removed >

Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java

2013-05-13 Thread Emmanuel Bourg
Le 13/05/2013 15:49, Benedikt Ritter a écrit : > Hi Emmanuel, > > do you have format lines on save activated? It is harder to see the actual > changes if they are mixed up with code formatting. Hi Benedikt, My IDE is not to blame, I did reformat a few lines in the process. Emmanuel Bourg

Re: [all] strange maven magic

2013-05-13 Thread Luc Maisonobe
Le 13/05/2013 15:47, Jörg Schaible a écrit : > Hi Luc, Hi Jörg, > > Luc Maisonobe wrote: > >> Hi all, >> >> In the last few days, I looked into the commons parent pom as well as >> several other poms to set up JaCoCo reports. There is something I don't >> understand: with our current setting at

Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java

2013-05-13 Thread Benedikt Ritter
Hi Emmanuel, do you have format lines on save activated? It is harder to see the actual changes if they are mixed up with code formatting. Benedikt 2013/5/13 > Author: ebourg > Date: Mon May 13 09:17:44 2013 > New Revision: 1481744 > > URL: http://svn.apache.org/r1481744 > Log: > Removed an u

Re: svn commit: r1481714 - in /commons/proper/commons-parent/trunk: RELEASE-NOTES.txt pom.xml

2013-05-13 Thread Gary Gregory
I think the site 3.3 plugin has just been released. Gary On May 13, 2013, at 3:17, "l...@apache.org" wrote: > Author: luc > Date: Mon May 13 07:17:06 2013 > New Revision: 1481714 > > URL: http://svn.apache.org/r1481714 > Log: > updated some plugins > > Modified: >commons/proper/commons-pare

Re: [all] strange maven magic

2013-05-13 Thread Jörg Schaible
Hi Luc, Luc Maisonobe wrote: > Hi all, > > In the last few days, I looked into the commons parent pom as well as > several other poms to set up JaCoCo reports. There is something I don't > understand: with our current setting at Apache, when we run "mvn clean > site", the tests are automatically

Re: [all] strange maven magic

2013-05-13 Thread Luc Maisonobe
Hi Vishwa, Le 13/05/2013 14:51, Vishwanath Krishnamurthi a écrit : > New to the list, so first a "hello" to all :) Welcome! > > @Luc > Guess the default is just to run the tests. > The project you were saying about where tests do not run by default - > probably has a property in the pom to skip

Re: [all] strange maven magic

2013-05-13 Thread Vishwanath Krishnamurthi
New to the list, so first a "hello" to all :) @Luc Guess the default is just to run the tests. The project you were saying about where tests do not run by default - probably has a property in the pom to skip tests. -Vishwa On Mon, May 13, 2013 at 5:26 PM, Luc Maisonobe wrote: > Hi all, > > In

[all] strange maven magic

2013-05-13 Thread Luc Maisonobe
Hi all, In the last few days, I looked into the commons parent pom as well as several other poms to set up JaCoCo reports. There is something I don't understand: with our current setting at Apache, when we run "mvn clean site", the tests are automatically run. In another non-Apache project, when I

Re: [DBUTILS] Pre RC for DBUTILS-2.0

2013-05-13 Thread Emmanuel Bourg
Hi Bill, Le 10/05/2013 22:23, William Speirs a écrit : > - Changed QueryRunner to be public You mean QueryExecutor, right? Now it's in line with UpdateExecutor and InsertExecutor, but I feel a bit uncomfortable with theses classes as they mostly expose protected methods and don't look like they

[VOTE] Release Commons Parent 29 from RC1

2013-05-13 Thread Luc Maisonobe
This is a VOTE to release Commons Parent 29 from RC1 Changes in this version include: Changes: o cobertura-maven-plugin 2.5.2 -> removed jacoco-maven-plugin -> 0.6.2.201302030002 maven-surefire-plugin 2.13 -> 2.14.1 maven-su