I agree with sebb. Imports should only be added if they are needed in the code.
Send from my mobile device
Am 18.03.2013 um 23:28 schrieb sebb :
> It's still misleading to have the import listed, as it's useful to be
> able to do a text search to find where a specific class is used.
> Obviously
On 03/18/2013 10:00 PM, sebb wrote:
On 18 March 2013 13:14, Mladen Turk wrote:
With 3 binding +1 votes (Luc, Gary and Mladen) and no
other votes I declare this vote as passed.
I'll copy the artefacts and create ANN message after mirrors pick up
the release (within 24 hrs).
Please also add th
It's still misleading to have the import listed, as it's useful to be
able to do a text search to find where a specific class is used.
Obviously this does not show java.lang usages or references to classes
in the same package, but it's still useful (and quick).
On 18 March 2013 21:51, Gary Gregory
Hm... I consider this a bug in checkstyle or whatever does the
complaining...
Gary
On Mon, Mar 18, 2013 at 5:30 PM, sebb wrote:
> On 18 March 2013 18:45, wrote:
> > Author: ggregory
> > Date: Mon Mar 18 18:45:56 2013
> > New Revision: 1457915
> >
> > URL: http://svn.apache.org/r1457915
> > L
I appreciate your intention :) I feel this could lead to bike-shedding on
the priority queue though :( It can be tough enough to agree to release a
component as it is, without adding another level.
What might work is something more informal like: "I've worked on [foo] and
I've done all I need to g
Hi Benedikt,
I like the idea. I'm sure we would all prefer to release more often.
br,
Matt
On Mon, Mar 18, 2013 at 4:43 PM, Benedikt Ritter wrote:
> Hi all,
>
> when looking through the components and the sandbox I can see that
> development activity is very different.
> We have very few co
Thanks!
On 18 March 2013 21:43, Gary Gregory wrote:
> Fixed: Committed revision 1458025.
>
> G
>
>
> On Mon, Mar 18, 2013 at 5:37 PM, Gary Gregory wrote:
>
>> Very odd indeed, I'll need to fix...
>>
>> Gary
>>
>>
>> On Mon, Mar 18, 2013 at 5:32 PM, sebb wrote:
>>
>>> On 18 March 2013 17:16, wr
Fixed: Committed revision 1458025.
G
On Mon, Mar 18, 2013 at 5:37 PM, Gary Gregory wrote:
> Very odd indeed, I'll need to fix...
>
> Gary
>
>
> On Mon, Mar 18, 2013 at 5:32 PM, sebb wrote:
>
>> On 18 March 2013 17:16, wrote:
>> > Author: ggregory
>> > Date: Mon Mar 18 17:16:42 2013
>> > New
Hi all,
when looking through the components and the sandbox I can see that
development activity is very different.
We have very few components that are been worked on constantly, most
notably [math].
Some components seem to be worked on, only by a few people. [configuration]
comes to mind, where
Very odd indeed, I'll need to fix...
Gary
On Mon, Mar 18, 2013 at 5:32 PM, sebb wrote:
> On 18 March 2013 17:16, wrote:
> > Author: ggregory
> > Date: Mon Mar 18 17:16:42 2013
> > New Revision: 1457876
> >
> > URL: http://svn.apache.org/r1457876
> > Log:
> > Use final for read-only local var
On 18 March 2013 17:16, wrote:
> Author: ggregory
> Date: Mon Mar 18 17:16:42 2013
> New Revision: 1457876
>
> URL: http://svn.apache.org/r1457876
> Log:
> Use final for read-only local variables.
>
> Modified:
>
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections
On 18 March 2013 18:45, wrote:
> Author: ggregory
> Date: Mon Mar 18 18:45:56 2013
> New Revision: 1457915
>
> URL: http://svn.apache.org/r1457915
> Log:
> Fix Javadoc.
>
> Modified:
>
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
>
> M
On 18 March 2013 17:07, Simone Tripodi wrote:
> I took care about it reverting the MagicNumber constants, see r1457865
Thanks, but I think you misunderstood me.
I did not mean to say that constants should not be used for magic numbers.
On the contrary, constants are good, especially if the numbe
2013/3/18 Gary Gregory
> On Mon, Mar 18, 2013 at 5:08 PM, Benedikt Ritter
> wrote:
>
> > 2013/3/18 Thomas Neidhart
> >
> > > On 03/18/2013 06:08 PM, Gary Gregory wrote:
> > > > Hi All:
> > > >
> > > > What do we think needs to be done to get 4.0 out the door?
> > >
> > > I tried to group the ex
On 14 March 2013 08:25, Stefan Bodewig wrote:
> The vote has passed with +1s by Gary, Sebb, Benedict, Jörg and myself
> (which I didn't cast expplicitly, sorry) - four of which are binding.
>
> I'll promote the staging and copy over the tarballs now. I'll update
> the site and send out the announ
On 18 March 2013 14:56, wrote:
> Author: simonetripodi
> Date: Mon Mar 18 14:56:34 2013
> New Revision: 1457788
>
> URL: http://svn.apache.org/r1457788
> Log:
> [FILEUPLOAD-232] started importing MimeUtility test case from
> http://svn.apache.org/repos/asf/geronimo/specs/tags/geronimo-javamail_1
On Mon, Mar 18, 2013 at 5:08 PM, Benedikt Ritter wrote:
> 2013/3/18 Thomas Neidhart
>
> > On 03/18/2013 06:08 PM, Gary Gregory wrote:
> > > Hi All:
> > >
> > > What do we think needs to be done to get 4.0 out the door?
> >
> > I tried to group the existing issues this weekend, so everything that
2013/3/18 Thomas Neidhart
> On 03/18/2013 06:08 PM, Gary Gregory wrote:
> > Hi All:
> >
> > What do we think needs to be done to get 4.0 out the door?
>
> I tried to group the existing issues this weekend, so everything that is
> marked as 4.0 should be resolved imho, the most important ones bein
On 18 March 2013 20:31, Simone Tripodi wrote:
>> but there are too many discussions about checkstyle rules and "perfect"
>> releases. We should aim to follow more the open-source credo: release
>> early, release often, imho.
>
> I 150% agree with you mate - it's pity here we regularly miss both th
On 18 March 2013 13:14, Mladen Turk wrote:
> With 3 binding +1 votes (Luc, Gary and Mladen) and no
> other votes I declare this vote as passed.
>
> I'll copy the artefacts and create ANN message after mirrors pick up
> the release (within 24 hrs).
Please also add the files to the SVN dist tree so
Hi Oliver,
Many thanks for your feedback! I've requests feedback from the ML [1] but
nobody responded (I forgot to ping that thread to get some more
attention...). Please see my comments inline.
2013/3/18 Oliver Heger
> Am 16.03.2013 19:43, schrieb Benedikt Ritter:
>
> Hi Oliver
>>
>>
>> 2013/
Build works fine with:
Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
Maven home: D:\Entwicklung\maven\3.0.3
Java version: 1.7.0_13, vendor: Oracle Corporation
Java home: D:\Entwicklung\Java\jdk1.7.0_13-x64\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 7", version
As I understand it, this release does not change anything regarding OSGi
compatibility of [logging], and therefore OSGi meta data does not seem
to be a problem.
So +1.
Oliver
Am 16.03.2013 19:14, schrieb Oliver Heger:
Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site
lo
Am 16.03.2013 19:43, schrieb Benedikt Ritter:
Hi Oliver
2013/3/16 Oliver Heger
Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site
look good.
One thing I noticed, not sure whether this is actually a problem: The
artifacts for adapters and api have the same manifest infor
> but there are too many discussions about checkstyle rules and "perfect"
> releases. We should aim to follow more the open-source credo: release
> early, release often, imho.
I 150% agree with you mate - it's pity here we regularly miss both the
`early` and the `often` :)
http://people.apache.or
On 03/18/2013 09:04 PM, Simone Tripodi wrote:
> we were just kidding, mate :D
>
> you didn't get our sense of humor ;)
I got that ;-),
but there are too many discussions about checkstyle rules and "perfect"
releases. We should aim to follow more the open-source credo: release
early, release ofte
we were just kidding, mate :D
you didn't get our sense of humor ;)
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Mar 18, 2013 at 8:56 PM, Thomas Neidhart
wrote:
> On 03/18/2013 08:44 PM, Simone Tri
On 03/18/2013 08:44 PM, Simone Tripodi wrote:
>>
>> Are you sure, that we don't have a checkstyle rule for too smart code?
>>
>> ;-)
>
> lol, that violates the `Avoid inline conditionals.` rule! :D
checkstyle is just a tool, not our master!
Disable the rules that do not make sense,
just my 2c
>
> Are you sure, that we don't have a checkstyle rule for too smart code?
>
> ;-)
lol, that violates the `Avoid inline conditionals.` rule! :D
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On 03/18/2013 06:08 PM, Gary Gregory wrote:
> Hi All:
>
> What do we think needs to be done to get 4.0 out the door?
I tried to group the existing issues this weekend, so everything that is
marked as 4.0 should be resolved imho, the most important ones being:
* finalize the Buffer -> Queue chan
Simone Tripodi wrote:
>> Well, it could be recoded like this:
>>
>> return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
>>
>> which is not really clearer but it is fewer chars..
>>
>> Gary
>>
>
> well, looks smart to me! :)
Are you sure, that we don't have a checkstyle rule for too smart
> Well, it could be recoded like this:
>
> return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
>
> which is not really clearer but it is fewer chars..
>
> Gary
>
well, looks smart to me! :)
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/si
Well, it could be recoded like this:
return !(o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0);
which is not really clearer but it is fewer chars..
Gary
On Mon, Mar 18, 2013 at 1:25 PM, Gary Gregory wrote:
> Sure, makes sense.
>
> Gary
>
>
> On Mon, Mar 18, 2013 at 1:22 PM, Simone Tripodi
>
Salut Gary,
> +if (o1.intValue() % 2 == 0 ^ o2.intValue() % 2 == 0) {
> +return false;
> +} else {
> +return true;
> +}
FWIW, you don't need the `else` here.
my 2 cents,
-Simo
http://people.apache.org/~simon
I took care about it reverting the MagicNumber constants, see r1457865
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Mar 18, 2013 at 12:12 PM, sebb wrote:
> On 18 March 2013 10:45, Simone Tripodi w
On 2013-03-18, William Speirs wrote:
> On Sun, Mar 17, 2013 at 5:34 PM, sebb wrote:
>>> Maven artifacts are here:
>>> http://people.apache.org/~wspeirs/commons-dbutils-2.0-RC1/maven
>> Maven artifacts must be uploaded to Nexus.
> How do I do this? I was following the directions here:
> http://c
Thank you for pushing this release Bill.
I looked quickly at the Javadoc, here is my feedback:
- The three QueryRunner.query() methods return a package private type
- AsyncExecutor.execute() has a private type as argument
- Is there a way to generify ArrayHandler and have the handle() method
to r
On Mon, Mar 18, 2013 at 9:22 AM, William Speirs wrote:
> On Sun, Mar 17, 2013 at 5:34 PM, sebb wrote:
> >> Maven artifacts are here:
> >> http://people.apache.org/~wspeirs/commons-dbutils-2.0-RC1/maven
> >
> > Maven artifacts must be uploaded to Nexus.
>
> How do I do this? I was following the d
@author tags are discouraged across ASF Java code; Maven projects can use
the POM, while other projects can use whatever other mechanism they deem
appropriate for establishing a record of contributors. My personal view is
that the presence of author tags is not so offensive as to hold up a
release
On Sun, Mar 17, 2013 at 5:34 PM, sebb wrote:
>> Maven artifacts are here:
>> http://people.apache.org/~wspeirs/commons-dbutils-2.0-RC1/maven
>
> Maven artifacts must be uploaded to Nexus.
How do I do this? I was following the directions here:
http://commons.apache.org/releases/release.html which
With 3 binding +1 votes (Luc, Gary and Mladen) and no
other votes I declare this vote as passed.
I'll copy the artefacts and create ANN message after mirrors pick up
the release (within 24 hrs).
On 03/15/2013 08:12 AM, Mladen Turk wrote:
Please vote (vote will remain open for at least 72 hour
On 03/15/2013 08:12 AM, Mladen Turk wrote:
Apache Commons Daemon 1.0.14 is
[x] +1 Release
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
My vote FTR.
Regards
--
^TM
--
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Commons Wiki" for
change notification.
The "CodeStyle" page has been changed by sebbapache:
http://wiki.apache.org/commons/CodeStyle?action=diff&rev1=9&rev2=10
Comment:
More rules
||JavaDoc: @author Tag should not be use
On 18 March 2013 10:45, Simone Tripodi wrote:
> feel free to adjust them by yourself and make checkstyle silent about
> that rules - I am not so worried as you are about internal-use only
> classes which are intended to be used by fileupload and are not part
> of the APIs.
See my other post - it'
+1
Gary
On Mar 18, 2013, at 6:20, sebb wrote:
> On 18 March 2013 10:07, Benedikt Ritter wrote:
>> 2013/3/18 sebb
>>
>>> The new utils.mime classes for MIME decoding are mostly package-protected.
>>>
>>> However, they have public methods (and ctors) which is a bit misleading.
>>>
>>> I think i
I agree with Sebb.
Gary
On Mar 18, 2013, at 4:35, sebb wrote:
> On 15 March 2013 16:20, wrote:
>> Author: simonetripodi
>> Date: Fri Mar 15 16:20:27 2013
>> New Revision: 1457003
>>
>> URL: http://svn.apache.org/r1457003
>> Log:
>> checkstyle: magic numbers
>
> -1
>
> Although these changes d
> The new utils.mime classes for MIME decoding are mostly package-protected.
>
> However, they have public methods (and ctors) which is a bit misleading.
>
> I think it would make sense to reduce the visibility to package protected.
>
> Any objections?
>
No objections
http://people.apache.org/~si
feel free to adjust them by yourself and make checkstyle silent about
that rules - I am not so worried as you are about internal-use only
classes which are intended to be used by fileupload and are not part
of the APIs.
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
2013/3/18 sebb
> On 18 March 2013 10:07, Benedikt Ritter wrote:
> > 2013/3/18 sebb
> >
> >> The new utils.mime classes for MIME decoding are mostly
> package-protected.
> >>
> >> However, they have public methods (and ctors) which is a bit misleading.
> >>
> >> I think it would make sense to re
On 18 March 2013 09:58, Jörg Schaible wrote:
> sebb wrote:
>
>> On 18 March 2013 09:17, Jörg Schaible wrote:
>
> [snip]
>
>>> Actually, for my own projects I always add
>>>
>>> @since upcoming
>>>
>>> or
>>>
>>> @deprecated As of upcoming ...
>>>
>>> When I prepare a release I use a the regular
On 18 March 2013 10:07, Benedikt Ritter wrote:
> 2013/3/18 sebb
>
>> The new utils.mime classes for MIME decoding are mostly package-protected.
>>
>> However, they have public methods (and ctors) which is a bit misleading.
>>
>> I think it would make sense to reduce the visibility to package prot
2013/3/18 sebb
> The new utils.mime classes for MIME decoding are mostly package-protected.
>
> However, they have public methods (and ctors) which is a bit misleading.
>
> I think it would make sense to reduce the visibility to package protected.
>
> Any objections?
>
I personally don't align v
> To whatever decision we come here, please let us document it somewhere in
> the wiki...
+ 1
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
---
sebb wrote:
> On 18 March 2013 09:17, Jörg Schaible wrote:
[snip]
>> Actually, for my own projects I always add
>>
>> @since upcoming
>>
>> or
>>
>> @deprecated As of upcoming ...
>>
>> When I prepare a release I use a the regular expression "s/(since|As of)
>> (\s+)upcoming/\1\2VERSION/" to
The new utils.mime classes for MIME decoding are mostly package-protected.
However, they have public methods (and ctors) which is a bit misleading.
I think it would make sense to reduce the visibility to package protected.
Any objections?
2013/3/18 sebb
> On 18 March 2013 09:17, Jörg Schaible wrote:
> > Simone Tripodi wrote:
> >
> >> http://people.apache.org/~simonetripodi/
> >> http://simonetripodi.livejournal.com/
> >> http://twitter.com/simonetripodi
> >> http://www.99soft.org/
> >>
> >>
> >> On Mon, Mar 18, 2013 at 9:51 AM, s
On 18 March 2013 08:56, Stefan Bodewig wrote:
> On 2013-03-17, sebb wrote:
>
Manual Method
>
>> Surely names are normally lower-case only and no spaces?
>> I think spaces make the links look odd (and awkward to type).
>
> Uses the same syntax as the mvn site plugin created for subsection
On 18 March 2013 09:17, Jörg Schaible wrote:
> Simone Tripodi wrote:
>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>> On Mon, Mar 18, 2013 at 9:51 AM, sebb wrote:
>>> On 18 March 2013 08:4
On 17 March 2013 13:19, Simone Tripodi wrote:
>>> /**
>>> + * The default number of byte shift for decode.
[Actually, it's not a default - the value is fixed, and cannot be
changed without breaking the code.]
>>> + */
>>> +private static final int OUT_SHIFT = 4;
>>> +
>>
>> The
Simone Tripodi wrote:
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
> On Mon, Mar 18, 2013 at 9:51 AM, sebb wrote:
>> On 18 March 2013 08:46, Sebb (JIRA) wrote:
>>>
>>> [
https://issues.ap
On 17 March 2013 11:02, sebb wrote:
> See other comments on magic number fixes.
>
> I don't think these changes achieve anything apart from keeping
> Checkstyle happy.
> IMO the number is still magic (unexplained) when it is turned into a
> constant, and it seems stilly to have a constant that is
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Mon, Mar 18, 2013 at 9:51 AM, sebb wrote:
> On 18 March 2013 08:46, Sebb (JIRA) wrote:
>>
>> [
>> https://issues.apache.org/jira/browse/DIGESTER-171?pag
On 2013-03-17, sebb wrote:
>>> Manual Method
> Surely names are normally lower-case only and no spaces?
> I think spaces make the links look odd (and awkward to type).
Uses the same syntax as the mvn site plugin created for subsection now
(with s/h3/h4/), i.e.
Manual Method
Stefan
--
On 18 March 2013 08:46, Sebb (JIRA) wrote:
>
> [
> https://issues.apache.org/jira/browse/DIGESTER-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604945#comment-13604945
> ]
>
> Sebb commented on DIGESTER-171:
> ---
>
>
On 15 March 2013 16:20, wrote:
> Author: simonetripodi
> Date: Fri Mar 15 16:20:27 2013
> New Revision: 1457003
>
> URL: http://svn.apache.org/r1457003
> Log:
> checkstyle: magic numbers
-1
Although these changes don't affect the code, they are wrong.
Just because the same number (e.g. 3) is u
Online report :
http://vmbuild.apache.org/continuum/buildResult.action?buildId=26464&projectId=75
Build statistics:
State: Failed
Previous State: Failed
Started at: Mon 18 Mar 2013 08:20:03 +
Finished at: Mon 18 Mar 2013 08:20:21 +
Total time: 17s
Build Trigger: Schedule
Bui
66 matches
Mail list logo
