Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Phil Steitz
Henri Yandell wrote: > On Mon, Dec 28, 2009 at 7:11 PM, Phil Steitz wrote: >> Hopefully all problems with JDK versions and the site build have now >> been resolved. As previously discussed, the only difference between >> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude >> JDBC4 m

[continuum] BUILD FAILURE: Commons - Commons DBCP -

2009-12-30 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=264095&projectId=22 Build statistics: State: Failed Previous State: Failed Started at: Wed 30 Dec 2009 01:55:48 -0800 Finished at: Wed 30 Dec 2009 01:57:55 -0800 Total time: 2m 7s Build Trigger: Schedule

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Phil Steitz
sebb wrote: > On 29/12/2009, Phil Steitz wrote: >> Hopefully all problems with JDK versions and the site build have now >> been resolved. As previously discussed, the only difference between >> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude >> JDBC4 methods. Version 1.3 is

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Luc Maisonobe
Phil Steitz a écrit : > Hopefully all problems with JDK versions and the site build have now > been resolved. As previously discussed, the only difference between > 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude > JDBC4 methods. Version 1.3 is for JDK 1.4-1.5 and only builds un

Re: svn commit: r894641 - /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java

2009-12-30 Thread Phil Steitz
s...@apache.org wrote: > Author: sebb > Date: Wed Dec 30 15:08:09 2009 > New Revision: 894641 > > URL: http://svn.apache.org/viewvc?rev=894641&view=rev > Log: > Fix multi-threading (data visibility) bugs in PoolTest nested class > Show details of Exception if it is not excepted > Improve failure m

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread sebb
I've reproduced the problem on my WinXP system using Java 1.6.0. However, it only happens once in every 150 or 250 tests. There were some multi-threading bugs in the PoolTest nested class, which I have fixed in trunk; I also added more info if the test fails. The failure appears to be a timeout

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Niall Pemberton
On Wed, Dec 30, 2009 at 11:31 AM, sebb wrote: > On 29/12/2009, Phil Steitz wrote: >> Hopefully all problems with JDK versions and the site build have now >> been resolved. As previously discussed, the only difference between >> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Jim Jagielski
On Dec 30, 2009, at 6:31 AM, sebb wrote: > > The 1.3 code builds and tests OK with Java 1.4.2 and 1.5.0, but > generates a lot of stack traces from TestManual.testLogWriter(). > Ideally the output should be suppressed. > > However, compilation fails when using Java 1.6.0. Unfortunately the POM s

Re: [lang][collections] Overlap; Collections thoughts

2009-12-30 Thread Benson Margulies
Henri, To make this more interesting, the new collections over in mahout-math might be covering some of the territory you are looking for here. --benson On Wed, Dec 30, 2009 at 5:18 AM, Henri Yandell wrote: > Overlap between Lang and Collections is starting to increase a bit. > Requested items

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread sebb
Also, just noticed that Continuum has had a test failure: testMultipleThreads(org.apache.commons.dbcp.datasources.TestPerUserPoolDataSource) Time elapsed: 0.899 sec <<< FAILURE! junit.framework.AssertionFailedError at junit.framework.Assert.fail(Assert.java:47) at junit.framework

[continuum] BUILD FAILURE: Commons - Commons DBCP -

2009-12-30 Thread contin...@vmbuild.apache.org
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=264029&projectId=22 Build statistics: State: Failed Previous State: Ok Started at: Tue 29 Dec 2009 21:25:02 -0800 Finished at: Tue 29 Dec 2009 21:27:29 -0800 Total time: 2m 27s Build Trigger: Schedule Bui

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread sebb
On 29/12/2009, Phil Steitz wrote: > Hopefully all problems with JDK versions and the site build have now > been resolved. As previously discussed, the only difference between > 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude > JDBC4 methods. Version 1.3 is for JDK 1.4-1.5 an

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Henri Yandell
On Mon, Dec 28, 2009 at 7:11 PM, Phil Steitz wrote: > Hopefully all problems with JDK versions and the site build have now > been resolved.  As previously discussed, the only difference between > 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude > JDBC4 methods.  Version 1.3 is for

Re: [VOTE] Release DBCP 1.3/1.4 - take three

2009-12-30 Thread Oliver Heger
+1 There are a few checkstyle errors and some problems reported by findbugs, but these are certainly no show stoppers. Oliver Phil Steitz schrieb: Hopefully all problems with JDK versions and the site build have now been resolved. As previously discussed, the only difference between 1.3 and

RE: FileItem.getName() not giving arabic file name which is uploaded

2009-12-30 Thread Raghuveer
By default servers use ISO-8859-1 charset.Convert the value to UTF-8 and use. String fieldName = item.getFieldName(); String strValue = item.getString(); String strValueActual=new String(strValue.getBytes("ISO-8859-1"), "UTF-8"); Regards, Raghuveer Vellanki Email : raghuve...@infotechsw.com

Re: [lang][collections] Overlap; Collections thoughts

2009-12-30 Thread Henri Yandell
Additional thought... the Collections Test library should move to being a first class component in Commons rather than a side thought inside Collections. So this is three new components from one: * Test library * Core JDK [Lang merge?] * Collections impls On Wed, Dec 30, 2009 at 2:18 AM, Henri Ya

[lang][collections] Overlap; Collections thoughts

2009-12-30 Thread Henri Yandell
Overlap between Lang and Collections is starting to increase a bit. Requested items for ArrayUtils (LANG-238, LANG-470) are better implemented imo as an ArraySet class. An easy add to Collections. ComparableComparator made its way (privately) over for the new Range class. Fair enough - Comparable