Henri Yandell wrote: > On Mon, Dec 28, 2009 at 7:11 PM, Phil Steitz <phil.ste...@gmail.com> wrote: >> Hopefully all problems with JDK versions and the site build have now >> been resolved. As previously discussed, the only difference between >> 1.3 and 1.4 is that the 1.3 sources have been filtered to exclude >> JDBC4 methods. Version 1.3 is for JDK 1.4-1.5 and only builds under >> one of these JDKs. Note that to execute the 1.3 maven build under >> JDK 1.4 you need a 2.0.x version of maven. > > Not a blocker for the artifacts, but I would like to see more on the > DBCP homepage explaining this. Also suggest we make the version in > JIRA be "1.3/1.4", then "1.3.1/1.4.1"; currently it doesn't map to the > release description (afaict). > > I'd also suggest splitting the description in changes.xml to talk > about 1.3 in 1.3; there's too much text in the 1.4 entry for it to be > grokkable right now.
There is nothing specific to 1.3. The 1.3 entry just refers to the 1.4 stuff. Version 1.3 is just a "compatibility release." > > I think people would quite easily get: > > "JDBC 4 (Java 6+) version" > "JDBC 3 (Java 1.4+) version" That's what I tried to indicate in the release notes and readme. I will try to make it clearer somehow. > >> Here are the artifacts: >> >> 1.3 (JDBC 3) version: >> http://people.apache.org/~psteitz/dbcp-1.3-rc6 >> http://people.apache.org/~psteitz/dbcp-1.3-rc6/site >> http://people.apache.org/~psteitz/dbcp-1.3-rc6/maven >> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_3_RC6/ >> >> 1.4 (JDBC 4) version: >> http://people.apache.org/~psteitz/dbcp-1.4-rc6 >> http://people.apache.org/~psteitz/dbcp-1.4-rc6/site >> http://people.apache.org/~psteitz/dbcp-1.4-rc6/maven >> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_1_4_RC6/ >> >> Release notes (common version, ships with both) >> http://people.apache.org/~psteitz/RELEASE-NOTES.txt > > Release notes issue: > > "o DBCP-143: SQLNestedException has been deprecated and will be > replaced in DBCP 1.4 with..." > > I'm not sure this is a correct statement - I don't see conditional > compilation concepts to replace SQLNestedException to SQLException in > the 1.4 version; but I've not looked too hard. > >> Votes, please. This VOTE will close 01-January-2010 03:30 GMT. >> >> [ ] +1 Proceed with release >> [ ] +0 OK >> [ ] -0 OK, but I would prefer... >> [ ] -1 No, showstopper = ... > > Release itself looks good. +1 as my issues are all fixable on the site > (bar the release notes 1.4 bit, and I leave that to your judgement. > It's not a blocker imo to have a little confusion in there). > > Hen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
