[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/238 Build and create tomcat, fix several other issues with management server Hi guys, This PR has the following goodies: - Tomcat built by maven project (currently set to 8.0.22

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-100282638 Yes, it completely removes the need to have tomcat installed in the distro, and at the same time won't conflict if there is any other version of t

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-100317657 Yes, I'll take care of that.. i just haven't removed the old tomcat files of other installers so that this PR wouldn't break building on an

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-11 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-100966791 Hi @bhaisaab Have you had time to test this? I'm amazed no one else cared to take a look at it, as it's a big change and a big step into supporting

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-12 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101265715 Hi @bhaisaab :) I've also made some basic testing with fedora 2x as you asked and got everything working last night (apart from having the cluster se

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-12 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30165996 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-12 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101399140 Good catch k0kza, I hadn't noticed that StaticResourceServlet class, but i'll do some benchmarking on that vs tomcat 8's connector built in compre

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-12 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30173402 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-13 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30233372 --- Diff: ui/index.jsp --- @@ -1761,73 +1761,73

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-13 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-101683092 @bhaisaab rebased and sent. No new fixes since yesterday, but i rolled back the change of port 9090, to not leave anyone unhappy and make things easier on

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-14 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30316856 --- Diff: packaging/package.sh --- @@ -48,6 +48,13 @@ function packaging() { fi DISTRO=$3 + +JDK=$(rpm -qa | grep

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-19 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r30591946 --- Diff: packaging/package.sh --- @@ -48,6 +48,13 @@ function packaging() { fi DISTRO=$3 + +JDK=$(rpm -qa | grep

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-20 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-103820696 Hello @wilderrodrigues :) I guess the status of this PR is that it was waiting for me to fix the build issues... i was away since last wednesday and just got

[GitHub] cloudstack pull request: Fixuireload

2015-05-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/277 Fixuireload This PR is for issue https://issues.apache.org/jira/i#browse/CLOUDSTACK-8499 This affects all versions of cloudstack and can be cleanly applied to all supported branches

[GitHub] cloudstack pull request: Fixes breadcrumbs problem described in CL...

2015-05-21 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/282 Fixes breadcrumbs problem described in CLOUDSTACK-7907 There was an overlap in container placement in the breadcrumbs, leading to the links not being visually correct in some coordinates

[GitHub] cloudstack pull request:

2015-05-21 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11318709 In debian/rules: In debian/rules on line 6: Hi @DaanHoogland This breaks the 4.6.0-SNAPSHOT .deb file builds

[GitHub] cloudstack pull request: CLOUDSTACK-8499: Fixuireload

2015-05-22 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/277#issuecomment-104563604 Hi bhaisaab, A UI developer should be able to just press CTRL+F5 and always get the fresh version of files.. no need for something complicated... I just did

[GitHub] cloudstack pull request: Debian packaging fixes

2015-05-22 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/291 Debian packaging fixes Fixes problem with having to change the "-SNAPSHOT" string in debian/rules for releases, deb packaging was broken in master due to this in a merge wit

[GitHub] cloudstack pull request:

2015-05-22 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11331207 In debian/rules: In debian/rules on line 6: @DaanHoogland great, master is building on debian again :) I

[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...

2015-05-22 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/280#issuecomment-104771495 @wilderrodrigues the Xenserver tests are failing in master with a ClassCast Exception :( */plugins/hypervisors/xenserver/src/com/cloud/hypervisor

[GitHub] cloudstack pull request:

2015-05-23 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/1c408dec37a278c97c1b40da0bdbca437d7a564c#commitcomment-11339020 In packaging/centos63/cloud.spec: In packaging/centos63/cloud.spec on line 273: Hi again @DaanHoogland :) This

[GitHub] cloudstack pull request: Fix xenserver tests for travis

2015-05-23 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/293 Fix xenserver tests for travis Fix ClassCast exception being thrown due to recursive scan in com.cloud.hypervisor.xenserver.resource.wrapper picking up subpackage modules for running the

[GitHub] cloudstack pull request: CLOUDSTACK-8502 Improvement/annotations k...

2015-05-23 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/280#issuecomment-104901705 Hoi @wilderrodrigues :) I've created a pull request for it, have a look https://github.com/apache/cloudstack/pull/293 glad to

[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...

2015-05-24 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105056903 Hi @remibergsma If you're running into the no tty issue, that will likely happen also for the other commands the management server tries to run.

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-24 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-105057113 looks like a couple more things got broken since last rebase with master... need to refix :| --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...

2015-05-24 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105063069 Silly me.. this is running as supplied user, not as cloud. I agree remi, ssh -t is the better option :) --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8339: Allow non-root users to ...

2015-05-24 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/288#issuecomment-105073554 Creating a user for this use would be worse, because it would require some sort of 'standard' credential for ssh access. Or it would require that suc

[GitHub] cloudstack pull request: Debian packaging fixes

2015-05-25 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/291#issuecomment-105253780 @bhaisaab , I wanted to keep hugo's history by manually editing the changelog after doing the testing... unfortunately, editing it manually breaks it.

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359437 Hi @wilderrodrigues The refactoring of the Libvirt broke Libvirt functionality in runtime. Whenever spinning up a

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359669 This happens in all my environments (Ubuntu, Fedora21, Centos6, Centos7) All marvin tests run fine in all environments

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11359702 This is where ANY exception gets thrown into an UnsupportedCommandAnswer, with no information about the actual exception

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11360242 Hi @wilderrodrigues Everything is built on the latest code in my testing, so agent is 4.6.0-SNAPSHOT as well

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361925 @wilderrodrigues Yes, i mean creating datacenter manually, since creating it in simulator with marvin shows no errors

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361958 It's actually sending an UnsupportedAnswer.class object, that is why it's not StartAnswer.class. Pu

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11361983 java.lang.NullPointerException at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362046 Just to be clear... NO error is logged in the agent logs when this occurs (with the current code). It just keeps trying to

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362538 Well.. it's actually this line, perhaps i was mistaken about line 72.. just got that from my fuzzy m

[GitHub] cloudstack pull request:

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf#commitcomment-11362581 I can't test ATM, but i will do so later when i get home :) --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/238#discussion_r31043937 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConsoleProxyLoadCommandWrapper.java --- @@ -49,6 +49,11

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-26 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/308 Reinstate working sessions in browser I've seen that session persistence stopped working due to https://github.com/apache/cloudstack/commit/19e3c0168e744a76b5e1dc24a5eafa776d342404

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105672476 @bhaisaab please take a look :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/308#discussion_r31084802 --- Diff: ui/scripts/cloudStack.js --- @@ -329,7 +325,6 @@ g_regionsecondaryenabled = null

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-26 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105682213 I searched around for that reference and found nothing useful, perhaps @bhaisaab can shed some light, since it was signed off by him :) If I understood

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-27 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-10584 Hi @wilderrodrigues I was hoping on reducing the number of changes from this PR to master, so it would be better if you pushed it along with your refactor

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-27 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-105861689 I see that in the parent commit Jessica tried to fix security on the cookie by setting httponly=true in tomcat's context .xml This would be a sane thing

[GitHub] cloudstack pull request: CLOUDSTACK-8517 Fix the NPE that was bein...

2015-05-27 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/318#issuecomment-105931452 Great @wilderrodrigues :) Thank you for fixing that, i'll test it out later. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106741425 Hi @remibergsma First of all. thank you for your comment :) I've been very busy these past couple of days, so i haven't gotten around to d

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106752449 Hi @wilderrodrigues Both the issues you hit are legacy behaviour :) I'm guessing that you've deployed it in debian, because the

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-106758023 Indeed.. it's only setup on centos 6 and not 7, sorry for misleading you there :) cloudstack-setup-management will link the server.xml in any enviro

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-106818248 Hi Rohit, thank you for your view on this :) Here's my comment on it: 1. No use on protecting the sessionkey from MITM attacks, as the use

[GitHub] cloudstack pull request: Cleanup awsapi leftovers

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/328 Cleanup awsapi leftovers Just a couple of things that were still in the code :) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request: Cleanup awsapi leftovers

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/328#issuecomment-106875402 If if comes back we will just kill it again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and 4.5

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106893942 @DaanHoogland too late for 4.4.4? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106897613 nah not blocking a thing on my side.. just thought i'd contribute something more to your release, but it wasn't on time :) one old bug less for 4.4

[GitHub] cloudstack pull request: Change tests random number generator to /...

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/330 Change tests random number generator to /dev/urandom This fixes a big performance issue with random number generation with more recent kernels and java versions in linux, the impact is

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106904018 perhaps there was a regression? I got the issue in 4.4 and 4.5 master is fine though :) --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908778 @bhaisaab you are right! .. though it happened on the 4.5 version i built locally... perhaps my copy of the branch was not up to date when i tested :) Closing

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
GitHub user rsafonseca reopened a pull request: https://github.com/apache/cloudstack/pull/329 Fix agent/management conflict There is an entry for the agent log directory in the management packaging, creating a conflict between the two RPMs. This issue occurs in both 4.4.x and

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/329 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix agent/management conflict

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/329#issuecomment-106908889 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Change tests random number generator to /...

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/330#issuecomment-106909482 there's a builtin symlink that redirects /dev/urandom to /dev/random. this is the only way to make it work :) This is a known issue with a lot of java

[GitHub] cloudstack pull request: Use same sudoers config for all distros

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/332 Use same sudoers config for all distros Each distro was using its own sudo config method, now all use the same config file and are setup by the packaging and have the user variable evaluated

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-106937060 Hi @bhaisaab I don't think that is an issue :) Whatever your login method, the cookie will always be set on the first successful command and subse

[GitHub] cloudstack pull request: Reflections upgrade to 0.9.9

2015-05-29 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/333 Reflections upgrade to 0.9.9 Reflection's 0.9.8 dependency javassist doen't properly support java8 and was throwing: Error: java.io.IOException: invalid constan

[GitHub] cloudstack pull request: Reflections upgrade to 0.9.9

2015-05-29 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/333#issuecomment-106941899 ops :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fixes LB certificate tests failure

2015-05-30 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/336 Fixes LB certificate tests failure Whenever the path to the project includes a URL encodable character like whitespace, these tests fail to find the local path to the certs. This is

[GitHub] cloudstack pull request: Update debian packaging

2015-06-01 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/339 Update debian packaging This fixes build issue with http://jenkins.buildacloud.org/view/4.4/job/cloudstack-4.4-package-deb/ Reduce source package size (was including .git) Fix a

[GitHub] cloudstack pull request: Version evaluated with native tools inste...

2015-06-01 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/341 Version evaluated with native tools instead of maven I think i saw a build failure yesterday on buildacloud.com due to missing plexus libs invoking the mvn command. Can't se

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107454748 LGTM :D Will test it out later! Thanks for this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Mocking the Connect object used in the Li...

2015-06-01 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/342#issuecomment-107663305 [INFO] Apache CloudStack Plugin - Hypervisor KVM . SUCCESS [6.987s] Perfect :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Version evaluated with native tools inste...

2015-06-03 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/341#discussion_r31657434 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-03 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-108577290 Hi @bhaisaab Any news on testing it? If i misunderstood the problem you stated, can you explain further or help fix as you suggested? I'm sure

[GitHub] cloudstack pull request: Update debian packaging

2015-06-03 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Update debian packaging

2015-06-03 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/339#issuecomment-108631632 yeah.. asfbot seems to only monitor master :) closing... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Version evaluated with native tools inste...

2015-06-03 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Version evaluated with native tools inste...

2015-06-03 Thread rsafonseca
Github user rsafonseca commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/341#discussion_r31677186 --- Diff: debian/rules --- @@ -1,6 +1,6 @@ #!/usr/bin/make -f # -*- makefile -*- -VERSION := $(shell mvn org.apache.maven.plugins:maven

[GitHub] cloudstack pull request: Fix findbugs high priority warning

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/362 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known

[GitHub] cloudstack pull request: Fix 2 findbugs high priority warnings

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/363 Fix 2 findbugs high priority warnings VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't fina

[GitHub] cloudstack pull request: Fix another findbugs high priority warnin...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/364 Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in

[GitHub] cloudstack pull request: Fix performance issue reported by findbug...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/365 Fix performance issue reported by findbugs (unnescessary boxing/unbox… …ing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769

[GitHub] cloudstack pull request: Fix 3 more findbugs performance alerts, c...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/366 Fix 3 more findbugs performance alerts, creating boxed Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java

[GitHub] cloudstack pull request: Fix another case of unnecessary boxing

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/367 Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive

[GitHub] cloudstack pull request: Fix last ocurrence of unnecessary boxing ...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/368 Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive

[GitHub] cloudstack pull request: Fix malformed closing tag on comments in ...

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/369 Fix malformed closing tag on comments in cisco .xml files You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack

[GitHub] cloudstack pull request: Test jenkins ovm3 failure

2015-06-07 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/370 Test jenkins ovm3 failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/rsafonseca/cloudstack ovm3fixtest Alternatively you can

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109951692 Session persistence is not working on any scenario atm. The aim of this is to fix that. The security measure is aimed to prevent browser vulnerability, which

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-109981697 @vadimkim Let me try to break it down: In the past, with the purpose of preventing a browser vulnerability, session persistence was completely

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110049806 @vadimkim It seems like you're not passing to cookies over to the client on that config :) Try setting: proxy_pass_header Set-C

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110051983 About the redirect rule, i will soon bake a patch that will render that unnecessary, but for now, there should be no problem with just rewriting it in the proxy

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
GitHub user rsafonseca opened a pull request: https://github.com/apache/cloudstack/pull/372 Embedded Tomcat & Jetty Well, this spruces things up a bit :) Some of the features/fixes (i may have forgotten a couple as this involved a lot of changes ;) ) - Embe

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-110082001 This has been stale for a while, here's something to spice it up :) https://github.com/apache/cloudstack/pull/372 If all in agreement will

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/238#issuecomment-110148582 Hi @bhaisaab :) The new https://github.com/apache/cloudstack/pull/372 was built on top of this one, so all the fixes in this are also in the other one. I

[GitHub] cloudstack pull request: Build and create tomcat, fix several othe...

2015-06-08 Thread rsafonseca
Github user rsafonseca closed the pull request at: https://github.com/apache/cloudstack/pull/238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110151397 Hi @terbolous I'm in no way a licensing expert, but don't think there's any incompatibility with the licensing.. but I'll leave that fo

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-08 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110161431 How about the FOSS license exception? https://www.mysql.com/about/legal/licensing/foss-exception/ FOSS License List License NameVersion(s

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110255489 Hi @wilderrodrigues , @serverchief Thank you for your feedback :) I understand your point, but since there are a lot of changes and most are

[GitHub] cloudstack pull request: Embedded Tomcat & Jetty

2015-06-09 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/372#issuecomment-110265493 Hi @terbolous I'm here to help, so i'll try to break it down a bit in the coming days as i mentioned :) Testing this will take some time a

[GitHub] cloudstack pull request: Reinstate working sessions in browser

2015-06-09 Thread rsafonseca
Github user rsafonseca commented on the pull request: https://github.com/apache/cloudstack/pull/308#issuecomment-110268630 @vadimkim I need to do some testing with this setup, which i'm afraid i might only have time to do later this week or in the weekend. It generally easi

  1   2   3   >