Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105846666
Hi @wilderrodrigues
I was hoping on reducing the number of changes from this PR to master, so
it would be better if you pushed it along with your refactor and i'll just
rebase with master, since i don't know when this will get merged :)
During your Libvirt refactor pushes, i was having some trouble with that
specific test taking too long to run, it was fixed after i set the timeout
(after 5 seconds failure, waits no longer to fail and continues), so this
speeds things up unless a connection is not actually established, not the other
way around :)
Replacing that with a static final would be nice, but like i said, this is
a copy/paste from the xenserver class of the same name, so that change should
be applied there also in order to be consistent.
I'd rather not add any more fixes that are unrelated to the tomcat change
into this PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
