[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

2016-09-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1694#discussion_r80853405 --- Diff: server/test/com/cloud/storage/listener/StoragePoolMonitorTest.java --- @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

2016-09-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1694#discussion_r80853668 --- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java --- @@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand cmd

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1542 @jburwell nested VM is something tricky to test, we can support this as a subtle feature but not a generally supported one. In our test/trillian environment, we're already running n

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1689 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 @jburwell even with change in transifex format [1], some transformation and conversion of json to a js dictionary would still be needed. @milamberspace I've fixed the issues now. P

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 A failure at the backend was detected, I've rekicked the test jobs. We should expect results in next >7.5 hours. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1685 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1681 LGTM, some test failures have been addressed here: https://github.com/apache/cloudstack/pull/1692 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1693 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r80878310 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r80878187 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -111,37 +116,37 @@ public CertServiceImpl() { @DB

[GitHub] cloudstack pull request #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r80878034 --- Diff: pom.xml --- @@ -70,7 +70,7 @@ 4.12 1.3 -1.46 +1.54 --- End diff -- Fixed --- If your

[GitHub] cloudstack issue #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1511 @jburwell I've squashed the changes, due to changes in the main/core dependency version the PR may not be merged on 4.9 and has been rebased to latest master. If this made into any 4.

[GitHub] cloudstack issue #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1511 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1511: [master] bountycastle changes

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1511 @blueorangutan test centos7 kvm-centos7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

2016-09-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 I'm investigating failures on this PR, likely most of them (esp related to oobm) are env related as udp traffic seems to be blocked. There also seems to be an error with the log upload s

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 On investigation, it was found that Trillian was falling back on master branch's tests which is why the test failures were high. Some of the feature such as oobm don't exist in 4.8. I&#

[GitHub] cloudstack issue #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1695 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1695 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1694: CLOUDSTACK-9509: Host Connects Without Storage

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1694 The previous test run was incorrect, several tests were run from master the features that don't exist on 4.8. @blueorangutan test --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1688 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1688 LGTM. Jenkins failure is not caused by change from the PR. @abhinandanprateek @murali-reddy a second review please? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1650 LGTM. @abhinandanprateek is the changes okay, or we should refactor move them to the default test_data file? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 @jburwell @milamberspace with the current changes, no explicit change in workflow is needed but may be change in future. Since the aim of the PR was to get rid of jsps, I would like to avoid too

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 a...

2016-09-29 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1696 [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a guest OS Adds Ubuntu 16.04 as a supported guest os. This allows users to select the OS when creating a template etc. SQL queries

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @abhinandanprateek @murali-reddy please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @ustcweizhou Hi, I think I used your changes here. VMware is sane to interpret Ubuntu guest vms as either ubuntuGuest or ubuntu64Guest (identifier used), while to XS and KVM full names are passed

[GitHub] cloudstack issue #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1695 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1688 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1695: CLOUDSTACK-9511: fix test_privategw_acl.py to handle...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1695 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1688 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1685: IGNORE this PR

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1685 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 Thanks @milamberspace is that a LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 @milamberspace thanks, yes please proceed with changing transifex format following merge of this PR. I lack experience with Transifex usage, but I can help with transforming the current

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 With the tests and lgtms, I'll go with merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/927 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 Thanks @ustcweizhou I'll fix as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1669 @milamberspace I've started a new ticket to track progress on migration of transifex to json format: https://issues.apache.org/jira/browse/CLOUDSTACK-9513 --- If your project is set up f

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 I've manually kicked a trillian env (tid-84) to get an env against xenserver 6.5sp1, as soon as it comes up I'll perform the test to launch a Ubuntu 16.04 VM using templates

[GitHub] cloudstack issue #1690: Update L10N resource files with 4.10 strings from Tr...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1690 LGTM. Since it's a translation change, we've enough votes to merge this. I'll proceed with merging this on master. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack issue #1619: Add the Transifex config for next version of CS (4.1...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1619 LGTM. Since basic checks are all green and we've enough votes, I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1684 @pdion891 @jburwell as I've already explained, there should be no need to enable dynamic apichecker if you're upgrading from an older system that has a commands.properties file. I

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 With a manually deployed Trillian environment based on XenServer 6.5sp1, I was able to register Ubuntu 16.04 and launch a VM. Screenshots attached: ![screenshot from 2016-09-29 21-27-21

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell As per our maintenance policy we only maintain n, n-1 branches i.e. master (upcoming 4.10) and 4.9. At no point we had ever maintained three branches, it's too much overhead. So,

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1684 @jburwell when a fresh mgmt server is deployed for upgrading an existing CloudStack environment, several files from `/etc/cloudstack/management` are copied to the new server, especially the

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1684 @PaulAngus but it's up to the admin and how they want to upgrade/setup a new mgmt server. Assuming you want to create a new mgmt server for each old mgmt server, one strategy could be to cop

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @ustcweizhou @abhinandanprateek @murali-reddy @jburwell review? Manual tests confirm that it works on XenServer 6.5. @blueorangutan test --- If your project is set up for it, you can

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1650 I've moved the changes to PR #1692 this can be closed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1688: Marvin Tests: Fix VPC network offering selection

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1688 I've moved the changes to PR #1692 this can be closed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 Reran tests with fixed tests: Test | Result | Time (s) --- | --- | --- test_router_dhcphosts | Success | 248.223 test_isolate_network_password_server | Success | 59.451

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 Thanks @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @jburwell we may ignore that specific test, or retest the vmnet3 test on vmware against the default built-in (centos5 based) template. @NuxRo ping, can you help fix the macchanina template to

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 The failures from the above result are not related to the change but with the env/tests, most of which have been addressed in #1692 With the enough test results, manual tests and lgtms

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @PaulAngus @jburwell I've created a tinycore linux basd template here with e1000, e1000e and vmxnet3 driver loaded (lsmod to confirm). Once started, it ships only with openssh server and

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @jburwell based on the latest result results, the errors have significantly gone down. We will still need to re-investigate some of the error (which I thought were fixed, but still failed

[GitHub] cloudstack pull request #1542: CLOUDSTACK-9379: Support nested virtualizatio...

2016-09-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1542#discussion_r81405215 --- Diff: test/integration/smoke/test_nested_virtualization.py --- @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-30 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1542 @nvazquez you're welcome. If you've some bandwidth, can you run your test against this template which will also help validate the new vmware test appliance: https://github.com/rhtyd

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 Thanks @NuxRo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 I've tested my TinyLinux templates against vmware, xenserver and kvm and they are working alright. On VMware, the networking worked with the loaded e1000/e1000e kernel module.

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 Based on today's test runs and fixes, most tests run fine on kvm. At the moment, several fixes were done to several tests to ensure they run on vmware and xenserver as well. I've kicked

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1692 @NuxRo Thanks, I'll test and confirm for xen and kvm in few hours. Can you also update the repo on how anyone can build the templates from source? --- If your project is set up for it, yo

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1696 @jburwell rollback is not necessary. We've no guest os mappings for VMware 6.0, those need to be added. If needed, I can send a new PR. /cc @serg38 --- If your project is set up for it, yo

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1642 @jburwell @mike-tutkowski looks like marvin fails to get installed properly, one of the dependency fails with following: Command "/opt/python/2.7.10/bin/python2.7 -u -c &q

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1542 Thanks for testing @nvazquez I think since @NuxRo built new vmware templates, we can consume macchinina/vmware: http://dl.openvm.eu/cloudstack/macchinina/x86_64/testing The TinyCore

[GitHub] cloudstack issue #1699: CLOUDSTACK-9513 Migrate transifex workflow and forma...

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1699 Sweet! Thanks @milamberspace I was going to send this in few days, but you beat me to it :) I'll review this tomorrow and get back to you. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1699: CLOUDSTACK-9513 Migrate transifex workflow and forma...

2016-10-03 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1699 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213617967 @DaanHoogland thanks, in your test environment you'll need to install ipmitool (yum/apt-get) and the oobm tests would pass. These tests are also run by Travis

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213618402 @DaanHoogland additional notes on how tests work; we've introduce a new dependency `ipmisim` that I wrote for this feature, ipmisim is both a tool and a library

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214212648 @koushik-das this is part of the feature to be able to check access based on rules in DB and be consistent across all mgmt servers. In my local environment with

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60879938 --- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java --- @@ -34,6 +34,10 @@ public class PropertiesUtil { private static final

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880160 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880213 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880195 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880204 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880231 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60880846 --- Diff: test/integration/smoke/test_dynamicroles.py --- @@ -0,0 +1,474 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881018 --- Diff: server/src/org/apache/cloudstack/acl/RoleManagerImpl.java --- @@ -0,0 +1,273 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881499 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java --- @@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60881906 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java --- @@ -70,10 +72,12

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1489#discussion_r60882026 --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java --- @@ -119,6 +131,9 @@ private Long

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-25 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1517 engine/schema: fix upgrade path to work with MySQL 5.7 Found this issue when using MySQL 5.7 with Ubuntu 16.04. The upgrade path fix removes an invalid `IGNORE` param that is deprecated now, in

[GitHub] cloudstack pull request: engine/schema: fix upgrade path to work w...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1517#issuecomment-214229683 I found this article by Oracle MySQL team useful: https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885367 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60885329 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214233279 @wido thanks for the comments. It seemed easier to pass the arguments to the oobm subsystem, there is a immutable map of option,string being returned this is why all

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214240215 I've fixed all outstanding issues, please comment if you see any outstanding issue. LGTMs welcome, thanks. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890271 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r60890292 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +// Licensed

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-214249307 @DaanHoogland thanks, if we can migrate to Java8 I won't mind not fixing the issue for 1.7 at all --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-214252922 All tests passes, except for a test that runs only on simulator that sometimes passes, sometimes fails. This issue is due to master and not specific to this PR

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-214257913 Marvin Init Successful === TestName: test_oobm_background_powerstate_sync | Status : SUCCESS === === TestName: test_oobm_change_password

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-9299: doc for out-o...

2016-04-25 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/38 CLOUDSTACK-9299: doc for out-of-band management Admin documentation for out-of-band management feature cc @pdion891 @swill You can merge this pull request into a Git

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60898417 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-214276787 @koushik-das Yes, all tests run as a regular user too. See the integration test, we're using user api clients (search self.getUserApiClient) to perform tests -

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-04-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r60899950 --- Diff: tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh --- @@ -71,7 +71,7 @@ function install_packages() { iptables

<    4   5   6   7   8   9   10   11   12   13   >