Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60882026
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
---
@@ -119,6 +131,9 @@ private Long getDomainId() {
@Override
public void execute() throws ServerApiException {
+ if (getAccountType() == null && getRoleId() == null) {
+ throw new ServerApiException(ApiErrorCode.PARAM_ERROR, "Both
account type and role ID are not provided");
--- End diff --
@jburwell before this changes `accountType` was required, now it's made
optional with introduction of roleId, this check is to ensure at least one of
the two are provided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
