[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...

2017-03-10 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1999 CLOUDSTACK-9600: listVirtualMachines: add VPC ID to response Currently, the listVirtualMachines takes the vpcid as a param but does not return it in a response. It also solves expensive

[GitHub] cloudstack pull request #2000: CLOUDSTACK-8873: add zonename in load balance...

2017-03-10 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/2000 CLOUDSTACK-8873: add zonename in load balancer response add zonename in response for consistency. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou (1) I don't fully understand that question, there are network ids on the nics https://github.com/resmo/cloudstack/blob/705336af9d03b680c3254d37376ae22b146e97e8/server/sr

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou I can add another VPC tier in the _same_ VPC to the VM, but it is still the same VPC. I am still convinced this PR is valid unless you prove otherwise. I am ok with adding

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou let us discuss this on ML. I am now doing exactly this querying ListNetworks for each network for each VM which is stupid expensive operation to only find out if a VM is in a VPC

[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...

2017-03-11 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-11 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 Ok, then. Thanks @ustcweizhou and @remibergsma for the clarification, changing the code to add vpcid on the nic's network response. Closing this PR in favor of a new and

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-26 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76288584 @bhaisaab This also fails on cloudstack 4.4.2 on debian 7. fix worked. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76355991 @bhaisaab Seems I overlooked the fix yesterday. All good in 4.4 branch. never mind. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76358975 @runseb * 4.5 https://github.com/apache/cloudstack/commit/7885a6c4efe13a07b3966ef8684152dda5108f8b * master https://github.com/apache/cloudstack/commit

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

2015-03-04 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/94 CreatePortForwardingRuleCmd: Fix typo in description You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack patch-1 Alternatively

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

2015-03-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/94#issuecomment-77149699 @runseb ah yes, sure! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

2015-03-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/94#issuecomment-77151592 Did some more text stylings. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Debian package improvements

2015-03-04 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/96#discussion_r25807707 --- Diff: debian/control --- @@ -3,26 +3,26 @@ Section: libs Priority: extra Maintainer: Wido den Hollander Build-Depends: debhelper (>

[GitHub] cloudstack pull request: Debian package improvements

2015-03-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/96#issuecomment-77235301 +1 from me @debfx I recently also saw there is quite a hack in the debian init script for setting `JAVA_HOME` (https://github.com/apache/cloudstack/blob/master

[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...

2015-03-09 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/103 systemvm: use Debian http redirector for apt repositories * No offline mirrors * No out of date mirrors * New mirrors are used * Load-balancing * Faster downloads (when APT is used

[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...

2015-03-09 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/104 systemvm: correct sftp subsystem path of debian wheezy The sftp subsystem path is `/usr/lib/openssh/sftp-server` according https://packages.debian.org/wheezy/amd64/openssh-server/filelist and

[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...

2015-03-10 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/104#issuecomment-78016126 @karuturi we use [Ansible](http://docs.ansible.com/) to manage the routers ad-hoc (config fixes, package updates, security fixes, etc). Ansible uses SFTP for file

[GitHub] cloudstack pull request:

2015-03-10 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/8e953fe8593cf624c37213d94f79ea9e17a12f27#commitcomment-10121450 In systemvm/patches/debian/config/opt/cloud/bin/savepassword.sh: In systemvm/patches/debian/config/opt/cloud/bin

[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...

2015-03-10 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/103#issuecomment-78066339 @bhaisaab would you mind cherry-picking this commit into 4.5? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...

2015-03-19 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/119 systemvm: fix/improve irqbalance on multicore VR. This is a known issue in irqbalance 1.0.3 and was partially fixed in 1.0.4. Using the package 1.0.6 from wheezy backports helped on many VRs

[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...

2015-03-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/119#issuecomment-84888161 yes please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: systemvm: fix/improve irqbalance on multi...

2015-03-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/119#issuecomment-84899117 @bhaisaab I tested the irqbalance from backports, but I did not test the building of the systemvm. I assumed it must be set up in this script. --- If your project is

[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...

2015-03-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/123 systemvm: use Debian http redirector for backports You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/debian-http

[GitHub] cloudstack pull request:

2015-04-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/d0e65d7c3429d3a582632005d526c668f071c3fe#commitcomment-10534427 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-6885: fix logrotate on VR to d...

2015-04-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/162 CLOUDSTACK-6885: fix logrotate on VR to depend on size In 6ac06e5e5e3ceed4a3e3a86ea5f82ffb59c266f2 logrotate was changed to run hourly. Some logrotate configs still have set `daily` only which

[GitHub] cloudstack pull request: CreateVMSnapshot: fix typo in API descrip...

2015-04-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/161 CreateVMSnapshot: fix typo in API description You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/createvmsnapshot-typo

[GitHub] cloudstack pull request: Make the routers iptables config persiste...

2015-04-14 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93027681 There is a Debian package for this functionality called `iptables-persistent`. It is implemented using a init script. The rules are expected to be in `/etc

[GitHub] cloudstack pull request: Make the routers iptables config persiste...

2015-04-14 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93054007 hi @wilderrodrigues, never had any problems with it but didn't use it on a "router". It would be great if you can provide more details. I expected y

[GitHub] cloudstack pull request: Make the routers iptables config persiste...

2015-04-15 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/167#issuecomment-93387973 Okay, I see. In this case cherry-picking does not make any sense. I may implement a workaround by saving the iptables periodically on the routers in our env. This

[GitHub] cloudstack pull request: RFC: improve iptables persistent on VR

2015-04-17 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/178 RFC: improve iptables persistent on VR Iptables rules were loaded in `iptables-persistent` service during boot. So the first try was to save them where `iptables-persistent` reads them in /etc

[GitHub] cloudstack pull request: RFC: improve iptables persistent on VR

2015-04-18 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove AWS api bridge

2014-11-22 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/44#issuecomment-64081042 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...

2015-01-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/63 CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165088002 `older` is a bit misleading, what about `existent` e.g. findExistentHypervisorHostInCluster? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165410616 @sureshanaparti Ok, I see. then I would indeed use old but suggest `oldest` : `findExistentHypervisorHostInCluster`. Would you mind rebasing to get a clean PR

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165413590 @sureshanaparti that would be great. appreciate your work on vmware parts! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1256#issuecomment-165420030 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2015-12-17 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1254#discussion_r47931786 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java --- @@ -59,7 +59,7 @@ public QuotaSummaryCmd

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165712661 since #1257 replaces this PR I would do so, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-12-21 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1266 [4.4] CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties cherry-picked e7291fd600ce922a76b1fe9cd2c120a40d4cbc18 for 4.4 so bug can be closed after merging into 4.4. You can merge this pull

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166980994 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-01-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168295696 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-18 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r49976226 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def

[GitHub] cloudstack pull request: UI: improve filter dropdown width

2016-01-20 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1354 UI: improve filter dropdown width Giving a little more space to fix new line, see [after and before](https://photos.google.com/share

[GitHub] cloudstack pull request: SystemVM cleanups

2016-02-16 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1414 SystemVM cleanups from the logrotate docs > size - With this, the log file is rotated when the specified size is reached. Size may be specified in bytes (default), kilobytes (sizek),

[GitHub] cloudstack pull request: SystemVM cleanups

2016-02-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1414#issuecomment-185579250 Actually the logrotating is running every hour (by size), which can not be done with logrotate time interval. We have had problems in the past filling up /var (and

[GitHub] cloudstack pull request: listFirewallRules: cleanup and fix duplic...

2015-05-12 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/246 listFirewallRules: cleanup and fix duplicate params in API The parts deleted are already defined in the extended class. You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: debian: allow tomcat7 as optional depende...

2015-05-12 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/247 debian: allow tomcat7 as optional dependency You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/debian-tomcat7

[GitHub] cloudstack pull request: listPortForwardingRules: fix typo in doc

2015-05-12 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/248 listPortForwardingRules: fix typo in doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/listPortForwardingRules_typo

[GitHub] cloudstack pull request: listFirewallRules: cleanup and fix duplic...

2015-05-13 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-15 Thread resmo
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-15 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103429103 @bhaisaab It's been a while since I coded JAVA, have no clue, why it is failing. May I ask you for a hint? --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: WIP: affinitygroup: implement project sup...

2015-05-19 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/264 WIP: affinitygroup: implement project support You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/project-affinitygroup

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-20 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103890479 @bhaisaab a good IDE helps indeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Typo fixes and various cleanups

2015-05-21 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/275 Typo fixes and various cleanups I gave parts of the API descriptions some love. Capitalized the abbreviations and fixed many typos. You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: template, api: fix format desc, add OVA f...

2015-05-29 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/331 template, api: fix format desc, add OVA format You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack patch-1 Alternatively you

[GitHub] cloudstack pull request: CLOUDSTACK-8545 make reboot on out of ban...

2015-06-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/466#issuecomment-112762271 @DaanHoogland thanks for picking it up, btw do you port plan to fix it in 4.5 and master as well? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-06-22 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/508 [WIP] CLOUDSTACK-6276: project support in affinitygroups You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature/6276

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: affinitygroup: imp...

2015-06-22 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/264#issuecomment-114142748 closing this in favour of re-based and updated PR #508 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: affinitygroup: imp...

2015-06-22 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/510 CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach… …ines when zone is specified You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114465874 @DaanHoogland We already do :). User permissions API is **not affected** of this change however. The API does already return VMs `listVirtualMacines` in

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 @bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, ru

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/513 CLOUDSTACK-8578: implement old behaviour for listing only non-destroy… …ed VMs using state=present Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-24 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/513#discussion_r33126603 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -968,7 +968,11 @@ } if (state != null

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-30 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-144346880 well I need it in 4.5.3. I would suggest we take this fix for now for 4.6 as well and make a proper refactor for 4.7/5.0. --- If your project is set up for it, you

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8848: ensure power state...

2015-10-11 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/922 [4.5] CLOUDSTACK-8848: ensure power state is up to date for missing PowerState handling 1:1 cherry-picks, see #909 You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447 hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP. For a user, it

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454 Yes I see, but the label "IP address" does not indicate that it is the first NIC's IP address :). It might make sense to change the label to be more

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152302053 is 4.5 also affected by this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152939410 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-11-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153425811 agreed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request:

2015-11-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/34fee547cd10025f91e47e5efa6a97a96dd96313#commitcomment-14176906 German is now fully translated --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1042 CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties in /etc/dhcpentries.txt we had: 02:00:1e:07:01:53,set:10_102_92_5,10.102.92.5,songlog-1,infinite 02:00:0b:a2:00:3d,set

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154414891 @ustcweizhou seeing some more potential problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154426348 @remibergsma @ustcweizhou updated and rebased the patch with some more fixes... --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154436021 @remibergsma okay, never mind for false alarm then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-07 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1045 [4.5] CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties in /etc/dhcpentries.txt we had: 02:00:1e:07:01:53,set:10_102_92_5,10.102.92.5,songlog-1,infinite 02:00:0b:a2:00:3d,set

[GitHub] cloudstack pull request: CLOUDSTACK-9043 Remove \n (new line) in G...

2015-11-08 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1043#issuecomment-154861335 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155078020 @remibergsma since this buggy script is still there in master branch we should IMHO either merge this PR or remove the script from master branch. Remove it? --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155082318 ok, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-19 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1045#issuecomment-158030442 Our test case on ACS 4.5.1: # Before fix ## vanilla router deployed: ~~~ # related script ae693b5ef2d9b1fed1307f6b38213823 /opt/cloud/bin

[GitHub] cloudstack pull request: CLOUDSTACK-9042: remove unused edithosts....

2015-11-19 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1093 CLOUDSTACK-9042: remove unused edithosts.sh As discovered in CLOUDSTACK-9042, this script contains some issues but since it was replaced since 4.6, we remove it on master. Also see

[GitHub] cloudstack-www pull request: add swiss txt to cloudstack users

2015-11-20 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack-www/pull/19 add swiss txt to cloudstack users You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack-www patch-1 Alternatively you can

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-20 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1045#issuecomment-158350734 @remibergsma @bhaisaab, no, not yet, created a patch for master before release of 4.6 #1042 but I was told it is not necessary, script is not used, was replaced by a

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160200278 awesome job! can not wait to get it tested. If all is fine, it would be great if it gets into 4.5.3 (/cc @bhaisaab) and 4.6.1 (/cc @remibergsma). I know a

[GitHub] cloudstack pull request: Forgotten license added

2015-11-28 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1137#issuecomment-160339609 GPL?! ...naa just kidding. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-12-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160990441 @pdube good timing, testing it right now. expect feedback today. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-12-02 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-161286193 Code LGTM, not yet tested though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8892:If VR enters out-of band ...

2015-12-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1158#issuecomment-161684501 big -1 We tested out of band migrations on VR on VMware and they work without reboots. A VM/VR does not "loose" the IP just because it get

[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...

2015-12-10 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1093 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-15 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121846292 hey @bhaisaab, still WIP. I ask for some help to finish it on the ML, because I will not have time to work on it the next months. --- If your project is set up for

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121914103 Hi @wilderrodrigues that would be awesome! It is not supposed to break backward compatibility. In my opinion the functionality is implemented and should work

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121931572 @wilderrodrigues yes, please. Feel free. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   >