Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166415534
Nothing out of the ordinairy. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1268#issuecomment-166436287
Code reviewed. Nothing out of the ordinary. LGTM. There must be a better
way to do it than to manually add it to each and every migration though.
---
If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-166675193
Good to see additional tests created. I would suggest adding a test that
turns one of the routers off, and then seeing if the VPN connection works
correctly. I
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48278591
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1260#issuecomment-166691207
Did you try rebuilding CS with each type of event queue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265
How do you know if there are no jobs associated with it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961
Shouldn't we log this information? Doesn't this mean that some resources
could be freed up on the hypervisor?
---
If your project is set up for it, you ca
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1281#issuecomment-166911537
lol @DaanHoogland . +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604
Null check LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49605888
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606475
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606572
--- Diff:
plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java
---
@@ -67,7 +73,28 @@ public
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r49606982
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1300#issuecomment-171666469
Code changes LGTM, looked in the UpdateVpnGatewayCmd and checked the
response name (it is 'updatevpngatewayresponse').
---
If your project is set up for i
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057840
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50057844
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1342#discussion_r50058625
--- Diff: ui/scripts/ui-custom/instanceWizard.js ---
@@ -429,12 +427,52 @@
$step.find('.custom-size-
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50058474
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1337#discussion_r50060205
--- Diff: ui/scripts/network.js ---
@@ -3667,8 +3652,16 @@
return 2;
//hide Autoscale
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1337#issuecomment-172691481
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1135#issuecomment-172710149
@DaanHoogland np, I will close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r50066929
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-172715155
Code LGTM, as a general comment though, I think it is cleaner to be as
precise as possible with exception handling.
---
If your project is set up for it, you can
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259089
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259249
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259430
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule):
def
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50259649
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self):
self.conf.search
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1369#issuecomment-175058378
Versions LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-175089677
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176825081
LGTM Tested with a XenServer host and Swift as secondary storage. Got the
link and downloaded the template
https://cloud.githubusercontent.com/assets/2355044
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-179502626
Tested on local setup, the template.properties is now uploaded correctly
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709296
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,132 @@
+//Licensed to the Apache Software
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709306
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -0,0 +1,132 @@
+//Licensed to the Apache Software
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709314
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r41709319
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java
---
@@ -0,0 +1,147 @@
+//Licensed to the Apache Software
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-147741954
Hey guys,
I have been re-pushing the branch for it to build on Jenkins. It has been
failing, but it doesn't seem to be related to my fixes (it seems like Je
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/951#issuecomment-149214174
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-149215099
Bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150575383
The fix looks like it will work, but it seems like it is just a workaround.
Shouldn't the column be updated correctly instead?
Either in this method o
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/968#issuecomment-150675450
@mike-tutkowski Thanks. That makes more sense now. So concurrent deletions
would still be a problem?
---
If your project is set up for it, you can reply to this
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-151854916
@remibergsma I rebased and repushed. I will take some screen shots later!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/879#issuecomment-152300355
@remibergsma The commit didn't change, I just rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1051#issuecomment-155183148
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157754858
Hey @wilderrodrigues @resmo,
I was looking to fixing this as well. Is there any way I can contribute?
What is the status of this?
Thanks,
pdube
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157854104
@ustcweizhou I have checked it out into another branch. I am working on it.
And will create a PR when I am done.
---
If your project is set up for it, you can reply
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-157874321
@ustcweizhou Also if you have a fix for it, why not port it forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158075714
@ustcweizhou I am working on it now, but have a few questions about
resource ownership
---
If your project is set up for it, you can reply to this email and have
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158200813
Why is that access control done differently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158200709
@ustcweizhou Is that actually necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/508#issuecomment-158434572
@ustcweizhou Thanks for the response. I understand the code. I was
wondering why there was a need for a special access checker for AffinityGroups.
After more
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1129#discussion_r46006607
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -558,7 +558,9 @@ public String
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1129#issuecomment-159993684
LGTM, on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1135
Reducing expunge delay and interval on default dev cfgs
Significantly reduces the time it takes to execute the integration tests
You can merge this pull request into a Git repository by running
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1135#issuecomment-160353791
I will check it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1134#discussion_r46086641
--- Diff: test/integration/component/test_affinity_groups_projects.py ---
@@ -0,0 +1,1083 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-160441642
@DaanHoogland I did not find a guide to do it. I looked at the patterns I
found in other modules, and imitated those. I found it confusing because there
were a few
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-160447903
@DaanHoogland I was talking about the implementation of APIs. Example,
let's say you create a new module, call it Exampe. So we can list, create and
delete Ex
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-160638862
@DaanHoogland Ok, I understand what you mean. I do think that we need some
clarifications on what the standards are (search vs list, service vs query vs
dao, etc
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160674157
LGTM, but consider using the default log4j formatter. ex:
`logger.debug("Ping from {} ({})", hostid, hostname);`
and extracting the message to
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160684591
@wido :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1138#discussion_r46184167
--- Diff: client/WEB-INF/classes/resources/messages_fr_FR.properties ---
@@ -1739,7 +1740,7 @@ message.action.enable.nexusVswitch=Confirmer
l\\'activ
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160720589
Suggested a small french change, but still LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1138#issuecomment-160721861
@remibergsma Fine with me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1144#issuecomment-160739865
Hey @ustcweizhou, could you create the PR towards 4.6 please, it is hard to
determine exactly what you changed. Thanks
---
If your project is set up for it, you can
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46204918
--- Diff: tools/build/build_asf.sh ---
@@ -101,6 +101,11 @@ perl -pi -e "s/-SNAPSHOT//" build/replace.properties
perl -pi -e "s/-SNAPS
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1146#discussion_r46204974
--- Diff: tools/build/build_asf.sh ---
@@ -123,11 +128,7 @@ git clean -f
#create a RC branch
RELEASE_BRANCH="RC"`date +%
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/commit/7d7420fd1e5908e1bc4ee04a314241212f7a6481#commitcomment-14693674
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1146#issuecomment-160765582
Ok then, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-160978139
@resmo @ustcweizhou @remibergsma Any news on testing? LGTY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1134#discussion_r46553780
--- Diff:
server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java ---
@@ -229,59 +205,99 @@ public AffinityGroupVO
doInTransaction
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1153#issuecomment-161650382
Isn't the project inferred from the instance? The
[CreateVmSnapshot](http://cloudstack.apache.org/docs/api/apidocs-4.6/root_admin/createVMSnapshot.html)
API do
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-161657343
Hey guys, there are enough LGTMs, can we get this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1134#issuecomment-161775836
@remibergsma awesome :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1173#discussion_r46685020
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -1,32 +0,0 @@
--- Licensed to the Apache Software Foundation (ASF) under one
--- or more
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1153#issuecomment-161978474
@nitt10prashant No problemo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1173#issuecomment-161987586
LGTM by code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/875
Fixed box location on vagrant files
The centos-6.5 is no longer available
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdube/cloudstack
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/875#issuecomment-142596258
Thank you @pdion891 @karuturi. Fixed in the last commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142601843
This looks good, but does this have an impact elsewhere? Did you test
listing vms by user_id?
---
If your project is set up for it, you can reply to this email and
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/878#issuecomment-142606607
@borisroman True, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/879
CLOUDSTACK-8793 Enable s2s VPN connection for projects
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdube/cloudstack CLOUDSTACK-8793
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-142936013
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user pdube opened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1581#discussion_r65701961
--- Diff:
core/test/com/cloud/agent/api/routing/SetNetworkACLCommandTest.java ---
@@ -0,0 +1,34 @@
+package com.cloud.agent.api.routing;
--- End
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube Travis timed out, you may want to try the Travis Lottery again ;-)
Is this ready for testing?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@remibergsma Yes, the rules should appear in the right order now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
The Travis build has timed out 3 times now. Is there any known issue with
Travis right now @swill ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
Github user pdube commented on the issue:
https://github.com/apache/cloudstack/pull/1581
Thanks @dmabry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user pdube closed the pull request at:
https://github.com/apache/cloudstack/pull/1581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
GitHub user pdube reopened a pull request:
https://github.com/apache/cloudstack/pull/1581
CLOUDSTACK-9404 Fixed ordering of network ACL rules being sent to the VR.
The comparator was inverted.
Issue: https://issues.apache.org/jira/browse/CLOUDSTACK-9404
In this
1 - 100 of 154 matches
Mail list logo
