Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1129#discussion_r46006607
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -558,7 +558,9 @@ public String downloadPublicTemplate(long id, String
url, String name, ImageForm
ResourceType.TEMPLATE == resourceType ?
_storage.getFile(tmpDir + File.separator + TemplateLocation.Filename) :
_storage.getFile(tmpDir + File.separator +
"volume.properties");
if (file.exists()) {
- file.delete();
+ if(! file.delete()) {
+ s_logger.warn("delete of file '" +
file.getAbsolutePath() + "' failed.");
--- End diff --
Deletion*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
