Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele
> What is the reason to try fencing off VMs when the MS is not able to
determine its state? I cannot see a good reason so far but you seem to think
there is at le
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r76588109
--- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
---
@@ -199,4 +207,20 @@ public boolean isRevertable() {
public
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1606
@leprechau You may add an unit test as well for
NetUtils.validateGuestCidr(). Check NetUtilsTest.java, there is already an
existing test for 192.168.
---
If your project is set up for it
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1618
Please add/modify Marvin tests based on these scenarios.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r76588305
--- Diff: api/src/org/apache/cloudstack/api/response/SnapshotResponse.java
---
@@ -102,6 +102,14 @@
@Param(description = "indicates wh
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1622#discussion_r76588913
--- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java
---
@@ -169,6 +169,10 @@
@Param(description = "additiona
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1622#discussion_r76589032
--- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java
---
@@ -347,4 +351,11 @@ public String getZoneId() {
return
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1586
code change LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
August 2016 at 4:23 PM
To: "dev@cloudstack.apache.org"
Cc: Rajani Karuturi , Raja Pullela
, Koushik Das
Subject: Few tables in cloudstack schema use MyISAM engine
Hi,
Was there any specific reason that some tables in cloudstack schema use
MyISAM engine.
I know of “ quota_accou
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1670#discussion_r77118387
--- Diff: setup/db/db/schema-490to491.sql ---
@@ -23,3 +23,11 @@
UPDATE `cloud`.`roles` SET `description`='Default user role' WHERE `
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez @serg38 From last comment looks like there is some open item
related to marvin tests. Can you please address it?
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski Thanks for adding marvin tests. Some observations regarding
the tests.
I see that you have put the tests under solidfire folder. Currently is
solidfire the only managed
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@abhinandanprateek In latest master the sequence of event described above
only happens when the host has been determined as 'Down'. Refer to the below
code. So the bug descr
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r79357165
--- Diff: test/integration/smoke/test_ssvm.py ---
@@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self):
# Call to verify cloud process
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Yes LGTM from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
I think that it is better to sort out the CI stuff for validating PRs before
moving ahead with the next release.
There was a recent mail from Bharat on a sample CI BVT run. As I understand it
is still WIP, but once the remaining items are fixed it will be useful for
validating PRs.
Also I can b
you have comments or concerns.
I will not be working alone, I will be assisted by Koushik Das and Patrick
Dube. I will be running point, but all three of us will be working
together as a unit for this release.
Our main focus for this release is the integration of hardware Continuous
Integration
Hi Rohit,
Host maintenance is already there to address the use cases mentioned. What
additional value would this feature add? Also if it is just providing the IPMI
based operations then it is only limited to the hosts already added to CS, what
about new hosts not added in CS? What if host IP/n
related companies. If you are not the
intended recipient of this email, you must neither take any action based upon
its contents, nor copy or show it to anyone. Please contact the sender if you
believe you have received this email in error.
On 03-Mar-2016, at 2:38 PM, Koush
+1 for the move to apache-cloudstack/cloudstack
From: Will Stevens
Sent: Saturday, March 19, 2016 4:14 AM
To: dev@cloudstack.apache.org
Subject: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'
We are discussing this proposal in 3 or 4 th
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-199189395
@bvbharat Can you run the tests on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-199189940
Need one more LGTM, anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-199254175
@DaanHoogland I don't see any reason for closing master in this case. If an
issue is noticed after a merge, it definitely needs to be tracked and
The idea looks good. I have provided some questions/comments on the FS itself.
Thanks,
Koushik
From: Rohit Yadav
Sent: Wednesday, March 23, 2016 10:34 PM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: [DISCUSS] Request for comments
ds,
Rohit Yadav
rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue
-Original Message-----
From: Koushik Das [mailto:koushik@accelerite.com]
Sent: Friday, March 25, 2016 1:34 PM
To: dev@cloudstack.apache.org; us...@cloudstack.apache.o
Please file tracking bugs for all such issues
From: Sanjeev Neelarapu
Sent: Tuesday, March 29, 2016 2:29 PM
To: dev@cloudstack.apache.org
Subject: Hard coded test data
Hi,
Some of the tests have hard coded test data inside tests and due to this some
of the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206221768
+1 based on the code review (reverts 2 commits) and based on the test
results posted by @bvbharatk (no failed tests).
Since existing functionality got
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58671820
--- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java
---
@@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58672156
--- Diff:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
---
@@ -521,6 +522,76
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1357#issuecomment-206245883
@bvbharatk Looks like test_01_vpc_privategw_acl has been failing for
sometime based on the report. Should this be moved to the list of known test
issues
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-206250177
+1 for code changes and based on the test report from @bvbharatk.
Since the changes are specific to VMware and the test results are for XS,
not sure how to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206461710
@swill As mentioned by @ustcweizhou in the first comment. I am not sure if
the current scale VM tests cover the dynamic offering scenario.
"
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58874658
--- Diff:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
---
@@ -521,6 +522,76
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r58875609
--- Diff: server/test/com/cloud/consoleproxy/ConsoleProxyManagerTest.java
---
@@ -87,4 +114,136 @@ public void testExisingCPVMStartFailure() throws
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-208405525
How about suppressing the findbug issue (using something like
@SuppressWarnings) till someone comes up with a proper fix? In that case there
won't be any
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59231793
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59233185
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-208431289
+1 based on code review and test results posted by @bvbharatk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-208475514
@jburwell I am not saying FindBugs issues should be suppressed in general.
As part of fixing FindBugs issues some functionality got regressed (refer PR
heading
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-209830019
@ProjectMoon On latest master during VM deployment no VOLUME.CREATE is
getting generated for ROOT volume. Also during destroy there is no
VOLUME.DELETE event
Based on the namespace log level can be set. It needs to be configured in the
log4j.
Check client/tomcatconf/log4j-cloud.xml.in in the source code and you will get
an idea.
-Koushik
From: williamstev...@gmail.com on behalf of Will
Stevens
Sent: Thursd
Are these the names that are sent to HV? For e.g. VM name in the format
i-xx-yy-VM. Currently there are functionalities that rely on the internal
naming convention. All such functionalities needs to be handled appropriately.
-Koushik
From: Jeff Hair
Sen
't in the commit yet.
We will put it in.
It would be useful to have a list of all the places that rely on the
internal naming convention. security_groups.py and friends is the only one
i know of off the top of my head.
On Thu, Apr 14, 2016 at 4:01 PM, Koushik Das
wrote:
> Are these the n
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-211859221
The changes are only limited to UI, so there is no need to run
smoke/integration tests.
Cursory look at the changes looks fine.
@swill I think these
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1375#issuecomment-211860481
@swill Again UI changes related to l10n. I think these can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-211860607
@swill Again UI changes related to l10n. I think these can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211864757
Merging as UI change and 2 LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-21190
@nitin-maharana Looks like there is some problem. In confirmation dialog
when I click "yes" nothing happens and on clicking "no" the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211943539
@swill I didn't fwd merge into 4.8 and master. Are we fwd merging for every
individual commit in order to avoid conflicts?
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-211954088
@swill I wanted to understand if it is ok to do these fwd merges once every
week/fortnight (based on number of commits that went into the release branch)
or do
Another way to look at it would be to make isolated network a special case of
VPC (having a single tier).
-Koushik
From: Nick LIVENS
Sent: Tuesday, April 19, 2016 2:46 PM
To: dev@cloudstack.apache.org
Subject: [DISCUSS] Network offerings for Isolated Net
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-212265582
@nvazquez Can you add integration tests for all these APIs? Checkout
test_deploy_vm_multiple test in test/integration/smoke/test_vm_life_cycle.py
---
If your
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60352254
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212267285
@dmabry Thanks for the fix. I ran it on simulator and it worked as
expected. So +1 on the changes. Although it existed for XenServer and Vmware, I
am trying to
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60355293
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60356809
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60357104
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60358060
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60365855
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60383218
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60384825
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60389152
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60399552
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-212753295
@pdion891 This wasn't tested with HVM VMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212776381
@swill This has 2 LGTMs and also CI results. The failures are unrelated as
this PR only adds new test cases and no product code changes. This can be
merged
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1399#issuecomment-212777880
LGTM - Verified on 4.7 that the dropdown shows http option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1398#issuecomment-212779591
LGTM - verified on 4.7 that alignment is proper
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212832800
@priyankparihar This version check removal is at a generic place and impact
all HVs. Since you have only verified for XS 6.2 -> 6.5, there are concerns as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1308#issuecomment-212842361
@swill This is a test only PR. 2 LGTMs are there and the CI failures are
unrelated to the changes. This can be merged.
---
If your project is set up for it
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-212853751
@shwetaag @swill As I understand from @sanju1010 comment, the script is
used to automate creation of dc, cluster and hosts in vCenter. The setup
created can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-212868899
@nitin-maharana I checked the discussions on #823 as well. Looks like it is
best to remove all tag checks for selecting offering. Also there is no usage
impact
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-212870271
@swill This is ready for merge, has the required LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
As per the build logs RAT is failing. Not sure from where this file is getting
picked up.
Unapproved licenses:
utils/testsmallfileinactive
***
From: Will Stevens
Sent: Thursday, April 21, 2016 5:27 PM
To: dev@cloudstack.ap
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60570949
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-213693730
I did some basic tests yesterday. Some comments based on that. Will do some
more testing next week.
- I see that commands.properties is removed altogether
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-214204041
@nitin-maharana The second dialog is not going away after clicking "yes"
even though the API call is issued with forced=true. I don't think th
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-214208033
@priyankparihar Are you saying that you have tested the fix in all
scenarios with different HVs (XS, KVM, Vmware)? Also if HV doesn't allow
certain opera
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214269005
@rhtyd Have you ran the tests using a regular user? As per dynamic checker
code, for root admin all checks are bypassed. I think a good comparison will be
to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214296336
@rhtyd My comment regarding the test was more in the context of perf. test.
In the DB for regular user I saw ~250 permissions got created. So this means
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214707925
>>Consider this an admin creates a read-only admin role and accounts with
that (such users can only do list* calls), now if they go back to
static-check
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214728007
@rhtyd I think you still didn't get my point. Read the comment again. I
would like to see the option for using command.properties available for both
ne
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215008749
>>That is to say that the API permissions on a fresh install before and
after this is merged should behave the same out of the box. If that's the c
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1517#issuecomment-215017916
Code changes LGTM.
@swill The change is in upgrade code and CI won't be able to test it. So I
think this can be merged.
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-215026662
Code changes LGTM, verified changes in HighAvailabilityManagerImpl.java.
Someone else needs to verify KVM related changes.
---
If your project is set up for
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1517#issuecomment-215038164
@rhtyd Thats right, setup will anyway do the upgrades.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-215070344
LGTM. Verified on a simulator setup. Also the test failures from CI run are
unrelated to this change.
---
If your project is set up for it, you can reply to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-215325140
@kishankavala The changes needs to be moved to the latest sql upgrade files.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1257#issuecomment-215326963
@sureshanaparti There are some open items, please address them
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1252#issuecomment-215327572
@sureshanaparti There are some comments, please address them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1270#issuecomment-215348912
Changes LGTM. UI changes so CI results doesn't matter.
@anshul1886 From the fix looks like applicable to all browsers, is that
correct?
---
If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1282#issuecomment-215350146
@anshul1886 The fix is only for XS snapshots. What about other HVs?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-215364487
Changes LGTM.
@swill This can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-215365287
@SudharmaJain Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/928#issuecomment-215366187
@karuturi Any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/927#issuecomment-215366546
@karuturi Any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215372191
LGTM. Had already given one earlier based on simulator testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-215389142
+1 on the feature. Based on testing done on the simulator with root admin
and normal user for a few APIs
+0 on the immediate removal of command.properties
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1522#issuecomment-215407693
LGTM. Verified in api.log that job id is getting appended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r61844330
--- Diff: server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java ---
@@ -205,14 +205,21 @@ public UserVmResponse newUserVmResponse(ResponseView
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1466#discussion_r61992331
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -413,3 +413,26 @@ VIEW `user_vm_view` AS
-- Add cluster.storage.operations.exclude
701 - 800 of 926 matches
Mail list logo
