Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-213693730
I did some basic tests yesterday. Some comments based on that. Will do some
more testing next week.
- I see that commands.properties is removed altogether and the data
migrated to DB. What are the perf. implications for this even when using the
static checker? Earlier the contents were read from file on MS startup and
stored in memory as hash map, now for every API call there is a DB query for
access check.
- Since the data is automatically migrated from commands.properties file to
DB (in new format), how are you ensuring that the data consistency is
maintained?
- For dev setup, dynamic roles configuration is enabled. I was able to
perform operations using dynamic role checker. But when I switched back to
static role checker things stopped working. It wasn't allowing me to login from
UI. Can you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---