Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726623
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkDomainToLdapCmd.java
---
@@ -0,0 +1,114
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38726691
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -243,4 +263,22 @@ public boolean isLdapEnabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/755#discussion_r38727056
--- Diff: server/src/com/cloud/user/AccountManagerImpl.java ---
@@ -2177,6 +2173,7 @@ private UserAccount getUserAccount(String username,
String
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/755#issuecomment-137664209
LGTM based on the tracking bugs for addressing some of the issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/773#issuecomment-138493272
Looks like this has broken regular isolated network. VR is not going to
'up' state as SSH is failing on the link local ip. The order of the interfaces
I am also seeing this issue
https://issues.apache.org/jira/browse/CLOUDSTACK-8823. This is a blocker for
regular isolated network as VR is not coming to 'up' state due to ssh failure.
-Original Message-
From: Bharat Kumar [mailto:bharat.ku...@citrix.com]
Sent: Thursday, 3 September 20
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/792
CLOUDSTACK-8826: XenServer - Use device id passed as part of attach vâ¦
â¦olume API properly
If device id passed as part of API and available then use it otherwise
fallback on XS
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-138819369
I had to undo changes from PR https://github.com/apache/cloudstack/pull/773
to run the tests.
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138846797
I tested the patch, now isolated network VR is coming up and the interfaces
are configured in correct order.
eth0 - guest
eth1 - link local
eth2
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/788#discussion_r39025559
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -610,20 +608,22 @@ protected HypervisorType
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138861606
Other than one minor comment, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/788#issuecomment-138865017
One more doubt. Why the ordering of interfaces are different in regular VR
and VPC VR? Has it changed recently or was like this since the beginning? And
will it
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-140317652
Can anyone review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39827592
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/829#issuecomment-141377920
-1 to this PR as I am not able to follow how the change is related to the
bug. Also this is going to impact any HV having VM changes outside of CS like
Vmware
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/829#issuecomment-141418450
@DaanHoogland As per logs attached in bug VR reboot happened due to
out-of-band movement from one host to another and not due to power report
missing
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-141620583
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/792#discussion_r39962919
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3407,6 +3390,18 @@ public void
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-142173025
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/860#issuecomment-142174642
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/792#issuecomment-142236155
Merging as 2 LGTMs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40532523
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -1999,7 +1999,9 @@
// StatsCollector
StatsOutPutGraphiteHost
Cloudstack relies on custom HA logic for user VMs running on Xenserver. The
reason for doing it like this may be due the fact that native HA capabilities
in XS was not mature enough during the initial days. Also in the custom HA
logic, Cloudstack has to correctly determine the state of a VM from
Initial draft of the FS
https://cwiki.apache.org/confluence/display/CLOUDSTACK/User+VM+HA+using+native+XS+HA+capabilities
-Koushik
On 21-Nov-2013, at 9:59 AM, Koushik Das wrote:
> Cloudstack relies on custom HA logic for user VMs running on Xenserver. The
> reason for doing it like th
c and not let it fall into disrepair.
[Koushik] That's the plan going forward. For the next release both options will
be there. Maybe post that the custom HA solution can be removed for XS 6.2 and
above.
>
> --David
>
> On Fri, Nov 22, 2013 at 7:27 AM, Koushik Das wrote
ecc
- Koushik Das
On Nov. 26, 2013, 8:42 a.m., bharat kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15505/
> ---
762
- Koushik Das
On Nov. 26, 2013, 11:28 a.m., Harikrishna Patnala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
> On Nov. 26, 2013, 9:12 a.m., Koushik Das wrote:
> > master -> ef40e156ed376968fa9fd15078034d54b97deecc
4.3 -> 6af8021ef7188b8f2d92bc891b5108f0e3503284
- Koushik
---
This is an automatically generated e-mail. To repl
> On Nov. 26, 2013, 11:58 a.m., Koushik Das wrote:
> > master -> b2f0a0bce26e342f18da42a51ae19d51c238a762
4.3 -> 8970c9515441c50a0249b9624b120d4e5348b5af
- Koushik
---
This is an automatically generated e-mail. To repl
ew followup comments inline. I look forward
>> to seeing this work.
>>
>> Other folks: please read the entire thread and the links from Koushik;
>> there's a planned deprecation here.
>>
>> --David
>>
>> On Mon, Nov 25, 2013 at 2:38 AM, Koush
ap cannot be null
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56781>
Put some comment to explain the logic
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/15832/#comment56784>
I see the usage event publishin
egarding this. I generally don't think VM
HA can be done with hypervisor HA because of this.
--Alex
-Original Message-
From: Koushik Das [mailto:koushik@citrix.com<http://citrix.com>]
Sent: Tuesday, November 26, 2013 10:51 PM
To: mailto:dev@cloudstack.apache.org>>
Sub
514
- Koushik Das
On Nov. 29, 2013, 7:46 a.m., bharat kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15832/
> ---
3f8
- Koushik Das
On Nov. 29, 2013, 12:35 p.m., bharat kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15832/
> ---
For using system VMs on local storage there is a global setting
system.vm.use.local.storage which needs to be set to true.
-Koushik
On 29-Nov-2013, at 7:47 PM, Antonio Petrocelli wrote:
> Hello,
>
> we want use cloudstack 4.2 with local storage + VMware 5.1.
>
> https://cloudstack.apache.org
s to be updated in VirtualMachineManager.java
where ExecuteInSequence is defined.
- Koushik Das
On Nov. 21, 2013, 6:39 p.m., Alex Ough wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
I have posted my review comments. Except for a few minor comments changes look
good to me.
-Koushik
On 02-Dec-2013, at 9:15 PM, Alex Ough wrote:
> All,
>
> It's been a while since this review was requested, so can anyone review
> this to move on?
>
> Thanks in advance.
> Alex Ough
>
>
> On
> On Dec. 3, 2013, 8:44 a.m., Koushik Das wrote:
> > core/src/com/cloud/agent/api/MigrateCommand.java, line 32
> > <https://reviews.apache.org/r/15763/diff/1/?file=389559#file389559line32>
> >
> > I see that you have tested for XS. In the mail thread people h
showing up. Also
there are 2 commits in the patch file. Can you resubmit the patch with only a
single commit?
- Koushik Das
On Dec. 3, 2013, 5:07 p.m., Alex Ough wrote:
>
> ---
> This is an automatically generated e-mail. To rep
evious incorrect one, but I couldn't
find how.
So let me know if it is better to discard this review and create a new one.
Thanks
Alex Ough
On Wed, Dec 4, 2013 at 12:04 AM, Koushik Das
mailto:koushik@citrix.com>> wrote:
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15763/#review29870
---
Ship it!
Ship It!
- Koushik Das
On Dec. 5, 2013, 3:28 p.m
> On Dec. 6, 2013, 4:19 a.m., Koushik Das wrote:
> > Ship It!
master -> 88f64b2b93a3898e7868e9e55c1feca57b2ed48e
- Koushik
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15763/
I see that for XS the location of script files in the host has changed from
/opt/xensource/bin to /opt/cloud/bin. On latest master branch I see that the
scripts are still getting placed in the old location while adding a host. Is
there any commit missed out on master?
-Koushik
On 10-Dec-2013,
g/r/16129/#comment57658>
In an existing 4.2/master setup I see that the component of both
vmsnapshot.create.wait and vmsnapshot.max is set to none.
Handle this scenario as well.
- Koushik Das
On Dec. 9, 2013, 1:17 p.m., Harikrishna Patnala
b54
- Koushik Das
On Dec. 10, 2013, 10:55 a.m., Harikrishna Patnala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
I see that both the VOs uses the same vm_instance table. What is the need for
having 2 VOs for the same table? Should one be removed?
Also VMEntityVO I see a field called "speed" which is not there in
VMInstanceVO. Why this discrepancy?
Thanks,
Koushik
Prachi, From the history I see that you added VMEntityVO. Any specific reason
for having both?
On 12-Dec-2013, at 2:36 PM, Koushik Das wrote:
> I see that both the VOs uses the same vm_instance table. What is the need for
> having 2 VOs for the same table? Should one be removed?
Manager.java
- Koushik Das
On Dec. 17, 2013, 9:38 a.m., bharat kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tities for which this has been done so far, Alex has
> put everything under cloud-engine-schema recently where you can find some
> more of such examples.
>
> Prachi
>
> -Original Message-
> From: Koushik Das
> Sent: Sunday, December 15, 2013 9:50 PM
> To:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16315/#review30529
---
Ship it!
Ship It!
- Koushik Das
On Dec. 17, 2013, 11:58 a.m
For now I have removed cpu, ram and cpu speed fields from vm_instance table.
On 18-Dec-2013, at 6:22 AM, Prachi Damle wrote:
> Koushik,
>
> My comments inline.
>
> Prachi
> -Original Message-----
> From: Koushik Das
> Sent: Tuesday, December 17, 2013 4:
323
- Koushik Das
On Dec. 19, 2013, 10:43 a.m., Damodar Reddy Talakanti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
pache.org/r/16350/
> ---
>
> (Updated Dec. 19, 2013, 10:43 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
>
> https://issues.apache.org/jira/browse/https://issues.apache.
What is the account creation logic on Solidfire SAN if you try to create the
same simultaneously? I am assuming there should be some unique constraint like
account name/id etc. Try to see if this can be utilised so that one of the
account creation call fails with appropriate error/exception.
-K
Yes that is the current behaviour. All hosts in a cluster should be owned by a
single MS. In case when agent load balancing is enabled (agent.lb is set to
true), this constraint no longer holds and the hosts in a cluster may get split
across multiple MS.
If you look at the 'host' table there is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16566/#review31029
---
Ship it!
Ship It!
- Koushik Das
On Jan. 2, 2014, 10:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16566/#review31030
---
Patch doesn't apply on master.
- Koushik Das
On Jan. 2, 201
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16602/#review31120
---
Ship it!
Ship It!
- Koushik Das
On Jan. 3, 2014, 10:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16732/#review31367
---
Ship it!
Ship It!
- Koushik Das
On Jan. 8, 2014, 9:43 a.m
eorganize as below
if (currentServiceOffering.isDynamic()) {
if (newServiceOffering.isDynamic()) {
saveCustomOfferingDetails(vmId, newServiceOffering);
} else {
removeCustomOfferingDetails(vmId);
}
}
- Koushik Das
On Jan. 10, 2014, 6:33 a.m.,
I am also seeing the same failure happening randomly. OS X El Capitan 10.11.4.
Results :
Tests in error:
NioTest.testConnection:152 » TestTimedOut test timed out after 6
milliseco...
Tests run: 200, Failures: 0, Errors: 1, Skipped: 13
From: Tutko
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219400690
@rhtyd While the change looks simple, what happens in case there are say >
1K hosts, > 10K VMs with this fix?
---
If your project is set up for it, y
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63494164
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219692208
@nvazquez I am not too familiar with the VMware specific code, rest of the
code looks ok.
Also a comment on #1361 when this feature was initially added
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-219696525
@anshul1886 @anshulgangwar Can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655061
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655432
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219945994
@DaanHoogland Not able to see diffs for NetscalerResource.java, are the
changes mostly related to adding 'final' keyword? Provided some comments, re
GitHub user koushik-das reopened a pull request:
https://github.com/apache/cloudstack/pull/1251
CLOUDSTACK-9180: Optimize concurrent VM deployment operation on same â¦
â¦network
Check if VR needs to be allocated for a given network and only acquire lock
if required
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/1251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63828871
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse createCertResponse
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63829633
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain
Congrats Will
And thanks Sebastien
-Koushik
On 19/05/16, 12:26 PM, "Sebastien Goasguen" wrote:
>Morning Everyone,
>
>Yesterday at the ASF board meeting, the board passed the resolution making
>Will Stevens the new Vice President of the Apache CloudStack project.
>
>Join me in congratulating Wi
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220558485
@swill The failures are not related to this PR.
The failure in test_internal_lb.py is due to some cleanup issue. The
network deletion failed most probably
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-220562852
@nvazquez Thanks for the fix. As @DaanHoogland mentioned please add license
header to the newly added file.
---
If your project is set up for it, you can
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r64015658
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-220615109
@swill nothing outstanding on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1556#issuecomment-221202485
Simple changes. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -19,173 +19,43
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221218765
LGTM. In some of the *Command.java and *Annswer.java classes, simple member
types has been replaced with types defined in the Nuage VSP library. As long as
all
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1561#issuecomment-221821063
Simple change. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222104760
Changes LGTM. Now the expected ping response can be configured in test_data
based on OS type.
@nitt10prashant Please post the test execution result
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222643203
Thanks @nitt10prashant for the making the changes. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73114913
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDaoImpl.java
---
@@ -16,7 +16,7 @@
* specific language
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73118216
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73118335
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73118447
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailVO.java
---
@@ -23,61 +23,61 @@
import
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73281219
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDaoImpl.java
---
@@ -16,7 +16,7 @@
* specific language
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73283060
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1615
LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1611#discussion_r75071072
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId,
vmwareDc=None
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele Can you share the MS logs for this issue? We need to understand
the exact cause for restart of VM? When an agent/host is detected as 'Down', CS
tries to check if VMs
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele Based on the initial few lines of the logs the agent went to
Alert state.
srv02 2016-08-08 11:56:03,895 DEBUG [agent.manager.AgentManagerImpl]
(AgentTaskPool-16:ctx
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
Please use a proper ACS release for reporting bugs. In your case you may
have to do some additional cherry-picks.
"Schedule restart" does multiple tasks. There is a meth
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus Shouldn't the product code be fixed instead of the test? If the
isDefault property on VPC offerings in not working then that needs to be fixed.
I checked the vpc_offerings
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@PaulAngus Refer to #1563. In that PR it was mentioned that ping response
varies based on OS. So hard coding based on some specific environment is not
the right way to fix this.
---
If
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@jburwell The issue that has been reported is on a custom branch, probably
@marcaurele needs to cherry-pick some additional commits from ACS. Master/4.9
doesn't have this issue, so in
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1640
Also since the automated test coverage of this area is less, changes should
be made after taking into account all possible scenarios. Otherwise there might
be regressions in some valid
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1652
There should be only one default VPC offering, unless I am missing out
something obvious :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1651
@rhtyd Please go through #1563 as mentioned in my previous comment to get
the context. As @serg38 also mentioned the response differs between debian and
centos which needs to be addressed
601 - 700 of 926 matches
Mail list logo
