----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16350/#review30691 -----------------------------------------------------------
Patch doesn't apply on master. Please upload a new one. - Koushik Das On Dec. 19, 2013, 10:43 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16350/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 10:43 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457 > > > Repository: cloudstack-git > > > Description > ------- > > Due to changes in underlying DAO layer to re throw exceptionsback to the > caller DB HA functionality is broken as MS is going down if master is down > and salve is up. Fixed this by catching exceptions in ClusterManagerImpl and > take decision based on it. > > > Diffs > ----- > > framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95 > > Diff: https://reviews.apache.org/r/16350/diff/ > > > Testing > ------- > > Testing is done in the following use cases > 1. With db ha not enabled > 2. with db ha enabled and > - Shut down Master > - Shut down slave > 3. With db ha enabled > - shut down 2nd db > - shot down 1st db > 4. with dbha enabled > - shut down 1st db > - up the 1st db > - shut down 2nd db > - shut down 1 st db > > > Thanks, > > Damodar Reddy Talakanti > >
