096
- Koushik Das
On Aug. 20, 2014, 11:38 a.m., Harikrishna Patnala wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa
This is the erring commit
commit c730bc3491f8b684c5ae51e0bff54cf7577cc246
Author: Rohit Yadav
Date: Mon Sep 1 21:14:13 2014 +0200
server: Add event bus bean as commented xml in META-INF core
This adds a spring bean xml to have EventBus for ACS, but the bean is
commented
so th
Are the tests present under test/integration/smoke/misc also getting executed?
If so please exclude them for now.
The tests under /misc folder is based on the new simulator changes to test
failures from agent layer. These tests can cause interference in other tests.
There are 2 options to make t
t: Re: simulator run
Hey,
This is what i'm executing to run the tests:
/usr/local/bin/nosetests-2.7 -v --with-marvin
--marvin-config=setup/dev/advanced.cfg --with-xunit --xunit-file=xunit.xml -a
tags=advanced,required_hardware=false --zone=Sandbox-simulator
--hypervisor=simulator -w test
chance of getting a list of tests that are valid for execution against the
simulator for 4.3, 4.4 and master?
Thanks,
Ian
On 4 September 2014 13:03, Koushik Das wrote:
> Ok, in that case the tests under /misc won't get executed. Looks like
> there are some other issues with the fai
tps://reviews.apache.org/r/25430/#comment91419>
In the prvious line, service offering is getting set, why set it again?
Since there is a way to pass offering in ctor, is an explicit setter
really required?
- Koushik Das
On Sept. 8, 2014, 9:16 a.m., bharat kumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26168/#review55964
---
- Koushik Das
On Oct. 9, 2014, 6:26 a.m., Damodar Reddy Talakanti
Somehow the review comments are not showing?
1. Would it make sense to make the pre/post method signature identical?
2. In StateEntry.addTransition(), do you need E and S as separate
parameters?
From: Koushik Das [mailto:nore...@reviews.apache.org] On Behalf Of Koushik Das
Sent
Congrats Rajani!
On 17-Oct-2014, at 3:51 PM, Daan Hoogland wrote:
> The Project Management Committee (PMC) for Apache CloudStack are pleased to
> announce that Rajani Karuturi has accepted our invitation to join the PMC.
>
> Please join me in congratulating her.
>
> On behalf of the Apache Clo
There is another config 'job.cancel.threshold.minutes' (defaulted to 60 mins)
based on which async job is forcefully cancelled. Can you check if this is
cancelling the job?
Also if you want to debug - checkout the GC code present in
AsyncJobManagerImpl.java
-Koushik
-Original Message-
Currently it is not possible to configure system VMs to use local storage on a
per zone basis. Since it is a global config (system.vm.use.local.storage),
either it is enabled for all zones or none. The idea is to make it a zone level
config.
The current zone level setting of 'enabling local stor
> So, it is already implemented.
>
> Please give me 12 hours to send a code snippet... I'm replying from my phone
> now.
>
> Cheers,
> Wilder
>
> Sent from my iPhone
>
>> On 27 Feb 2015, at 14:21, Rohit Yadav wrote:
>>
>> Sounds good, g
Congrats Wilder!
On 01-Mar-2015, at 3:44 PM, Daan Hoogland wrote:
> The Project Management Committee (PMC) for Apache CloudStack
> has asked Wilder Rodrigues to become a committer and we are pleased to
> announce that he has accepted.
>
> Keep up the good work and your contagious good spirit Wi
to the message we get when we select the local storage
> option, but it works.
>
> If when creating a zone you select local storage but on the global settings
> local storage is false, it will respect the selection per zone.
>
> So, it is already implemented.
>
> Please give
Based on the discussion [1], I have created a FS [2] and tracking bug [3].
Please review and provide your comments.
-Koushik
[1]
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201502.mbox/%3cad8a3382-cfc6-4fd3-92de-df61f5a8e...@citrix.com%3e
[2]
https://cwiki.apache.org/confluence/dis
Congrats Hari!
-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org]
Sent: Tuesday, 10 March 2015 11:00
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New committer: Harikrishna Patnala
The Project Management Committee (PMC) for Apache CloudStack has asked
Harikrishna P
This is another alternate https://coreos.com/using-coreos/containers/. CS needs
to support CoreOS.
-Original Message-
From: Diwas Joshi [mailto:dj.dij...@gmail.com]
Sent: Monday, 16 March 2015 2:53
To: dev@cloudstack.apache.org
Subject: [DISCUSS] Support Docker as a hypervisor in CloudSt
Congrats Karen!
On 20-Mar-2015, at 3:37 AM, Pierre-Luc Dion wrote:
> The Project Management Committee (PMC) for Apache CloudStack
> has asked Karen Vuong to become a committer and we are pleased to
> announce that she have accepted.
>
> Karen is doing a huge effort on promoting CloudStack and o
Congrats Sebastien and thanks Hugo!
-Original Message-
From: Giles Sirett [mailto:giles.sir...@shapeblue.com]
Sent: Monday, 23 March 2015 17:11
To: dev@cloudstack.apache.org; us...@cloudstack.apache.org;
market...@cloudstack.apache.org
Subject: [Announce] - New VP Apache Cloudstack
All
Congrats Rohit!
-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com]
Sent: Friday, 27 March 2015 13:38
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] Rohit Yadav as new PMC member of CloudStack
The Project Management Committee (PMC) for Apache CloudStack are pleased t
Congrats Pierre-Yves!
-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: Wednesday, 1 April 2015 2:41
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New committer Pierre-Yves Ritschard
The Project Management Committee (PMC) for Apache CloudStack has asked
Pierre-Yves Ris
Congrats Rene!
-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: Wednesday, 1 April 2015 2:43
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New committer: Rene Moser
The Project Management Committee (PMC) for Apache CloudStack has asked Rene
Moser to become a committer
+1
-Koushik
On 05-Apr-2015, at 2:44 PM, Ian Duffy wrote:
> Hi All,
>
> As stated in a previous thread [1], myself, Sebastien and Darren are
> proposing the donation of ec2stack [2].
>
> I would like to call a vote, so that we have formal consensus on
> accepting the code into the project. I s
After you have run deployDataCenter.py, it is possible to do VM/volume/network
related operations from UI.
From: Jeronimo Garcia [mailto:garciaj...@gmail.com]
Sent: Tuesday, 7 April 2015 17:25
To: dev@cloudstack.apache.org
Cc: cloudstack-...@incubator.apache.org
Subject: Re: Simulator.
One more:
Congrats Gaurav!
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Tuesday, 14 April 2015 1:14
To: dev
Subject: [ANNOUNCE] New committer: Gaurav Nandkumar Aradhye
The Project Management Committee (PMC) for Apache CloudStack has asked Gaurav
Aradhya to become
Congrats Funs!
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Tuesday, 14 April 2015 1:12
To: dev
Subject: [ANNOUNCE] New committer: Funs Kessen
The Project Management Committee (PMC) for Apache CloudStack has asked Funs
Kessen to become a committer and we
Agree. I don't think it's possible currently. The listUsageRecords needs to be
modified.
-Original Message-
From: Ramzi Youssefi [mailto:ryouss...@gmail.com]
Sent: Wednesday, 15 April 2015 13:28
To: dev
Subject: listUsageRecord only for Admins? Why?
Hello developers!
is there any reas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27868/#review60941
---
- Koushik Das
On Nov. 11, 2014, 2:19 p.m., bharat kumar wrote
tps://reviews.apache.org/r/27868/#comment102368>
What operation, which hypervisor and VM? Also the info log is not required
as the exception message will be present in logs.
- Koushik Das
On Nov. 11, 2014, 2:19 p.m., bharat kumar
4.5 -> f1361796bf1fc73a65c47583dd0a5d6ef2dc3c27
- Koushik Das
On Nov. 12, 2014, 4:13 a.m., Damodar Reddy Talakanti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
4.5 -> 7ef0f5507d3b0debe4cfc7fb3bcada39c069e33f
- Koushik Das
On Dec. 4, 2014, 10:02 a.m., Damodar Reddy Talakanti wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
I tried a merge just now and it failed for tools/appliance/build.sh
On 09-Dec-2014, at 11:23 AM, Mike Tutkowski
wrote:
> Sounds good - thanks
>
> On Mon, Dec 8, 2014 at 10:52 PM, Rajani Karuturi wrote:
>
>> yes
>>
>> ~Rajani
>>
>> On Tue, Dec 9, 2014 at 11:09 AM, Mike Tutkowski <
>> mike.
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1251
CLOUDSTACK-9180: Optimize concurrent VM deployment operation on same â¦
â¦network
Check if VR needs to be allocated for a given network and only acquire lock
if required
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-165092578
Simulator test results for basic zone. Failure is for NiciraNvp which can
be ignored
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1272
CLOUDSTACK-9195: Cancelled/failed async jobs not getting cleaned up fâ¦
â¦rom DB
Setting 'job_complete_msid' field in async_job table when marking job as
cancelled
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-166552880
Steps to test:
- Prior to fix check for jobs in async_job table where job_status = 2 and
job_complete_msid is NULL.
- These entries won'
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-166820236
Github is not showing the diff for the below file as there are too many
changes. Is there any way to display it?
engine/orchestration/src/org/apache
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-166823449
@nitin-maharana HypervisorUtilsTest test have failed, please do a force
push again.
Code changes LGTM
---
If your project is set up for it, you can reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166824866
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-166884395
@remibergsma What you are suggesting is to pull the commit locally and then
view it using git show. But then we are loosing the benefit of viewing and
in-place
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1285#issuecomment-167044637
@miguelaferreira Looks like this PR is going to impact the feature
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import
that
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1283#issuecomment-167045587
@anshul1886 If the fix was added in 4.2, why it got missed out? Can you
check the history and update?
---
If your project is set up for it, you can reply to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-167047897
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1260#discussion_r48411330
--- Diff:
plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java
---
@@ -58,34 +58,6 @@ public void setName(String
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1285#issuecomment-168905195
@remibergsma In the FS there is a requirement "Cloud admin should be able
to to map AD OU / group to a Domain in CloudStack". So this means that LDAP
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-169979032
As a general cleanup, all configs defined in Config.java should be
gradually moved to the appropriate java classes from where they are used. We
should do away
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170011469
I have clearly mentioned that the refactoring needs to be done gradually.
But in the changes you have reverted to using the config defined in Config.java
when
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170202865
On latest master (without any fixes) I see that the config values
(network.gc.interval and network.gc.wait) are read correctly. Did the following:
- Started
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170237613
@wilderrodrigues I simply ran the steps mentioned against latest master in
a simulator setup and attached a debugger. The network GC thread was running
every
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170238553
@wilderrodrigues
The GC thread execution frequency shouldn't depend on real hardware or
simulator. It will always execute at gc.interval seconds as so
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170240228
@wilderrodrigues
- Do you agree that gc thread should run every gc.interval seconds whether
it has to cleanup any network or not?
- Do you agree that
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170483420
@wilderrodrigues My questions and comments are very valid. If you don't see
any value in them too bad. Looks like you don't want to understand the p
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-170488605
@pedro-martins By java doc are you referring to adding some comments for
isRouterDeployed()? Note that this is a private method.
If you look at the unit
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1277#issuecomment-170520102
@wilderrodrigues My questions were not in the context of refactor at all.
The reason for asking the questions was to highlight the point that for testing
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-172421544
@DaanHoogland Thanks for reviewing the code. On MS shutdown/restart the
incomplete job entry will always get marked as cancelled in DB.
You are right that
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-173474463
@remibergsma RebootCoomand is used by rebootVirtualMachine API. Refer to
test_03_reboot_vm in smoke/test_vm_life_cycle.py. It is also used in
rebootSystemVm
Agree. The commit message should provide a summary of the changes.
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Wednesday, 29 April 2015 17:07
To: dev
Subject: Re: git commit: updated refs/heads/master to 07c3089
On Wed, Apr 29, 2015 at 5:45 AM, wrote:
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-97452036
Reading the code, if testIpAddress() returns anything other than Up, Down
or null then returned status is ignored.
---
If your project is set up for it, you
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-97454863
@DaanHoogland If you look at the code from where testIpAddress() is called
(for e.g. UserVmDomRInvestigator.isAgentAlive()), it only deals with return of
Up
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-97503915
@remibergsma My comments are based on the latest master code. Based on my
reading of the code, the changes you made shouldn't have any impact on the
outco
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-97512774
Also about the scenario that is being addressed - all hosts in a XS cluster
are shutdown by pulling the plug. Instead of immediately putting the hosts in
Alert
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98100363
I looked at the code and saw that if investigate() is not able to determine
the state of host then by default Alert is returned, earlier it was null. This
may
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98100569
One possible solution I can think of the original problem for this PR is to
wait for sometime (say based on the config parameter alert.wait) and if even
after
Hi Daan,
In the slow build report mails, is it possible to add the findbug failures at
the top along with the commit ids?
-Koushik
-Original Message-
From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com]
Sent: Friday, 1 May 2015 14:31
To: dev@cloudstack.apache.org
Subject: FW: Jenki
Congrats Remi!
On 01-May-2015, at 12:15 PM, Daan Hoogland wrote:
> The Project Management Committee (PMC) for Apache CloudStack
> has asked Remi Bergsma to become a committer and we are pleased to
> announce that he has accepted.
>
> Remi has reported and helped in investigating and solving man
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/211#issuecomment-98120238
@remibergsma Yes XS (6.5) pool HA was enabled.
@DaanHoogland Agree on the new state UNKNOWN
---
If your project is set up for it, you can reply to this
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98181315
@bhaisaab The 'null' semantics of all investigators needs to change to
'Unknown'. Just look at all classes that implements Investigator
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98183123
Also callers for investigate()/isAgentAlive() methods needs to be fixed to
handle Unknown instead of null.
---
If your project is set up for it, you can reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98372263
I thought the intent of introducing 'Unkonwn' host status was to replace
the entire null semantics that was thought to be confusing in the
investi
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98374391
@DaanHoogland It is not only to prevent NPE but also to go to the next item
in the list when the status cannot be determined. Think of it like this -
status
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/222#issuecomment-98589348
I think there is agreement that this is a partial fix (with the right
intent). And that this PR doesn't add any value from the end-users perspe
The below is the proposal for switching to XenServer HA.
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201403.mbox/%3c83f77ff1bd50194ab65afa5479d082a71e4...@sjcpex01cl02.citrite.net%3E
On 04-May-2015, at 9:03 PM, Tim Mackey wrote:
> Thanks for starting this thread Remi.
>
> From my
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/253#issuecomment-102248563
Added to CLOUDSTACK-8301 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/263
Cloudstack-8301
PR for configuring local storage for system VMs at zone level.
FS @
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Enable+configuring+local+storage+use+for
I feel that the ACS docs needs to include clear/detailed steps for building
system VM templates. That way anyone can build templates from the source commit
a particular release is voted against.
-Koushik
-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Thur
In case the VR is moved out of band (say as part of Vmware DRS), all network
rules are lost. Rebooting VR from CS re-applies all the rules. Either the
reboot is done manually from UI/API or automatically as was done as part of
CLOUDSTACK-7994.
I haven't looked at the aggregate command. If it ca
also limit the fix to this hypervisor only.
Regards,
Remi
On 03 Jun 2015, at 14:12, Koushik Das
mailto:koushik@citrix.com>> wrote:
In case the VR is moved out of band (say as part of Vmware DRS), all network
rules are lost. Rebooting VR from CS re-applies all the rules. Either the
reb
regression in xen, i'm afraid
Op wo 3 jun. 2015 om 14:38 schreef Koushik Das :
> I think as a design principle we shouldn't introduce HV specific
> checks in the orchestration/API layers.
> I am not sure if the problem is specific to Vmware. Any out of band VR
> movement can l
at). Great it
is available in 4.4 as well so we can fix it in both 4.4 and 4.5 in the same
way.
On 03 Jun 2015, at 14:38, Koushik Das wrote:
>
> I think as a design principle we shouldn't introduce HV specific checks in
> the orchestration/API layers.
> I am not sure if the pr
not on the dev ML so I could not
reply
I reported this current behavior to be an issue on the user ML and wanted to
ask Koushik Das about his experiences.
I would not agree, in an Vmware environment live migrations, e.g. Vmware DRS
breaks IPtables normally. In my opinion, this would make DRS
On 04-Jun-2015, at 12:04 AM, Remi Bergsma wrote:
> Hi all,
>
> I just had a look at this more closely and had a chat with Ian about it. The
> only way for the original problem to happen (losing iptables rules) is if the
> live migrate would fail and the hypervisor rebooted the vm. The cause i
Ian,
With the persistent config change, the VR has become 'stateful'.
Is there a possibility for VR config and DB config to go out of sync? If so how
is the config in the VR and DB kept in sync?
-Original Message-
From: Ian Southam [mailto:isout...@schubergphilis.com]
Sent: Thursday, 4 J
?
On 04-Jun-2015, at 5:28 PM, Daan Hoogland wrote:
> On Thu, Jun 4, 2015 at 1:27 PM, Koushik Das wrote:
>> Is there a possibility for VR config and DB config to go out of sync? If so
>> how is the config in the VR and DB kept in sync?
>
>
> Koushik, the db is leading a
This is expected in a clustered MS setup. What is the distribution of HV hosts
across these MS (check host table in db for MS id)? MS owning the HV host
processes all commands for that host.
Grep for the sequence numbers (for e.g. 73-7374644389819187201) in both MS logs
to correlate.
On 04-Ju
From the persistent config changes, it appears that aggregate command approach
is not required in 4.6 and onwards. If someone wants to implement the aggregate
approach only for 4.4 and 4.5 irrespective of the effort involved then that
should be fine.
Otherwise we can just put some config to dec
Agree to what Funs mentioned. The current network service model is flexible,
there is option to select a provider for a given service by means of network
offering.
About using 3rd party VR, there are 2 possibilities:
- Fully replace the existing VR with 3rd party VR
- Both co-exist and complement
I like the concept of quota. But I am thinking whether this should be a core
part of CS or developed as a plugin. Cloud coins example given below may be a
plugin, based on which decision to allow/disallow operation is made. Another
plugin could be to allow/disallow operations based on VM count o
I had asked for the documentation on persistent VR (PR # 118) changes in the
context of another discussion and this is what I got at that time.
http://dev.cloudstack.apache.narkive.com/MH47etbS/discuss-out-of-band-vr-migration-should-we-reboot-vr-or-not#post39
Right now as I see from the discus
inline
On 28-Sep-2015, at 9:15 PM, Sebastien Goasguen wrote:
> Let me try to reply,
>
>> On Sep 28, 2015, at 5:17 PM, Koushik Das wrote:
>>
>> I had asked for the documentation on persistent VR (PR # 118) changes in the
>> context of another discussion and t
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/895#discussion_r40657381
--- Diff:
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java ---
@@ -297,6 +297,7 @@
s_logger.debug
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/895#discussion_r40657679
--- Diff:
server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java ---
@@ -297,6 +297,7 @@
s_logger.debug
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40658483
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -278,6 +278,8 @@
@Inject
private EndPointSelector selector
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/880#discussion_r40658531
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -413,3 +413,6 @@ CREATE TABLE `cloud`.`ldap_trust_map` (
UNIQUE KEY
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/885#issuecomment-144030748
@resmo The changes LGTM.
About testing on XS, the following should work:
- Deploy a VM
- Destroy the VM outside of CS (for e.g. from XenCenter
Raja,
The earlier scale vm test couldn't run on simulator because of the validation
steps (IIRC it tries to connect to the real VM created during test). Since it
wasn't possible to run with simulator, the new test was added to run just on
the simulator. Check the required_hardware tag.
-Ori
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/895#issuecomment-144343011
LGTM. Have verified the scenario for max. guest limit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-144347154
@SudharmaJain Why can't the XenServer600Resource be used to handle XS 6.0.2
hosts? The only change I see is the patch script
(scripts/vm/hypervisor/xens
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-144347634
I have updated #883 with my comments, looking at the changes it shouldn't
be required. Lets wait for @SudharmaJain response
---
If your project is set u
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/900#issuecomment-144348817
LGTM. Since now test_01_scale_vm can be run on simulator, no need for the
other one.
---
If your project is set up for it, you can reply to this email and have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-144384074
@DaanHoogland @borisroman The test needs to invoke a protected method from
a class and so is done using reflection. The test case already asserts for the
method
301 - 400 of 926 matches
Mail list logo
