Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73766528
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1622
@ProjectMoon the URI exception is caused by a attempting to parse an
unrecognized/unregistered scheme (lswitch). It would be a problem at runtime
for the management server, and need to be
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r74079012
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez looking good. One small item on the ``checkstate`` comment.
Also, could you please squash your commits?
---
If your project is set up for it, you can reply to this email and have
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez thanks for updates. The Jenkins build failed. It appears to be
due a timeout. Could you please force a rebuild by executing ``git commit
--amend --no-edit && git
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1626
@karuturi @rhtyd bear in mind that we have issued updated system VMs to
address CVEs and critical bugs for point releases in the past. Given the long
period of support for the 4.9 branch, we
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74247733
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -768,6 +770,12 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74248311
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1978,11 +1986,16 @@ So if getMinSpeed
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74248622
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -244,6 +245,7 @@
protected long
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74248818
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -171,6 +174,25 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74249185
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -171,6 +174,25 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74249341
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -171,6 +174,25 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74249850
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
---
@@ -234,6 +256,10 @@ public Integer getVncPort
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250104
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250269
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250260
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250288
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250378
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250473
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74250773
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74251286
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1545#discussion_r74251739
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1209,25 +1209,95 @@ public String toString
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1545
@wido @rhtyd given the flakiness of patchviasocket, I think we should
consider including this fix in all supported branches (4.8, 4.9, and master).
The issues I have seen move this bug from a
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r74271023
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
---
@@ -66,19 +68,28 @@ public
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1634
LGTM for code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74313420
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74313401
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74313885
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74313796
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74313918
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -231,6 +253,73 @@ public void cleanup() {
CallContext.unregister
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314062
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314074
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314037
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314114
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314104
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314127
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314149
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314166
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314190
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314175
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314220
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314203
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314244
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314253
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314233
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314270
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314285
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314305
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314335
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314349
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314326
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314424
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314365
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314390
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314403
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314442
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314414
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314378
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314512
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314477
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314463
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314529
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314615
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314571
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314577
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314650
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314591
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314633
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314666
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314724
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314768
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314089
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r74315493
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -157,6 +156,7 @@
import org.apache.cloudstack.usage.Usage;
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314681
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314710
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314735
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314758
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r74315902
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -479,6 +479,17 @@ public SnapshotResponse
createSnapshotResponse(Snapshot snapshot
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r74316221
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -479,6 +479,17 @@ public SnapshotResponse
createSnapshotResponse(Snapshot snapshot
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1624#discussion_r74314697
--- Diff: server/test/com/cloud/user/MockUsageEventDao.java ---
@@ -0,0 +1,356 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@serg38 I only see code review LGTMs. We need at least one test LGTM
before this PR. In this case, those tests must be run against real hardware and
hypervisors. Also, we need an LGTM from
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@rhtyd @pdion891 I apologize for my delayed reply as I am on vacation ATM.
We had previously agreed not to require Java8 until 5.0.0 which is scheduled
for the end of 2016. 4.x should be
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1638
@rhtyd there is a difference between supporting Java8 and using it as the
default version. By changing the POMs, Maven will require that Java8 in order
to use CloudStack dependencies
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@serg38 we require Marvin test results and, as well as, the results of any
manual tests to be posted into the PR. This information is a pre-requisite for
merging PRs. Please see other closed
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@nvazquez could you please add Marvin test cases to verify the new API
behavior? The tests should not only verify that the endpoints return the
versions expected, but that the storage pools
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele Would you mind adding these notes to the bug ticket? It seems
like valuable information that people searching JIRA for issues would find very
useful.
---
If your project is set
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1640#discussion_r75147713
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1640
Are there Marvin test cases to verify this behavior?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd Is my understanding correct that auto discovery was implemented in a
previous commit and this PR fixes an defect in that work? If so, could you
please provide a detailed explanation of
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1646
@rhtyd we are moving to four position to version numbers to support our
recent security release change where the fourth position is used to reflect
security patch. Therefore, the (release
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1599
@rhtyd that explanation makes sense, and the code seems to address that
issue. Could you please amend the explanation to the commit message?
---
If your project is set up for it, you can
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tukowski any committer may merge a PR with at least one code review
LGTM, at least one test LGTM, and no -1s. For this PR, I don't see a test LGTM
with test results. Until it h
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1639
@abhinandanprateek the Jenkins build failed. Please investigate and fix
the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75610768
--- Diff: setup/db/db/schema-490to491.sql ---
@@ -0,0 +1,4 @@
+
+LOCK TABLES `vm_template` WRITE;
+INSERT INTO `vm_template` VALUES (13
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75610781
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -92,6 +92,7 @@ public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75610946
--- Diff: tools/marvin/marvin/lib/common.py ---
@@ -334,13 +335,57 @@ def get_template(
return FAILED
for template in
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75611082
--- Diff: tools/marvin/marvin/sshClient.py ---
@@ -146,9 +146,8 @@ def createConnection(self):
if self.retryCnt == 0 or ret
801 - 900 of 1884 matches
Mail list logo
