Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1639#discussion_r75611082
  
    --- Diff: tools/marvin/marvin/sshClient.py ---
    @@ -146,9 +146,8 @@ def createConnection(self):
                     if self.retryCnt == 0 or ret == SUCCESS:
                         break
                     if except_msg != '':
    -                    self.logger.\
    -                        exception("SshClient: Exception under "
    -                                  "createConnection: %s" % except_msg)
    +                    self.logger.debug("SshClient: Exception under "
    +                                  "createConnection: %s while connecting 
to " % except_msg, self.host)
                     self.retryCnt -= 1
                     time.sleep(self.delay)
    --- End diff --
    
    Recognizing that this comment is beyond the scope of this PR, would it be 
possible to refactor lines 146-152 to use ``wait_for`` and a lambda?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to