Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
There are not failed test cases on CI run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1922#discussion_r102432766
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final
Github user jayapalu closed the pull request at:
https://github.com/apache/cloudstack/pull/1922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jayapalu reopened a pull request:
https://github.com/apache/cloudstack/pull/1922
CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet
Acquire ip from additional public subnet and configure nat on that ip.
After this pick any from that network and
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/843
@rhtyd
This is basic zone related changes. In the above results failures are not
related to the changes.
Can you please review the changes once.
---
If your project is set up for it
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102649918
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -83,9 +83,19 @@
public final static int
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102651284
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102651320
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1883
There are no marvin tests available for this. The unique mac address
supposed for the two different deployments.
---
If your project is set up for it, you can reply to this email and have
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r102888327
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@ustcweizhou changes for kvm were in new file. It is missed while
commiting, added now. Thanks for catching.
---
If your project is set up for it, you can reply to this email and have your
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/843
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1922
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Jenkins and travis are failing because of its internal failures.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1886#discussion_r103136343
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java
---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1824
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1866
I tested manually test_02_isolate_network_FW_PF_default_routes_egress_false
Failed. It worked for me.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1883
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1886
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon
I have seen the issue of ips.json having the "add:true" while I am testing
this PR. I tested this PR by manually removing the ip or setting add to false.
Also I t
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon The ip issue can be worked as separate ticket/PR. It is an
isolated issue, it is not having any dependency with this PR. So we will get
this PR in and create a separate ticket
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1866#discussion_r103863373
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java
---
@@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1866
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1917#discussion_r103897727
--- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java
---
@@ -43,6 +43,9 @@
"If true, when account has dedi
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon
I have today this PR after rebasing latest master. I did not observe the
add:true for the removed ip.
Here is output from the ips.json and ip addr show output
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1991
CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone
Fixed issue in deploying vm in basic zone.
There is issue in ipset command with xenserver 6.5. In util.pread2 ipset
and -N is
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1991#discussion_r104405081
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
type = getIpsetType()
tmpname
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1991
I am testing it again. Please wait till I update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1991#discussion_r104414236
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
type = getIpsetType()
tmpname
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1991
Updated the patch. Tested it no issues found.
Please review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon Can you please review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
Two LGTMs and no test failures from cloudmonger test results.
@ustcweizhou waited for your comments for this, I am putting the mergeready
tag. If you have anything to bring up let me know
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1970
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1965
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1993
Fail to deploy VM instance when use.system.public.ips=false
This PR closes PR #907
Reproducing steps:
1. Create an account
2. Dedicate public ip range to this account
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1996
CLOUDSTACK-9099: SecretKey is returned from the APIs
This PR closes the PR #1152
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1997
CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed
This PR closes PR #1307
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1993
@borisstoyanov Updated with jira ticket
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1993
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@ustcweizhou I will add disable and CLOUDSTACK-9413 in new feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/2018
CLOUDSTACK-9848: Added exit status checking for the iptables commands
Added the checking exist status of iptables command.
On exception return error so that it will be populated to
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@rhtyd Once this PR got the LGTMs, I can rebase it on 4.9. Can you please
review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1997
@ramkatru I am not sure about Daan comments.
The tests results are positive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1917
There are two LGTMs and there are not test failures in the test results. So
marking tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1997
@DaanHoogland In the case of VM_POWER_STATE handler, if PowerOff or
PowerReportMissing state is encountered,
handlePowerOffReportWithNoPendingJobsOnVM() is called. If the VM is already in
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/2018
@wido
In the patch it can be observed that it is ("-A FIREWALL_%s DROP" % )
running without '-j' and it is not caught. There is duplicate rule due this the
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082657
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110082664
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -1764,9 +1765,12 @@ protected
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r11089
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110112007
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/2018
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
It seems there is issue in CI due to that test are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110818988
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -625,15 +627,20 @@ protected
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854055
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id = v.i
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854097
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON
(s.service_offering_id = o.id AND s.vm_id = v.i
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r110854129
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
Jenkins got timed out. I am force pushing again to trigger jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@koushik-das I have updated for your review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1908
@ProjectMoon Jenkins and CI is passed, Can you please give LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
In the travis ci the tests are failing it could be because of timeout. But
when I run some of the test locally it is passing.
The same test test_invalid_gw_nm is failing in travis ci
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/2006
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-164340450
@remibergsma This job is success now. I am downloading the template from
this.
http://jenkins.buildacloud.org/job/build-systemvm64-github/
---
If your
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-166530238
@remibergsma
I have tried running the tests site to site vpn test cases on this. I
getting the test case issues.
Remi can you please run the tests on this
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1291#issuecomment-167720561
@remibergsma
I am facing the same issue while running the tests for strongswan s2s vpn.
I will apply this patch and run the tests once.
---
If your
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-167769469
Site to site vpn test case results:
$nosetests-2.7 --with-marvin
--marvin-config=/Users/jayapalreddy/advanced-acs.cfg
/Users/jayapalreddy/dev/ccp/internal
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-167932695
@remibergsma @kishankavala @terbolous @bhaisaab
Added all the required tests below. Please review the PR.
nosetests-2.7 --with-marvin
--marvin-config
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-168152239
@bhaisaab
I am waiting for the LGTM. Can u please review the changes and give LGTM
---
If your project is set up for it, you can reply to this email and have
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r48810627
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -479,13 +479,13 @@ def process(self):
def deletevpn(self, ip
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-168948254
@terbolous Thanks for testing it.
@resmo Did you find time to test this feature ?
---
If your project is set up for it, you can reply to this email and have
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-169546574
@remibergsma Did you find some time to test this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-170782564
@remibergsma status get updated in 'router.check.interval'. Please set that
interval to low 30 sec to update the status immediately and try running once
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-172485592
@remibergsma conflict got resolved.
I have tried running this test. There were some test setup issue while I am
running I resolved those in my local. The test
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-175488909
@remibergsma
Can you please try running the below tests once and let me know. For me
the tests are passed.
$nosetests-2.7 --with-marvin
--marvin
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1379
CLOUDSTACK-8324: config drive data set/get scripts for the guest vm
Added the guest vm scripts for set/get the vm data, password and ssh keys
You can merge this pull request into a Git
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1379#issuecomment-178400682
I will add the suggested changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-180292881
@remibergsma @bhaisaab
I have seen observed the your cloud monkey tests, some thing wrong
createvpnconnection steps.
create-vpns.sh is not passing the
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/375
CLOUDSTACK-8324: Added migration changes for config drive
Added vm migration changes for config drive.
1. When VM is migrated from one to another host config drive get attached
to VM in
Github user jayapalu closed the pull request at:
https://github.com/apache/cloudstack/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/479
Fixed issue in adding vm SG rules on vm reboot for xenserver 6.5
Basic zone security groups with xenserver 6.5:
- On restart vm some of the rules failed to apply.
Fixed applying VM
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-144036889
I will file a ticket for the rightsubnetwithin configuration.
I will run the BVT tests and update the results here.
---
If your project is set up for it, you
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1084#issuecomment-158020225
@wilderrodrigues @karuturi
VR scripts got stabilised over years. If any thing wrong in new
implementation there is chance to look into the VR scripts and
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158351915
@ustcweizhou @wilderrodrigues @koushik-das
It is an enhancement/feature to the product. Also a new API is introduced
here.
So I would recommend to go
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-158854951
@remibergsma
GIve me some time I will take care of it for 4.7
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-161940413
@bhaisaab @remibergsma
Started merging these commits into the latest master/4.6. Hopefully Monday
it will be ready.
@bhaisaab In strongswan ipsec observed
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162411259
@terbolous I will take care of this issue in strongswan implementation.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162517321
Remote access vpn test results:
nosetests-2.7 --with-marvin
--marvin-config=/Users/jayapalreddy/advanced.cfg
/Users/jayapalreddy/dev/github/cloudstack/test
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162761653
@remibergsma @bhaisaab I am working on uploading the test case results for
the site2site vpn.
Meanwhile some one can pick up this branch and generate the
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162789887
@terbolous Remote access vpn i have tested It.
I have triggered a job for systemvm template on my github branch for
strongswan changes.
http
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-162812927
@remibergsma It seems the systemvmvbuilder machine is down. He is having
access to these machines ?
---
If your project is set up for it, you can reply to this
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r47049123
--- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf ---
@@ -30,4 +35,5 @@ conn L2TP-PSK
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r47320168
--- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf ---
@@ -30,4 +35,5 @@ conn L2TP-PSK
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/552
Config drive changes for vm migration
On vm migration attaching it in destination host is taken care in this
patch.
In this patch only xenserver resource changes are added.
You can merge
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/568
dhcp/dns offload feature config dirve changes for vm migration
Added vm migration changes for config drive.
Added integration test for this.
You can merge this pull request into a Git
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/552#issuecomment-119935788
Discarding this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jayapalu closed the pull request at:
https://github.com/apache/cloudstack/pull/552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/586#issuecomment-124023610
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/627#issuecomment-125565419
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127497586
@wilderrodrigues Can you please review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/655
Added missed esp policy
esp is added with esp_lifetime instead of esp_policy, corrected it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/655#issuecomment-127534445
Removed convert_sec_to_h() on esp_policy.
@wilderrodrigues Please review this commit also
---
If your project is set up for it, you can reply to this email and
1 - 100 of 194 matches
Mail list logo
