[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/12 README: trigger for test PR This is a test PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhaisaab/cloudstack master Alternatively you

[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/12#issuecomment-52780505 Testing with Sebastien if we can use Github PR for ACS. Hey @ke4qqq can we enable tagging github users on pull requests like these? It's because we think Githu

[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
GitHub user bhaisaab reopened a pull request: https://github.com/apache/cloudstack/pull/12 README: trigger for test PR This is a test PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/bhaisaab/cloudstack master Alternatively

[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/12#issuecomment-52781056 Sorry about the above one, I see I can tag people but don't see everyone in the drop down list on the cloudstack repo/project. Let me try with exp

[GitHub] cloudstack pull request: README: trigger for test PR

2014-08-20 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Pull request of changes in the "cloud-ser...

2014-09-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/14#issuecomment-54144949 Thanks for your work Wilder, can you please rebase this branch against master as I see there are a lot of commits it is showing on the PR which would result in fast

[GitHub] cloudstack pull request: Pull request of changes in the "cloud-ser...

2014-09-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/14#issuecomment-54146863 Hey, the issue is the PR includes a lot of other changes which already exists on master branch. So, this PR includes these extra commits and if I merge your PR on

[GitHub] cloudstack pull request: Pull request of changes in the "cloud-ser...

2014-09-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/14#issuecomment-54169234 Thanks to @imduffy15 we have TravisCI fire up on every commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-54487736 Hi Leo, thanks for the PR. I see you've refactored the 32 and 64 bit building scripts to one which is great! I'll be able to test it next wee

[GitHub] cloudstack pull request: Fix CLOUDSTACK-7476: always pass along $J...

2014-09-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/15#issuecomment-54629994 We should have the fix on 4.4 as well, if it does not break anything and we'll be using 1.7jre/jdk since 4.3; we don't guarantee if 1.6 will work for ACS.

[GitHub] cloudstack-docs-admin pull request: accounts: document SAML authen...

2014-09-08 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/19 accounts: document SAML authentication This adds some documentation on how to use the SAML auth plugin. You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-55569445 Hi, I'll try to setup a build job for this PR and see if we can merge it on master soon after testing new builds. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-15 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-55586795 I've added a new build job for this PR: http://jenkins.buildacloud.org/job/systemvm-refactor-CLOUDSTACK-7143/ Can you check its build commands, and/or u

[GitHub] cloudstack pull request: Fix CID-1222222

2014-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/21#issuecomment-55725036 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: VPC and Virtual Network Managers refactor...

2014-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/19#issuecomment-55756600 Thanks for this Wilder. I skimmed the code and it was alright. To test, I've a KVM host and I tried to deploy basic zone with SG. The systemvms came up, the rou

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-17 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-55868179 Leo, From the jenkins job log [1] I see that the newly refactored build script is trying to setup ruby [2] and failing because of this. The jenkins job [1] already

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-19 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56225895 Looks like the build has passed now: http://jenkins.buildacloud.org/job/systemvm-refactor-CLOUDSTACK-7143/9/ I'll test it against KVM and if it works I&

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56371520 Hi Leo, I spent last few hours in debugging systemvms. I tested the built systemvms from http://jenkins.buildacloud.org/job/systemvm-refactor-CLOUDSTACK-7143/9

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56373578 I manually ran fsck on failing partitions of the systemvm and rebooted, then it worked for me. ![screen shot 2014-09-22 at 3 35 03 pm](https

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56388141 Thanks for checking the logs, the time on KVM host was today (22 sep). When I ran fsck it found and fixed couple of corrupt inodes. I think the force shutdown is the

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56425994 ![screen shot 2014-09-22 at 3 35 03 pm](https://cloud.githubusercontent.com/assets/95203/4362500/690ec2ce-428d-11e4-8c65-8865ff59052f.png) Good news! It

[GitHub] cloudstack pull request: CLOUDSTACK-7143: Refactoring of the syste...

2014-09-22 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/16#issuecomment-56429426 I've rebased your pull request against latest master, fixed some conflicts and merged to latest master. Please check the merge and send any other changes/

[GitHub] cloudstack pull request: VPC and Virtual Network Managers refactor...

2014-09-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/19#issuecomment-56533161 Hi @wilderrodrigues I'll get back to you soon on this. Meanwhile, just to reconfirm have you tested it for both basic and advance networks for Xen? If so, I&#x

[GitHub] cloudstack pull request: VPC and Virtual Network Managers refactor...

2014-09-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/19#issuecomment-56536147 Yeah, please do it for Xen and see if it works for basic VM life cycle. I've some $dayjob stuff to do so I may not be able to test your PR this week wit

[GitHub] cloudstack pull request: VPC and Virtual Network Managers refactor...

2014-09-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/19#issuecomment-56598885 Hi, I was recently reminded about the branch merging process. Once you're confident with your testing of Xen/KVM please send a merge request on dev ML and f

[GitHub] cloudstack pull request: VPC and Virtual Network Managers refactor...

2014-09-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/19#issuecomment-56959886 Thanks, looking forward to it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Vpc refactor clean for pr

2014-10-08 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/22#issuecomment-58321537 Thanks for sharing Wilder, I'll review some of pending PRs today. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: Vpc refactor clean for pr

2014-10-08 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/22#issuecomment-58341540 Code looks great, builds on my system as well. I saw the results with XenServer, I'll try to test against KVM by tomorrow and share that here. Wiki pag

[GitHub] cloudstack pull request: Vpc refactor clean for pr

2014-10-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/22#issuecomment-58875333 All's well with this PR, since 4.5 is cut now and this PR passes currently existing smoke tests should we merge it now to master? --- If your project is set u

[GitHub] cloudstack pull request: Merge 4.5 back into master

2014-10-16 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/23#discussion_r18949755 --- Diff: api/src/com/cloud/event/EventTypes.java --- @@ -454,7 +454,6 @@ public static final String EVENT_BAREMETAL_PXE_SERVER_ADD

[GitHub] cloudstack pull request: Merge 4.5 back into master

2014-10-16 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/23#discussion_r18949772 --- Diff: plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java --- @@ -238,7 +232,7 @@ private

[GitHub] cloudstack pull request: Merge 4.5 back into master

2014-10-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/23#issuecomment-59347522 Mostly LGTM. I found a pattern that all the baremetal changes are causing issues, from the JIRA issue [1] this feature is in progress and I would only

[GitHub] cloudstack pull request: Merge 4.5 back into master

2014-10-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/23#issuecomment-59356773 Hi Daan, I can help merging things on daily basis but not sure about official RM position :) I'm going ahead with the merge. I was just waiting for Trav

[GitHub] cloudstack pull request: debian: Fix changelog to use 4.4.1 releas...

2014-10-20 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/24 debian: Fix changelog to use 4.4.1 release with snapshot in the version ... Both 4.4.0 and 4.4.1 tagged releases have -snapshot in debian/changelog resulting in debian package names which

[GitHub] cloudstack pull request: CLOUDSTACK-8197 create MinVRVersion confi...

2015-02-03 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/69#issuecomment-72652130 Looks good, let's wait for Travis build result. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cloudstack pull request: fixed NPE

2015-02-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/70#issuecomment-73001652 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: fixed NPE

2015-02-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/70#issuecomment-73001870 Fixed on 4.5, 4.4, 4.3; the merge fails on these branches so cherry-picked fix from master. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: fixed NPE

2015-02-04 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/70#issuecomment-73001977 Thanks Lazlo, I've cherry-picked and applied the fix. But since this PR targets 4.4-forward that we no longer use can you please close the PR. --- If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-8215: SAML changing date calcu...

2015-02-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/71#issuecomment-73034212 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8215: SAML changing date calcu...

2015-02-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/71#issuecomment-73034891 Applied on both 4.5 and master. Thanks for fixing this @terbolous ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-7908: Add user_id column to vm...

2015-02-16 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8262: Missing usage event on F...

2015-02-17 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/80#issuecomment-74811251 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8245 and CLOUDSTACK-8246

2015-02-17 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/76#issuecomment-74816900 LGTM. @rags22489664 can you comment if disabling the scrolling will affect other components? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76346065 Good to know @resmo I think I had cherry-picked Erik's fix on 4.3+ branches. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8157: Add absolute schema refe...

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/67#issuecomment-76372764 Yes they are :) I generally try to fix things starting from lowest branch where the fix is applicable. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Support all pythons from 2.6 up.

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/89#issuecomment-76389221 LGTM, anyone else wants to review before I merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Add distribution fedora21 in packaging.sh...

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/88#issuecomment-76389435 LGTM, anyone wants to review before we merge it? @ghxandsky -- does this apply also for 4.5 (should we have 4.5 packages for Fedora?)? --- If your project is set up

[GitHub] cloudstack pull request: Cloudstack 8279

2015-02-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/90#issuecomment-76482904 LGTM, good effort. I think the logic to check can be improved by doing a split+sort+search instead of contains but it's good enough to start using jdk 1.8! -

[GitHub] cloudstack pull request: Support all pythons from 2.6 up.

2015-03-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/89#issuecomment-76692774 @runseb no, doing it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: replace cache workaround parameter, cache...

2015-03-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/60#issuecomment-76694741 Hi @K0zka I'm not sure about the patch, though would like to help merge it. Can you close this one and send another PR as the branch looks like requires reb

[GitHub] cloudstack pull request: Ovmsupport

2015-03-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/9#issuecomment-76694838 @snuf Funs how about we merge your stuff in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: modify description for name parameter in ...

2015-03-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/98#issuecomment-77359047 LGTM. merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: add ip set interface up because in CentOS...

2015-03-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/97#issuecomment-77359591 Is this related to KVM/CentOS7? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Debian package improvements

2015-03-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/96#issuecomment-77359928 This looks good, I need to test it. Anyone tested it already? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-06 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77596535 Scks that I missed this PR couple of days ago. I though @DaanHoogland was reviewing it. Okay, I made a similar fix thanks for the effort @rags22489664 but you may

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-08 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77739908 Hi @DaanHoogland your fix looks good as well, though the fix @rags22489664 suggests or that one I did would solve for the create response method in the manager

[GitHub] cloudstack pull request: CLOUDSTACK-8280: UI does not display sour...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/87#issuecomment-77809892 As per rest of the design, all the managers generally implement the response generators. The fix that was pushed follows same convention/design. --- If your project

[GitHub] cloudstack pull request: Ovmsupport 3.2.1/3.3.x

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/99#issuecomment-77811087 @snuf too many merge conflicts if I merge from your branch to master branch. This PR is for merging your branch to the ovmsupport branch. Please go ahead and merge

[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/100#issuecomment-77811516 LGTM. @K0zka please merge it on both master and 4.5! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: add ip set interface up because in CentOS...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/97#issuecomment-77811594 cc @kishankavala can you review it wrt KVM, then let's merge it? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: CLOUDSTACK-8307: UI not showing all Domai...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/101#issuecomment-77818492 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8307: UI not showing all Domai...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/101#issuecomment-77818710 Merged, please close the ticket as well after testing. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/103#issuecomment-77994917 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: systemvm: correct sftp subsystem path of ...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/104#issuecomment-77995207 Confirmed location using 4.5 systemvms. LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/102#issuecomment-77995623 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8299: Adding additional test c...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/102#issuecomment-77995716 @gauravaradhye your patch fails for 4.5, do you want to add test on 4.5 branch? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8304: disable snapshots from n...

2015-03-09 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/100#issuecomment-77995743 Not a maven expert, leaving for someone to review/merge who is. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-10 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/106 CLOUDSTACK-8272: Python based file-lock free password server implementat... Major changes: - VRs are single CPU, so Threading based implementation favoured than Forking based

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/106#issuecomment-78034264 Thanks @vincentbernat @brutasse for your reviews, fixing them now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-10 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/106#issuecomment-78037787 In a general discussion, should the stored passwords be made expirable; i.e. after a certain interval if the passwords are not served they expire, or if within

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/106#issuecomment-78217077 @vincentbernat thanks for the snippets! @resmo in case the passwdsrvrtoken went missing (file does not exist), the script may break, the || true is just so

[GitHub] cloudstack pull request: fix yum install require java => 1.7.0 whe...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/108#issuecomment-78217494 +1 the merged patch on master does not include the closes #issues string before the signature, can you close it @ghxandsky ? --- If your project is set up for it

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78217785 @pyr looks good, should it have methods for doing/handling connection and reconnection? (I've no idea how to connect to Kafka, assuming it's over TCP) -

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/109#discussion_r26193337 --- Diff: plugins/event-bus/kafka/pom.xml --- @@ -0,0 +1,45 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w

[GitHub] cloudstack pull request: systemvm: use Debian http redirector for ...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/103#issuecomment-78218859 @resmo sure, the codebase is slightly different though so picked only parts where we manually added repos: https://github.com/apache/cloudstack/commit

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78244266 @pyr thanks for replying. LGTM. Let's wait if any of the eventbus gurus want to review, else we'll merge by tomorrow. --- If your project is set up for i

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78244523 @pyr like the RabbitMQ, do you want to add docs to use/configure this as well? http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.4

[GitHub] cloudstack pull request: CLOUDSTACK-7951: Limit amount of memory u...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/111#issuecomment-78244680 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78246495 @pyr you can fork/edit this: https://github.com/apache/cloudstack-docs-admin/blob/master/source/events.rst and send PR --- If your project is set up for it, you

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/112 4.5 Branch: update pom version and add upgrade path from 4.5.0 to 4.5.1 - Updates pom version to 4.5.1-SNAPSHOT - Adds upgrade path from 4.5.0 to 4.5.1 You can merge this pull request into

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78252001 Build fine with all unit tests passing, upgrade runs successfully from 4.5.0. cc @ke4qqq @runseb @daanhoogland - would be great if you can review it

[GitHub] cloudstack-docs-admin pull request: Document Kafka event bus

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/28#issuecomment-78292774 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-docs-admin pull request: Document Kafka event bus

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/28#issuecomment-78294350 Thanks for your contribution @pyr merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78295147 @runseb the bugs were fixed on 4.5 branch so they are already in 4.5 branch. I think to create 4.5.1 RC one could simply branch off from 4.5 once these commits are

[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78297425 @pyr thanks, reviewed both doc and code and merged. Thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Ovmsupport 3.2.1/3.3.x rebased and conden...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/113#issuecomment-78327336 Hey @snuf thanks for that! It makes it easier to everyone to review and merge your stuff. First thing tomorrow morning! --- If your project is set up for it, you

[GitHub] cloudstack pull request: Ovmsupport 3.2.1/3.3.x rebased and conden...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/113#issuecomment-78328589 @snuf after a quick look at the diff I feel so emotional with the code I'm seeing, neat stuff :) :astonished: --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Ovmsupport 3.2.1/3.3.x rebased and conden...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/113#issuecomment-78428527 @runseb true that :) @snuf we're good as long as the bugs are in the plugin itself and don't affect the core. Looking at the code, does not loo

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78429050 @runseb So we've two options: I merge this into 4.5 and then a 4.5.1 RC1 candidate is cut off 4.5 branch. On 4.5 branch there aren't many commits

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78429111 @runseb yes, I want a linear release too; just use latest 4.5 (after we merge this). I'm testing it now and then merging if it passes. --- If your pr

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/112#issuecomment-78433858 Ran basic tests against KVM, they passed for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: 4.5 Branch: update pom version and add up...

2015-03-12 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-78435060 @jiangyt thanks for the patch. LGTM but I'll wait for anyone who can confirm this on windows for us. Later, I'll test if it works for *nix environment wil

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/106#issuecomment-78440246 Tested against KVM works for me, closing. Merged on 4.5 and master. Opened two ticket to track futher work on it to implement a SSL based server and IPv6

[GitHub] cloudstack pull request: CLOUDSTACK-8272: Python based file-lock f...

2015-03-12 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Ovmsupport 3.2.1/3.3.x rebased and conden...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/113#issuecomment-78449863 @snuf @likitha yeah, RAT expects a certain format. Just fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8380: Adding automation test c...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/117#issuecomment-78451273 @pritisarap12 looks good, but not a test guru to review/merge it --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Fix the bug when build apidoc under windo...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/114#issuecomment-78451206 @Cookie-Wang have you confirmed that this works for you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8323: Adding test case to veri...

2015-03-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/116#issuecomment-78451371 @gauravaradhye looks good, any results/outputs? Sorry not a test guru to help review/merge it. --- If your project is set up for it, you can reply to this email

  1   2   3   4   5   6   7   8   9   10   >