Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/23#discussion_r18949772
--- Diff:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
---
@@ -238,7 +232,7 @@ private boolean
preparePxeInAdvancedZone(VirtualMachineProfile profile, NicProfi
throw new CloudRuntimeException(String.format("failed
preparing PXE in virtual router[id:%s], because %s", vr.getId(), ret.second()));
}
- //String internalServerIp = "10.223.110.231";
+ String internalServerIp = "10.223.110.231";
--- End diff --
Hardcoded internalServerIp? Is this dead code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
