Review Request 24557: Adds tagging support for security group rules

2014-08-11 Thread Stephen Hoogendijk
tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: Adds tagging support for security group rules

2014-08-11 Thread Stephen Hoogendijk
/TaggedResourceManagerImpl.java e6f317c Diff: https://reviews.apache.org/r/24557/diff/ Testing --- api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: Adds tagging support for security group rules

2014-08-11 Thread Stephen Hoogendijk
/TaggedResourceManagerImpl.java e6f317c Diff: https://reviews.apache.org/r/24557/diff/ Testing --- api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

2014-08-11 Thread Stephen Hoogendijk
server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c Diff: https://reviews.apache.org/r/24557/diff/ Testing --- api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

2014-08-12 Thread Stephen Hoogendijk
/24557/diff/ Testing --- api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

2014-08-12 Thread Stephen Hoogendijk
--- api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions were found. Thanks, Stephen Hoogendijk

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

2014-08-12 Thread Stephen Hoogendijk
ter branch :) - Stephen --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/#review50318 --- On Aug. 12, 2014, 2:39 p.m., Stephen Hoogendijk wrote: > > --

Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules

2014-08-13 Thread Stephen Hoogendijk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24557/#review50438 --- Ship it! Ship It! - Stephen Hoogendijk On Aug. 12, 2014, 2:39

Re: Review Request 24969: [CLOUDSTACK-7398] SecurityGroupRule tags cleanup on rule deletion

2014-08-22 Thread Stephen Hoogendijk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24969/#review51273 --- Ship it! Ship It! - Stephen Hoogendijk On Aug. 22, 2014, 9:38