----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24969/#review51273 -----------------------------------------------------------
Ship it! Ship It! - Stephen Hoogendijk On Aug. 22, 2014, 9:38 a.m., Ilia Shakitko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24969/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 9:38 a.m.) > > > Review request for cloudstack, Abhishek Agarwal, Alena Prokharchyk, Animesh > Chaturvedi, Abhinandan Prateek, Darren Shepherd, edison su, Kelven Yang, and > Wei Zhou. > > > Bugs: CLOUDSTACK-7398 > https://issues.apache.org/jira/browse/CLOUDSTACK-7398 > > > Repository: cloudstack-git > > > Description > ------- > > When deleting a SecurityGroup rule with some tags linked to it, tags are > still being exist in DB. And they are linked to a non-existing resource now > (since SG rule was deleted) > > > Diffs > ----- > > > engine/schema/src/com/cloud/network/security/dao/SecurityGroupRuleDaoImpl.java > 564ec08 > > Diff: https://reviews.apache.org/r/24969/diff/ > > > Testing > ------- > > Tested on master branch (codebase 21st of August). > > 1) Created a SG rule > 2) Created few tags for that rule > 3) Deleted that rule and check listTags > 4) Tags have also been deleted > > > Thanks, > > Ilia Shakitko > >
