Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1941#discussion_r102715520
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1415,6 +1417,10 @@ public
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1941
Thanks @anshul1886. I see that you improved this PR considering the
comments from the one closed. Some tests failed. Are they false positives?
Otherwise LGTM. Just need to confirm those
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1941#discussion_r102730127
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1415,6 +1417,10 @@ public
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@anshul1886 I would like to raise the point previously discussed by me and
@rafaelweingartner. I think that we should pay attention if the change of user
and caller will really do the
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1956
Great, this one looks ready to merge.
Just for caution. Are those failures false positives?
```
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1956
Got it @borisstoyanov. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1989
@abhinandanprateek thanks for your work.
Could you please append the Jira issue CLOUDSTACK-4757 with the PR title
(https://issues.apache.org/jira/browse/CLOUDSTACK-4757
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1989
Unless I missed something and this PR does not address the same issue at
CLOUDSTACK-4757. In this case, I am sorry.
---
If your project is set up for it, you can reply to this email
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1269
Thanks for the response @anshul1886.
I am sorry, but I disagree with you. I think that it gets more stable and
readable with less duplicated code. In my humble opinion, it is
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed â\_â from variables names**: private variables with â\_â
at the beginning is common in C++ but not in Java
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-170268129
@anshul1886 could you please create a method (with documentation) for those
duplicate blocks in ConsoleProxy ( "if(viewer !=
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1278#discussion_r49269955
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -509,7 +511,9 @@ public DomainRouterVO deployRouter(final
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1278#issuecomment-170300127
I don't understand how the non-system user prevents the VR's deployment on
a disabled Pod.
It seems that neither user or account will
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1278#issuecomment-171284609
@anshul1886 I am sorry if I wasn't clear. You are using the
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
User, Ac
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49679830
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java
---
@@ -0,0
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49679998
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -821,9 +819,9 @@ protected boolean
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/928#discussion_r49688571
--- Diff: server/src/com/cloud/template/TemplateAdapterBase.java ---
@@ -293,9 +298,15 @@ public TemplateProfile
prepare
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49748364
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java
---
@@ -0,0
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/938#discussion_r49919875
--- Diff: engine/api/src/com/cloud/vm/VirtualMachineManager.java ---
@@ -49,12 +49,15 @@
public interface VirtualMachineManager extends
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172386387
@rodrigo93 This problem is not from the Jenkins. I am aware with the real
problem (APIChecker bean) just haven't forced to commit again wit
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r50616271
--- Diff: server/test/com/cloud/vpc/MockConfigurationManagerImpl.java ---
@@ -456,6 +456,15 @@ public void createDefaultSystemNetworks(long
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r50616343
--- Diff:
engine/components-api/src/com/cloud/configuration/ConfigurationManager.java ---
@@ -219,6 +219,8 @@ Vlan createVlanAndPublicIpRange
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r50623870
--- Diff: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ---
@@ -666,18 +666,10 @@ public ConsoleProxyVO startNew(long
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-174212703
@ProjectMoon Could you please do the following changes (1, 2, 3 and 4)?
**1** - create a method for the code between lines 672 and 676;
**2
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1360#discussion_r50699965
--- Diff:
services/secondary-storage/controller/src/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java
---
@@ -516,6
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-175639158
@ProjectMoon Yes, just need to add the license in
"SecondaryStorageManagerTest" class.
---
If your project is set up for it, you can reply to
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-175751878
@ProjectMoon The code is better now, well documented and with tests.
LGTM.
---
If your project is set up for it, you can reply to this email and have
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1382#issuecomment-176321558
LGTM based on the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-176495485
@bhaisaab Could you please do the following changes?
At **VirtualMachineVolumeChainInfo** class:
**1 -** create Javadoc blocks (would be nice to
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51359410
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-177495811
@bhaisaab Thanks for the test and StringUtils fix.
**-** Could you please change the Access Levels of diskDeviceBusName and
diskChain from public
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51360756
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362068
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362259
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r51362827
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1360#issuecomment-177942109
@rodrigo93 I think that a JIRA ticket wouldn't help much, considering that
JIRA is for report issues (not PRs). I think that the point here is to an
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r51717944
--- Diff: core/src/org/apache/cloudstack/storage/command/AttachAnswer.java
---
@@ -34,6 +37,12 @@ public AttachAnswer(DiskTO disk
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r52021538
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r52094345
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r52095108
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52108568
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -180,70 +208,119
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52108693
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +332,149
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52108776
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +332,149
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r52108928
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -168,7 +168,9 @@
public
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1202#issuecomment-180890324
LGTM. Based on the lack of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/846#discussion_r52110260
--- Diff: server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java
---
@@ -342,6 +342,12 @@ public ExternalDeviceNetworkUsageTask
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1406#discussion_r52851113
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
---
@@ -350,6 +359,24 @@ public EndPoint
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r52853711
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/GuestOsDescriptorType.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1406#discussion_r53149620
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
---
@@ -92,7 +92,7 @@ public static VolumeObject
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1406#discussion_r53150413
--- Diff:
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java
---
@@ -92,7 +92,7 @@ public static VolumeObject
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1410#discussion_r53556330
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1006,6 +1006,19 @@ protected
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/797#discussion_r53559299
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1776,19 +1773,26 @@ private void
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/556#discussion_r53570662
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ---
@@ -880,6 +880,38 @@ else if (prop.getName().startsWith("
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1194#issuecomment-163584797
I think it would be better to change âQuotaâ by âcotaâ. Both are
correct, but Brazilians are used with âcotaâ.
It seems that the
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218850613
@DaanHoogland @ustcweizhou I noticed that there is four 'if' with the
condition `(io != null) && (io > 0)` at the _KVMStorageProcesso
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218869697
I don't see anything wrong with this PR. However, the point made by
@rodrigo93 is interesting.
At the class "VolumeOrchestrator" (
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63281205
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -519,6 +523,64 @@ public Answer
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63281246
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -303,6 +305,7 @@
protected
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63281291
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
---
@@ -61,11 +61,28 @@ public
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219249718
@nvazquez sorry for the late review,
I could point just 2 typos on Javadoc and some variables with the
underscore (would be nice to change those
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219430432
The idea and screenshot seem nice, the code is ok. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219561259
Based on code review and the documentation cited by @remibergsma, the code
LGTM.
---
If your project is set up for it, you can reply to this email and
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1550#issuecomment-219772135
Based on code review, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-220382990
Thanks for the update @ustcweizhou, now I can't find anything to :-1: this
code.
Based on code review and the CI result, the code LGTM.
---
If
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64078451
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64080090
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1558
Remove unused code at "com.cloud.vm.UserVmManagerImpl"
# Summary
All changes in this PR started by removing unused methods from the
"UserVmManagerImpl". That
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221349421
Thanks @nlivens, great work cleaning.
The code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user GabrielBrascher commented on the issue:
https://github.com/apache/cloudstack/pull/1615
@serg38 @nvazquez the code seems ok.
Is there anything pending with the _blueorangutan_ test?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-188040784
@nvazquez LGTM based on integration tests and code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-189941771
@kansal Could you please consider the following adjustments?
- create a method for the "Part 1" (lines 213-219). With the command as
par
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1257#discussion_r54359804
--- Diff: vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java ---
@@ -1110,4 +1148,39 @@ public String getNetworkName(String netMorVal
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-192720921
It seems a fair update.
LGTM due to the lack of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55127619
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55127726
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1253#issuecomment-192951641
@sureshanaparti Although it might be a bit tricky, I believe that the ideal
solution would be to check for the hypervisor version; if it is 4.1/4.0 then
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55153415
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/561#issuecomment-193063329
Shouldn't the class throw a less generic Exception? A good choice might be
the **com.cloud.utils.ssh.SshException.SshException(String)**.
Although
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55160508
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/561#issuecomment-193216137
That's fair enough @DaanHoogland, I will see what I can do for this PR.
---
If your project is set up for it, you can reply to this email and have
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/844#discussion_r55611837
--- Diff: client/WEB-INF/classes/resources/messages.properties ---
@@ -1823,6 +1823,7 @@ message.after.enable.swift=Swift configured. Note\:
When
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1434
Change variable "ROOK_DISK_CONTROLLER" to "ROOT_DISK_CONTROLLER"
Change com.cloud.vm.VmDetailConstants variable name from
"ROOK_DISK_CONTROLLER"
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195618530
Given that @pedro-martins had no problems on running tests, the code LGTM.
---
If your project is set up for it, you can reply to this email and have your
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/36#issuecomment-198702503
Hi @agneya2001, could you please consider the following suggestions?
- Line 1453, change from "debian" to "Debian";
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1443
Remove unused code from XenServerStorageProcessor and change methods access
level
Remove unused code from
"com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor"
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198794064
@eriweb, as far as I know, JIRA is used for bug/issue tracking. JIRA is a
way that users have to report bugs. Based on JIRA, developers can track and fix
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198803008
@eriweb, I didn't considered JIRA looking to this point of view (track
changes in the release note). With that in mind it seems an interesting
app
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1448
Removed unused Classes
Remove unused Classes (classes with no references:
- com.cloud.agent.api.CheckStateAnswer
- com.cloud.agent.api.StartupVMMAgentCommand
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199272015
@DaanHoogland the lack of test in some classes indeed is a problem.
However, these classes that I removed are not being used.
I used UCDetector
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1448#issuecomment-199521289
@DaanHoogland @swill thank you for the concern. I agree with the need for
executing integration/functional tests to keep the code stable. Unfortunately
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1453
Remove classes with no references
I used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse.
With this tool, I discovered a lot of code without any reference (variables
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1326#discussion_r57545397
--- Diff: test/integration/component/test_add_remove_network.py ---
@@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-203484371
Thank you @pdube!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203492750
@DaanHoogland @rafaelweingartner well noted, I have to remove those
".class" files;
@pdube I am going to verify this checkstyle error.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203947763
@DaanHoogland @rafaelweingartner @pdube removed those ".class" files, also
all checks have passed.
Thanks.
---
If your project is set up f
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1459
Cloudstack 8611 Handle SSH if server "forget" to send exit status
Continuing the work started by @likitha, I cherry-picked the
commit (b9181c689e0e7b5f1e28c81d737101
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204293184
Not sure why it shows as if I had changed all the SshHelper class (the
diff shows removed lines that I have not changed). I will check on that.
---
If
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204484447
@DaanHoogland thanks for the hint, but the problem is not related to line
ending.
The problem is that there are two (2) different SshHelper classes
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-204571209
Correcting myself, the history from the SshHelper
(https://github.com/likitha/cloudstack/commits/CLOUDSTACK-8611/utils/src/com/cloud/utils/ssh
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1459#discussion_r58442410
--- Diff: utils/src/test/java/com/cloud/utils/ssh/SshHelperTest.java ---
@@ -0,0 +1,131 @@
+//
+// Licensed to the Apache Software
1 - 100 of 142 matches
Mail list logo
