itional testing will be performed as this is integrated into existing parts
of the UI.
Thanks,
Chris Suich
b
Diff: https://reviews.apache.org/r/14285/diff/
Testing
---
Testing has been done in conjunction with a UI plugin I am developing.
Additional testing will be performed as this is integrated into existing parts
of the UI.
Thanks,
Chris Suich
Resource.java
3ef950b
Diff: https://reviews.apache.org/r/14477/diff/
Testing
---
Thanks,
Chris Suich
---
server/src/com/cloud/api/query/vo/StoragePoolJoinVO.java 69f2204
setup/db/db/schema-420to430.sql 653ff77
Diff: https://reviews.apache.org/r/14516/diff/
Testing
---
Thanks,
Chris Suich
know.
Thanks,
Chris Suich
:
https://reviews.apache.org/r/14522/#review26786
-------
On Oct. 7, 2013, 8:26 p.m., Chris Suich wrote:
>
> ---
> This is an automatically generated e-m
re were no errors being thrown over this.
Thanks,
Chris Suich
).
Thanks,
Chris Suich
there shouldn't be any
issues.
However, I did do a clean build and played around with the UI while watching
vmops.log to make sure there were no errors being thrown over this.
Thanks,
Chris Suich
---
Thanks,
Chris Suich
recommendations, please let me know.
Thanks,
Chris Suich
8>
> >
> > Very poor performance as it circumvents the primitive pool. Change to
> > Integer.valueOf(i1).compareTo(Integer.valueOf(i2)).
Will do.
> On Oct. 15, 2013, 2:41 p.m., John Burwell wrote:
> > engine/storage/snapshot/src/org/apache/c
d to throw an exception when a
> > snapshot can't be reverted. In addition to be a simpler approach, it
> > covers both the scenario when a device does not support reverting snapshots
> > and, as well as, the device or the snapshot not being a revertable state.
>
>
d to throw an exception when a
> > snapshot can't be reverted. In addition to be a simpler approach, it
> > covers both the scenario when a device does not support reverting snapshots
> > and, as well as, the device or the snapshot not being a revertable state.
>
>
d to throw an exception when a
> > snapshot can't be reverted. In addition to be a simpler approach, it
> > covers both the scenario when a device does not support reverting snapshots
> > and, as well as, the device or the snapshot not being a revertable state.
>
>
derlying device can take a snapshot without
> > accounting for whether or not the volume is in a state to take a consistent
> > snapshot. I am also concerned that we don't have a semantic for handling
> > errors that might result from the actual snapshot operation.
>
&g
is locally with a custom storage provider.
Unfortunately, I'm still in the middle of figuring out how to properly unit
test this type of code. If anyone has any recommendations, please let me know.
Thanks,
Chris Suich
e volume.
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/#review27126
---
On Oct. 16, 2013, 2:50 p.m., Chris Suich wrote:
>
>
Testing
---
I have tested all of this locally with a custom storage provider.
Unfortunately, I'm still in the middle of figuring out how to properly unit
test this type of code. If anyone has any recommendations, please let me know.
Thanks,
Chris Suich
context information to error message to help operators and users
> > determine what couldn't be snapshotted.
>
> Chris Suich wrote:
> Fair enough - I just copied these existing error messages. What kind of
> context would you like to see in this error message? The src
/
Testing
---
Thanks,
Chris Suich
: cloudstack-git
Description
---
Fixed a typo causing vm snapshot requests to always instantly return successful
in the CloudStack UI.
Diffs
-
ui/scripts/instances.js 41d1772
Diff: https://reviews.apache.org/r/14782/diff/
Testing
---
Thanks,
Chris Suich
imply chose
one by iterating over the list of strategies once and returning the best
strategy.
- Chris Suich
On Oct. 22, 2013, 3:34 a.m., Darren Shepherd wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On Oct. 22, 2013, 1:19 p.m., Chris Suich wrote:
> > Darren, the design of all of this has already changed here:
> > https://reviews.apache.org/r/14522/. Take a look at the newer revisions
> > which haven't made it in yet (still waiting on a final review from Joh
em. Is there some way
around this?
- Chris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/#review27298
-------
On Oct. 17, 2013, 6:46 p.m., Chris Suich wrote:
>
> -
Testing
---
I have tested all of this locally with a custom storage provider.
Unfortunately, I'm still in the middle of figuring out how to properly unit
test this type of code. If anyone has any recommendations, please let me know.
Thanks,
Chris Suich
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14522/#review27303
---
On Oct. 22, 2013, 2:48 p.m., Chris Suich wrote:
>
> --
trategy-sorting-selection.patch
https://reviews.apache.org/media/uploaded/files/2013/10/22/0003-Added-context-to-strategy-sorting-error-responses.patch
https://reviews.apache.org/media/uploaded/files/2013/10/22/0004-Updated-DataMotionServiceImpl-and-ApiResponseHelper-.patch
Thanks,
Chris Suich
how to properly unit
test this type of code. If anyone has any recommendations, please let me know.
File Attachments (updated)
https://reviews.apache.org/media/uploaded/files/2013/10/22/commits.patch
Thanks,
Chris Suich
test this type of code. If anyone has any recommendations, please let me know.
File Attachments (updated)
https://reviews.apache.org/media/uploaded/files/2013/10/22/0001-Squashed-commits-from-review-revisions.patch
Thanks,
Chris Suich
d-commit-of-the-following.patch
Thanks,
Chris Suich
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14914/#review27529
---
Ship it!
Works great!
- Chris Suich
On Oct. 24, 2013, 10:06 p.m
supposed to be changed to
store.getUuid() but was actually changed to volumeTo.getUuid().
Diffs
-
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
0e2423e
Diff: https://reviews.apache.org/r/15309/diff/
Testing
---
Thanks,
Chris
://reviews.apache.org/r/15313/diff/
Testing
---
Thanks,
Chris Suich
Testing
---
This has been tested locally with a custom plugin. However, the changes are not
used by the existing CloudStack codebase and should not impact any existing
workflows or use cases. They are simply for plugins to take advantage of.
Thanks,
Chris Suich
/
Testing (updated)
---
This has been tested locally with a custom plugin. However, the changes are not
used by the existing CloudStack codebase and should not impact any existing
workflows or use cases. They are simply for plugins to take advantage of.
Thanks,
Chris Suich
advantage of.
Thanks,
Chris Suich
/
Testing (updated)
---
Thanks,
Chris Suich
mitted, the password is still visible in plain text.
This patch fixes the issue by respecting the 'isPassword' attribute on detail
view fields.
Diffs
-
ui/scripts/ui/widgets/detailView.js 65f71b3
Diff: https://reviews.apache.org/r/15362/diff/
Testing
---
Thanks,
Chris Suich
e81e30e
Diff: https://reviews.apache.org/r/15521/diff/
Testing
---
Thanks,
Chris Suich
appropriate plugin
dictionary is loaded into the global js dictionary (with the global dictionary
taking precedence in the event of a conflict).
Diffs
-
ui/scripts/plugins.js 96ed229
Diff: https://reviews.apache.org/r/13127/diff/
Testing
---
Thanks,
Chris Suich
Diffs
-
ui/scripts/ui-custom/zoneChart.js 1a5fb59
Diff: https://reviews.apache.org/r/13128/diff/
Testing
---
Thanks,
Chris Suich
ome way to fix this.
Diffs
-
Diff: https://reviews.apache.org/r/13134/diff/
Testing
---
File Attachments
https://reviews.apache.org/media/uploaded/files/2013/07/31/has_units-field.patch
Thanks,
Chris Suich
ermined at run time.
Diffs
-
ui/scripts/sharedFunctions.js 8ddaeaf
ui/scripts/ui/dialog.js 1ff5401
Diff: https://reviews.apache.org/r/13132/diff/
Testing
---
Thanks,
Chris Suich
3131/diff/
Testing
---
File Attachments
https://reviews.apache.org/media/uploaded/files/2013/07/31/field-identify-value.patch
Thanks,
Chris Suich
---
UserVmResponse was missing some getters, so I generated them with Eclipse.
Diffs
-
api/src/org/apache/cloudstack/api/response/UserVmResponse.java e49e16b
Diff: https://reviews.apache.org/r/13833/diff/
Testing
---
Thanks,
Chris Suich
into VolumeServiceImpl.takeSnapshot()'s catch instead of
just ignoring the exception it would be handled for anyone who tries to take a
snapshot.
- Chris Suich
On March 20, 2014, noon, Alex Hitchins wrote:
>
> ---
> This is an automa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19460/#review37891
---
Ship it!
Ship It!
- Chris Suich
On March 20, 2014, 2:42 p.m
hether this was just a typo of
'!=' instead of '=='?
Diffs
-
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
f487eb4
Diff: https://reviews.apache.org/r/20250/diff/
Testing
---
Thanks,
Chris Suich
ifying
> applicationContext.xml.inand commands.properties.in. 4.3 appears to have
> introduces discoverable plugins. What needs to be done differently in order
> to take advantage of this?
> Thank you for your time,
> Matt
--
Chris Suich
919-334-8193
csui...@gmail.com
I seemed to notice that the email list went silent for 24-48 hours
around last Thursday/Friday.
On Tue, May 13, 2014 at 7:57 PM, Alex Huang wrote:
> I've find some of my emails did not make it to the mailing list. Does anyone
> else have this problem?
>
> --Alex
--
Chris S
10:04 AM, sebgoa wrote:
>
> On May 9, 2014, at 6:39 PM, "La Motta, David"
> wrote:
>
>> I wanted to give a shout-out to Chris Suich, who was a key player in the
>> team that worked on the NetApp plugin--aka Virtual Storage Console for
>> Apache CloudStack
s. Does anyone have any suggestions?
--
Chris Suich
919-334-8193
csui...@gmail.com
http://solidfire.com/solution/overview/?video=play>*(tm)*
> >>
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > <http://solidfire.com/solution/overview/?video=play>*(tm)*
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*(tm)*
>
--
Chris Suich
919-334-8193
csui...@gmail.com
that I can
> handle
> > reverting.
> >
> > If it's not one of mine, I can run the default logic that's provided from
> > the class my strategy extends.
> >
> > Sounds about right?
> >
> >
> > On Thu, Aug 28, 2014 at 1:42 PM, Chris Su
VirtualNetworkApplianceManagerImpl.java. Was that intentional?
- Chris Suich
On Nov. 25, 2013, 6:55 p.m., Nitin Mehta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/src/com/cloud/storage/StorageManagerImpl.java e81e30e
Diff: https://reviews.apache.org/r/15521/diff/
Testing
---
Thanks,
Chris Suich
remove the overlay when an
error occurs during the operation.
This is for JIRA-5368. If accepted, please apply to 4.3 branch as well.
Diffs
-
ui/scripts/ui/widgets/listView.js 53b37f1
Diff: https://reviews.apache.org/r/16001/diff/
Testing
---
Thanks,
Chris Suich
: cloudstack-git
Description
---
Added load vs refresh context/indicator for dataProviders for CLOUDSTACK-5384
Diffs
-
ui/scripts/ui/widgets/detailView.js 3a3cd79
Diff: https://reviews.apache.org/r/16041/diff/
Testing
---
Thanks,
Chris Suich
/
Testing
---
Thanks,
Chris Suich
/diff/
Testing
---
Thanks,
Chris Suich
61 matches
Mail list logo