[GitHub] [cloudstack-primate] davidjumani opened a new pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
davidjumani opened a new pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745 Fixes https://github.com/apache/cloudstack-primate/issues/740 1. Notifies the user that the api could not be found or is not available 2. Prevents logout if api not found or black

[GitHub] [cloudstack-primate] davidjumani commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
davidjumani commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698162174 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
davidjumani commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162197 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698162611 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698162597 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698166624 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698166877 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-24 Thread GitBox
davidjumani commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-698170910 @rhtyd Fixed the logout issue in https://github.com/apache/cloudstack-primate/pull/745 Now it logs out but leaves a notification that the session has expired

[GitHub] [cloudstack-primate] rhtyd commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
rhtyd commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698178811 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #8: Some fixes for Go 1.13

2020-09-24 Thread GitBox
onitake commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698179080 Thanks, @rhtyd . It would be good if we have some automated builds/tests anyway. These kinds of PRs should be easy to test. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698179199 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
rhtyd commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698180109 @utchoang can you test and advise when this is ready for testing? I navigated to the IP view from VPC -> select Admin-RR -> select IP address tab and select an IP and I

[GitHub] [cloudstack-primate] rhtyd commented on issue #743: [BUG] Edit instance - offer existing Groups

2020-09-24 Thread GitBox
rhtyd commented on issue #743: URL: https://github.com/apache/cloudstack-primate/issues/743#issuecomment-698180716 @andrijapanicsb the API allows both changing to an existing group or add to a new group (a new name would also create a new group). Should we keep it as it is?

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13

2020-09-24 Thread GitBox
rhtyd commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698181704 @onitake we've Travis integration for all apache repos, can we leverage that? This is an automat

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13

2020-09-24 Thread GitBox
rhtyd commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698182811 @onitake you may log a ticket with ASF INFRA (https://issues.apache.org/jira/projects/INFRA) to enable Travis support https://travis-ci.org/github/apache/cloudst

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698183817 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3

[GitHub] [cloudstack-documentation] rhtyd merged pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-24 Thread GitBox
rhtyd merged pull request #151: URL: https://github.com/apache/cloudstack-documentation/pull/151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-24 Thread GitBox
DaanHoogland commented on issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698185327 @utchoang i have just tested this on last nightly build and it is still there. As stated in my "additional Context" there is an easy workaround and selecting the "leaf

[GitHub] [cloudstack-documentation] rhtyd merged pull request #149: Renamed dhclient folder to DHCP

2020-09-24 Thread GitBox
rhtyd merged pull request #149: URL: https://github.com/apache/cloudstack-documentation/pull/149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd merged pull request #145: Modified project details - role based users in projects

2020-09-24 Thread GitBox
rhtyd merged pull request #145: URL: https://github.com/apache/cloudstack-documentation/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd merged pull request #133: Edit OVS Plugin

2020-09-24 Thread GitBox
rhtyd merged pull request #133: URL: https://github.com/apache/cloudstack-documentation/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #132: cloud-init and UserData service documentation cleanup

2020-09-24 Thread GitBox
rhtyd commented on pull request #132: URL: https://github.com/apache/cloudstack-documentation/pull/132#issuecomment-698185977 @onitake can you address merge conflict, and update as necessary? Thanks This is an automated mess

[GitHub] [cloudstack-documentation] rhtyd merged pull request #147: secondary storage management

2020-09-24 Thread GitBox
rhtyd merged pull request #147: URL: https://github.com/apache/cloudstack-documentation/pull/147 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #60: Volumes metrics doc update

2020-09-24 Thread GitBox
rhtyd commented on pull request #60: URL: https://github.com/apache/cloudstack-documentation/pull/60#issuecomment-698186980 @andrijapanicsb can you address conflict and move to ready for review when this is ready? This is a

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-24 Thread GitBox
DaanHoogland commented on issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698194554 @utchoang I noticed something related: when deleting a domain without cleanup, it fails but does remove the domain and its childeren from the tree. https://user-

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #746: [FEATURE] domain admin should have "User" as default account type when adding an account

2020-09-24 Thread GitBox
DaanHoogland opened a new issue #746: URL: https://github.com/apache/cloudstack-primate/issues/746 **Is your feature request related to a problem? Please describe.** As a Domain Admin my ussual account type to add is "User" so I want this to be the default choice. https://user-ima

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-24 Thread GitBox
DaanHoogland opened a new issue #747: URL: https://github.com/apache/cloudstack-primate/issues/747 **Describe the bug** If a domain admin makes a typo in a domain name, they cannot correct themselves. **To Reproduce** Steps to reproduce the behavior: 1. Log in as a Domai

[GitHub] [cloudstack-documentation] shwstppr commented on pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-24 Thread GitBox
shwstppr commented on pull request #151: URL: https://github.com/apache/cloudstack-documentation/pull/151#issuecomment-698204359 With root disk resize I meant when `createKubernetesCluster` API is used with a value for its `noderootdisksize` --

[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
utchoang commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698207632 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
utchoang commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698207396 @rhtyd Sorry, I commit missing. Please try again. Thanks. This is an automated message from the Apach

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698208238 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-24 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698213345 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #8: Some fixes for Go 1.13

2020-09-24 Thread GitBox
onitake commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698220571 I think I can write a quick .travis.yml file to do a gobuild and a gotest. For a proper integration test, we need some kind of of simulation of the CS AP

[GitHub] [cloudstack-primate] utchoang opened a new pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-24 Thread GitBox
utchoang opened a new pull request #748: URL: https://github.com/apache/cloudstack-primate/pull/748 Fixes #741 @rhtyd cc @svenvogel Please review it. Thanks. This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #743: [BUG] Edit instance - offer existing Groups

2020-09-24 Thread GitBox
andrijapanicsb commented on issue #743: URL: https://github.com/apache/cloudstack-primate/issues/743#issuecomment-698249539 As a user, I don't see a value of being able to just enter a group name and have it created automatically (plain dumb, but that's what's already there...) - it's jus

[GitHub] [cloudstack-primate] utchoang commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-24 Thread GitBox
utchoang commented on pull request #748: URL: https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698308855 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-24 Thread GitBox
blueorangutan commented on pull request #748: URL: https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698309094 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #748: FIX - Domain: fix error tree domain after deleting the domain.

2020-09-24 Thread GitBox
blueorangutan commented on pull request #748: URL: https://github.com/apache/cloudstack-primate/pull/748#issuecomment-698313453 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/748 (JID-3

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #749: [BUG] Domain admin cannot create a second user in an account

2020-09-24 Thread GitBox
DaanHoogland opened a new issue #749: URL: https://github.com/apache/cloudstack-primate/issues/749 **Describe the bug** both new and old UI fail but indifferent ways. **To Reproduce** Steps to reproduce the behavior: 1. Log in as a Domain Admin 1. Create a child domain

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #750: [BUG] domain choice required while already in an account (i.e. in a Domain)

2020-09-24 Thread GitBox
DaanHoogland opened a new issue #750: URL: https://github.com/apache/cloudstack-primate/issues/750 **Describe the bug** In addition to a domain being a required field while adding a user to an account, the default selection is not the domain the account we are adding a user to, is in. (

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
davidjumani opened a new pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751 Adding support for non deploy as is templates which have multiple data disks This is an automated message from the Apache

[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #17: Remove vendored dependencies

2020-09-24 Thread GitBox
onitake opened a new pull request #17: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17 As discussed in #8 , these are no longer necessary thanks to the first-class module support in Go 1.13+. Matching dependency versions is ensured through go.mod and go.sum.

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #2: [OLD] Changing from TCP to TCP Proxy doesn't work

2020-09-24 Thread GitBox
onitake commented on issue #2: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-698397268 @joschi36 can you test if this bug still occurs? I think we fixed it with all the changes in #9 , but I'm not completely sure.

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
andrijapanicsb commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400120 @blueorangutan package This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698400438 @andrijapanicsb a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698406656 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
davidjumani commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422257 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698422773 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698428775 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3

[GitHub] [cloudstack-primate] nvazquez commented on a change in pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
nvazquez commented on a change in pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#discussion_r494735051 ## File path: src/views/compute/DeployVM.vue ## @@ -1484,6 +1524,12 @@ export default { deployVmData.bootintosetup = values.bootintos

[GitHub] [cloudstack-primate] utchoang commented on issue #747: [BUG] Domain admin cannot edit a domain they created

2020-09-24 Thread GitBox
utchoang commented on issue #747: URL: https://github.com/apache/cloudstack-primate/issues/747#issuecomment-698709080 @DaanHoogland @rhtyd cc @svenvogel On the old UI side, Domain Admin is only allowed to edit resources, not edit domain names. So in the new UI, you can update the resourc

[GitHub] [cloudstack-primate] davidjumani commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
davidjumani commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698721217 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698721333 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
davidjumani commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698722574 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698722737 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
blueorangutan commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698724499 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/751 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #745: Fixing login, session expired and blacklisted api requests

2020-09-24 Thread GitBox
blueorangutan commented on pull request #745: URL: https://github.com/apache/cloudstack-primate/pull/745#issuecomment-698725520 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/745 (JID-3

[GitHub] [cloudstack-primate] andrijapanicsb merged pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
andrijapanicsb merged pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #751: Adding multi disk selection for supported templates

2020-09-24 Thread GitBox
andrijapanicsb commented on pull request #751: URL: https://github.com/apache/cloudstack-primate/pull/751#issuecomment-698758378 LGTM This is an automated message from the Apache Git Service. To respond to the message, pleas