[GitHub] [cloudstack-primate] rhtyd commented on issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)

2020-08-28 Thread GitBox
rhtyd commented on issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620#issuecomment-682365618 Fixed in https://github.com/apache/cloudstack-primate/pull/628 This is an automated message from the Apache G

[GitHub] [cloudstack-primate] rhtyd closed issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)

2020-08-28 Thread GitBox
rhtyd closed issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #628: deployvm : Setting default min cpunumber and memory to zero

2020-08-28 Thread GitBox
rhtyd merged pull request #628: URL: https://github.com/apache/cloudstack-primate/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #624: [BUG]

2020-08-28 Thread GitBox
DaanHoogland commented on issue #624: URL: https://github.com/apache/cloudstack-primate/issues/624#issuecomment-682369437 @rhtyd, @andrijapanicsb giving a way to just enter a name and create a network does not prohibit a create network button. the two are not mutually exclusive. I consid

[GitHub] [cloudstack-primate] davidjumani commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role

2020-08-28 Thread GitBox
davidjumani commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682404079 @andrijapanicsb Fixed in #609 Could you verify the same ? This is an automated message from the Apache

[GitHub] [cloudstack-primate] rhtyd commented on issue #603: [BUG] Deploy VM job not submited for a long time (?)

2020-08-28 Thread GitBox
rhtyd commented on issue #603: URL: https://github.com/apache/cloudstack-primate/issues/603#issuecomment-682405414 I tried latest master and primate-qa (simulator) and a KVM/trillian env and don't see this. @andrijapanicsb please re-open if you reproduce this again. -

[GitHub] [cloudstack-primate] rhtyd closed issue #603: [BUG] Deploy VM job not submited for a long time (?)

2020-08-28 Thread GitBox
rhtyd closed issue #603: URL: https://github.com/apache/cloudstack-primate/issues/603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #604: [BUG] EDIT TEMPLATE not on pair with the old UI

2020-08-28 Thread GitBox
rhtyd commented on issue #604: URL: https://github.com/apache/cloudstack-primate/issues/604#issuecomment-682405798 @davidjumani can you check and remove ssh enabled option if not necessary (does it make any difference)? (from both register and edit template forms) ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role

2020-08-28 Thread GitBox
rhtyd commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682406307 @davidjumani if we're not sure when #609 will merge, can you send another PR that fixes this blocker for the specific case for VM deployment for users? -

[GitHub] [cloudstack-primate] rhtyd commented on issue #615: [UX] Show multple aysnc jobs horizonatally rather than vertically

2020-08-28 Thread GitBox
rhtyd commented on issue #615: URL: https://github.com/apache/cloudstack-primate/issues/615#issuecomment-682406740 Normally we would expect users to wait until an async job is done; otherwise they need to live with the prompt. Alternatively we can simply decide to get rid of the floating

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #625: Allow migration of detached volumes

2020-08-28 Thread GitBox
rhtyd commented on a change in pull request #625: URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478957423 ## File path: src/config/section/storage.js ## @@ -168,7 +168,7 @@ export default { label: 'label.migrate.volume', args: ['vo

[GitHub] [cloudstack-primate] rhtyd commented on issue #624: [BUG]

2020-08-28 Thread GitBox
rhtyd commented on issue #624: URL: https://github.com/apache/cloudstack-primate/issues/624#issuecomment-682407920 I've change milestone to 1.1, we need to discuss this on dev/users ML to see what is the general preference. During preview and testing we were advised against what old UI di

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #631: FIX - Keep form/modal when clicking outside the form

2020-08-28 Thread GitBox
rhtyd commented on a change in pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#discussion_r478959264 ## File path: src/views/project/iam/ProjectRoleTab.vue ## @@ -103,7 +108,12 @@ - +

[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form

2020-08-28 Thread GitBox
rhtyd commented on pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682408632 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-primate] rhtyd merged pull request #631: FIX - Keep form/modal when clicking outside the form

2020-08-28 Thread GitBox
rhtyd merged pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #629: [BUG] Clicking outside the form (i.e. new offering creation) closes the form

2020-08-28 Thread GitBox
rhtyd closed issue #629: URL: https://github.com/apache/cloudstack-primate/issues/629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form

2020-08-28 Thread GitBox
rhtyd commented on pull request #631: URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682409003 @utchoang tip - when you send a PR that fixes an issue can you use `Fixes #id-of-pr` in the git commit or PR summary that way merging the PR will close the bug. --

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
rhtyd edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682409624 @davidjumani it may require some framework level fixes - could it be possible to track the list of asyncjobs somehow and then refresh when all have been completed? (in

[GitHub] [cloudstack-primate] rhtyd commented on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
rhtyd commented on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682409624 @davidjumani it may require some framework level fixes - could it be possible to track the list of asyncjobs somehow and then refresh when all have been completed? (instead o

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #625: Allow migration of detached volumes

2020-08-28 Thread GitBox
davidjumani commented on a change in pull request #625: URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478967267 ## File path: src/config/section/storage.js ## @@ -168,7 +168,7 @@ export default { label: 'label.migrate.volume', args

[GitHub] [cloudstack-primate] rhtyd merged pull request #625: Allow migration of detached volumes

2020-08-28 Thread GitBox
rhtyd merged pull request #625: URL: https://github.com/apache/cloudstack-primate/pull/625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #622: [BUG] Migrate volume is missing when volume is detached

2020-08-28 Thread GitBox
rhtyd commented on issue #622: URL: https://github.com/apache/cloudstack-primate/issues/622#issuecomment-682414723 Checked against old UI and verified. Fixed in latest master with https://github.com/apache/cloudstack-primate/pull/625 -

[GitHub] [cloudstack-primate] rhtyd closed issue #622: [BUG] Migrate volume is missing when volume is detached

2020-08-28 Thread GitBox
rhtyd closed issue #622: URL: https://github.com/apache/cloudstack-primate/issues/622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] davidjumani commented on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
davidjumani commented on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user ---

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user. Perhaps made by some

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user -

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #630: [BUG] Batch-deleting VMs doesn't show as completed when done

2020-08-28 Thread GitBox
davidjumani edited a comment on issue #630: URL: https://github.com/apache/cloudstack-primate/issues/630#issuecomment-682419988 @rhtyd Yes, but I think it's unnecessary. When refreshing the list view every 30 sec, there's always the latest data available to the user, updated by some other

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #632: deployvm: Fixing calling templatefilter=all

2020-08-28 Thread GitBox
davidjumani opened a new pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632 Fixes #605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] davidjumani commented on pull request #632: deployvm: Fixing calling templatefilter=all

2020-08-28 Thread GitBox
davidjumani commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682425051 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #632: deployvm: Fixing calling templatefilter=all

2020-08-28 Thread GitBox
blueorangutan commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682425504 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #633: Fixing networks not shown selected

2020-08-28 Thread GitBox
davidjumani opened a new pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633 Fixes https://github.com/apache/cloudstack-primate/issues/618 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-primate] davidjumani commented on pull request #633: deployvm: Fixing networks not shown selected

2020-08-28 Thread GitBox
davidjumani commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682426383 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #633: deployvm: Fixing networks not shown when selected

2020-08-28 Thread GitBox
blueorangutan commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682426715 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #632: deployvm: Fixing calling templatefilter=all

2020-08-28 Thread GitBox
blueorangutan commented on pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632#issuecomment-682428872 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/632 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #633: deployvm: Fixing networks not shown when selected

2020-08-28 Thread GitBox
blueorangutan commented on pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633#issuecomment-682431849 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/633 (JID-3

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #634: Bug fixes

2020-08-28 Thread GitBox
davidjumani opened a new pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634 Fixes : https://github.com/apache/cloudstack-primate/issues/604 Also : Hide cance button while deploying a vm This i

[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
davidjumani commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682433770 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682434287 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on issue #604: [BUG] EDIT TEMPLATE not on pair with the old UI

2020-08-28 Thread GitBox
davidjumani commented on issue #604: URL: https://github.com/apache/cloudstack-primate/issues/604#issuecomment-682434973 @rhtyd It's just a field used to describe the template but does not have any effect in the service layer --

[GitHub] [cloudstack-primate] rhtyd merged pull request #633: deployvm: Fixing networks not shown when selected

2020-08-28 Thread GitBox
rhtyd merged pull request #633: URL: https://github.com/apache/cloudstack-primate/pull/633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #618: [BUG] A default one network selected, but no networks previously selected

2020-08-28 Thread GitBox
rhtyd closed issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes

2020-08-28 Thread GitBox
rhtyd commented on a change in pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479050862 ## File path: src/views/compute/DeployVM.vue ## @@ -1409,7 +1409,6 @@ export default { this.$router.back() }).catch(error => {

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #634: Bug fixes

2020-08-28 Thread GitBox
rhtyd commented on a change in pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479049921 ## File path: src/views/compute/DeployVM.vue ## @@ -505,7 +505,7 @@ - + Re

[GitHub] [cloudstack-primate] rhtyd commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role

2020-08-28 Thread GitBox
rhtyd commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682438252 @andrijapanicsb please reopen if you can again reproduce it with latest master, thnx This is an automated me

[GitHub] [cloudstack-primate] rhtyd closed issue #605: [BUG] Issue with templateFilter=all for a normal USER role

2020-08-28 Thread GitBox
rhtyd closed issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #632: deployvm: Fixing calling templatefilter=all

2020-08-28 Thread GitBox
rhtyd merged pull request #632: URL: https://github.com/apache/cloudstack-primate/pull/632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #634: Bug fixes

2020-08-28 Thread GitBox
davidjumani commented on a change in pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#discussion_r479053645 ## File path: src/views/compute/DeployVM.vue ## @@ -1409,7 +1409,6 @@ export default { this.$router.back() }).catch(error

[GitHub] [cloudstack-primate] davidjumani commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
davidjumani commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682440535 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682441130 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682443125 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #634: Bug fixes

2020-08-28 Thread GitBox
blueorangutan commented on pull request #634: URL: https://github.com/apache/cloudstack-primate/pull/634#issuecomment-682450253 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/634 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #609: [WIP] Fixes for vapps

2020-08-28 Thread GitBox
blueorangutan commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682456558 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/609 (JID-3

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #635: [BUG] UI should show/hide the Expunge option based on the global settting

2020-08-28 Thread GitBox
andrijapanicsb opened a new issue #635: URL: https://github.com/apache/cloudstack-primate/issues/635 As a regular user role, I've got the option to delete with Expunge, and that fails on backend (not visible in UI): 2020-08-28 10:51:12,561 DEBUG [c.c.a.ApiServlet] (qtp129153987-3317

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #605: [BUG] Issue with templateFilter=all for a normal USER role

2020-08-28 Thread GitBox
andrijapanicsb commented on issue #605: URL: https://github.com/apache/cloudstack-primate/issues/605#issuecomment-682464888 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #606: [BUG] "mine" VMs for Admin, shows also other account's VMs

2020-08-28 Thread GitBox
andrijapanicsb commented on issue #606: URL: https://github.com/apache/cloudstack-primate/issues/606#issuecomment-682465621 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #618: [BUG] A default one network selected, but no networks previously selected

2020-08-28 Thread GitBox
andrijapanicsb commented on issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 This is not good, perhaps broken in some other fix/commit: When the very first template on the Featured list (the one selected by default when you choose a Zon

[GitHub] [cloudstack-primate] andrijapanicsb edited a comment on issue #618: [BUG] A default one network selected, but no networks previously selected

2020-08-28 Thread GitBox
andrijapanicsb edited a comment on issue #618: URL: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 This is not good, perhaps broken in some other fix/commit: When the very first template on the Featured list (the one selected by default when you choos

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #620: [BUG] Set default CPU speed and CPU core count to zero (if not autopopulated from ASIS offering)

2020-08-28 Thread GitBox
andrijapanicsb commented on issue #620: URL: https://github.com/apache/cloudstack-primate/issues/620#issuecomment-682471966 CPU speed is not set to zero, I will reopen once I retest/upgrade packages This is an automated mess

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #629: [BUG] Clicking outside the form (i.e. new offering creation) closes the form

2020-08-28 Thread GitBox
andrijapanicsb commented on issue #629: URL: https://github.com/apache/cloudstack-primate/issues/629#issuecomment-682472357 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #609: [WIP] Fixes for vapps

2020-08-28 Thread GitBox
blueorangutan commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682478601 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/609 (JID-3

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #609: [WIP] Fixes for vapps

2020-08-28 Thread GitBox
andrijapanicsb commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682480525 cpuspeed set to by default - LGTM This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #609: [WIP] Fixes for vapps

2020-08-28 Thread GitBox
andrijapanicsb commented on pull request #609: URL: https://github.com/apache/cloudstack-primate/pull/609#issuecomment-682480708 New issue - described here: https://github.com/apache/cloudstack-primate/issues/618#issuecomment-682468769 ---