rhtyd commented on a change in pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#discussion_r478959264



##########
File path: src/views/project/iam/ProjectRoleTab.vue
##########
@@ -103,7 +108,12 @@
             </span>
           </a-form>
         </a-modal>
-        <a-modal title="Create Project Role" v-model="createModalVisible" 
:footer="null" :afterClose="closeAction">
+        <a-modal
+          title="Create Project Role"

Review comment:
       @Pearl1594 I think these are your feature - can you send another PR that 
fixes the translation keys?

##########
File path: src/views/project/iam/ProjectRoleTab.vue
##########
@@ -61,7 +61,12 @@
             </a-tooltip>
           </span>
         </a-table>
-        <a-modal title="Edit Project Role" v-model="editModalVisible" 
:footer="null" :afterClose="closeAction">
+        <a-modal
+          title="Edit Project Role"

Review comment:
       @Pearl1594 I think these are your feature - can you send another PR that 
fixes the translation keys?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to