[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-03-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

to value objects for one table

2017-03-27 Thread Daan Hoogland
Dear Devs, I just came across a strange oder in the code that might have a background that some of you know about; @Entity @Table(name = "template_spool_ref") public class VMTemplateStoragePoolVO implements VMTemplateStorageResourceAssoc, DataObjectInStore {…} and @Entity @Table(name = "templ

two value objects for one table

2017-03-27 Thread Daan Hoogland
Subject spelling correct ( On 27/03/17 09:15, "Daan Hoogland" wrote: Dear Devs, I just came across a strange oder in the code that might have a background that some of you know about; @Entity @Table(name = "template_spool_ref") public class VMTemplateStoragePoolVO

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-03-27 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1960 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-03-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

Re: two value objects for one table

2017-03-27 Thread Wei ZHOU
the files in engine/storage/src/org/apache/cloudstack/storage/volume/db are not in use. They can be removed. The lines in engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml also need to be removed. -Wei 2017-03-27 9:23 GMT+02:00 Daan Hoogland : > Subjec

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread yvsubhash
Github user yvsubhash commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM for code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

Re: two value objects for one table

2017-03-27 Thread Daan Hoogland
Wei, That means deleting the one that has been touched last, but you are right. It also leads me to a bunch of other classes that can be deleted ( On 27/03/17 10:19, "Wei ZHOU" wrote: the files in engine/storage/src/org/apache/cloudstack/storage/volume/db are not in use. They can

[GitHub] cloudstack issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-03-27 Thread niteshsarda
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/905 I have tested this and **LGTM** for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #876: CLOUDSTACK-8865: Adding SR doesn't create Storage_poo...

2017-03-27 Thread mrunalinikankariya
Github user mrunalinikankariya commented on the issue: https://github.com/apache/cloudstack/pull/876 LGTM on the code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack issue #1734: CLOUDSTACK-9567 Difference in the api call outputs f...

2017-03-27 Thread jayantpatil1234
Github user jayantpatil1234 commented on the issue: https://github.com/apache/cloudstack/pull/1734 I have tested this and **LGTM** for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

S3 as Secondary Storage

2017-03-27 Thread Will Stevens
Hey All, If anyone is using S3 as Secondary Storage in production (or even testing at this point), please respond to this thread. We have been using Swift in production for the last couple years and I think we have worked out most of the kinks. Not all of our fixes have been pushed upstream yet b

[PROPOSAL] Storage Load Balancing

2017-03-27 Thread Anshul Gangwar
Hi All, I would like to propose the storage load balancing feature. Please find the FS for the same at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Load+balancing. Regards, Anshul DISCLAIMER == This e-mail may contain privileged and confidential information which is

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

2017-03-27 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1971 @borisstoyanov ran test/integration/component/maint/test_redundant_router.py . Test create network with non-default guest cidr with redundant routers ... === TestName: test_create

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Rafael Weingärtner
Sorry for the delay guys. I have been a little busy lately. I will write down a wiki page detailing the code retirement steps. Then, I will proceed and kick off the Midonet plugin retirement process. On Mon, Mar 20, 2017 at 3:39 AM, Daan Hoogland wrote: > Don’t worry Marty, non-committers/-code

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Erik Weber
Personally I would be in favour of using releases rather than months as time unit. Our release schedule is very unpredictable, and it's hard to foresee how many releases we've rolled out in 6 months. Deprecate in the next (4.11?), remove a few releases later (4.13?). -- Erik On Sat, Mar 18, 201

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @cloudsadhu Thanks for the changes. LGTM on the code review. @borisstoyanov @rhtyd @DaanHoogland Can you kick off another round of test for vmware and Xen for this PR ? --- If your project is s

Re: S3 as Secondary Storage

2017-03-27 Thread Wido den Hollander
> Op 27 maart 2017 om 14:09 schreef Will Stevens : > > > Hey All, > If anyone is using S3 as Secondary Storage in production (or even testing > at this point), please respond to this thread. > We are. Using Ceph's RADOS Gateway (Hammer, 0.94.11) as the gateway with CloudStack 4.5 (Yes... ;( )

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-27 Thread wido
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1955 Yes, we are indeed ready for a merge. Shall we do that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: S3 as Secondary Storage

2017-03-27 Thread Will Stevens
Thanks Wido. Yes, we have the same 'outdated' SDK being used issue for Swift as well. It is embedded in the code and it is ancient. I have not had a chance to get in there and update to a recent library. We upgraded our setup from 4.4 -> 4.7 and we are in the process of validating 4.10 as our n

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Daan Hoogland
I am against that Strain on the community is not in releases but in time. We already guarantee it is at least one minor On 27/03/17 15:24, "Erik Weber" wrote: Personally I would be in favour of using releases rather than months as time unit. Our release schedule is very unpredictabl

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

2017-03-27 Thread rossor
Github user rossor commented on the issue: https://github.com/apache/cloudstack/pull/1606 Is it appropriate to add a comparatively complex integration test to cover a functional predicate whose cognitive load is so small? I will expand the associated unit test to include bound

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Will Stevens
I think we are planning to do something like "at least 6 months" because of the irregularity of releases. This gives us a date (from when the announcement was release becomes available) till the PR to remove gets merged. That PR will then be included in the next release whenever it is. So if the

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2019 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-03-27 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1960 Trillian test result (tid-963) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34953 seconds Marvin logs: https://github.com/blueoranguta

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Rafael Weingärtner
The process described by Will is what I was seeing/understating so far. Thus, we do not need to be bound by a specific release, but rather by a timeline. After the PR that includes the removal/disabling of the plugin gets merged (will happen according to the timeline defined) the changes will be in

Re: [DISCUSS] Retirement of midonet plugin

2017-03-27 Thread Erik Weber
Sounds good :-) Erik man. 27. mar. 2017 kl. 18.03 skrev Will Stevens : > I think we are planning to do something like "at least 6 months" because of > the irregularity of releases. This gives us a date (from when the > announcement was release becomes available) till the PR to remove gets > me

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi requesting you to merge these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-27 Thread karuturi
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 Thank you all. I will merge #1961 and #1994 now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request #1961: Fix for test_snapshots.py using nfs2 instead ...

2017-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1994: CLOUDSTACK-9827: Storage tags stored in multi...

2017-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1994 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/2019 @SudharmaJain Although the PR fixes the tests but it is not correct. I looked at PR #1953 and the changes there are incorrect. getMaxDataVolumes() returns only the data volume count

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-03-27 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1953 @karuturi This PR is not correct and is resulting in travis CI failures. It needs to be properly fixed. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-03-27 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1960 @rhtyd there seems to be a conflict for this merge, I'm currently running tests and will keep you posted --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1844: CLOUDSTACK-9668 : disksizeallocated of PrimaryStorag...

2017-03-27 Thread jayakarteek
Github user jayakarteek commented on the issue: https://github.com/apache/cloudstack/pull/1844 Tested the scenario. results are as below select * from storage_pool; # id, name, uuid, pool_type, port, data_center_id, pod_id, cluster_id, used_bytes, capacity_bytes, host_addre

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread SudharmaJain
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/2019 Thanks @koushik-das for reviewing this. So Let me close this and root volume detach should also be fixed as a part of PR #1953. --- If your project is set up for it, you can reply to this