Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398614
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import java.u
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398722
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import java.u
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90398972
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import java.u
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@rhtyd I've spend some time and found out what was wrong with the
test_01_snapshot_root_disk
the issue come from the way snapshot name has been stored in the DB:
- in 4.8: sna
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399018
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import java.u
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399065
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import java.u
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90399606
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
@Over
GitHub user terbolous opened a pull request:
https://github.com/apache/cloudstack-www/pull/29
Added Delimiter Corp to known users
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/terbolous/cloudstack-www master
Alternatively you
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
I guess that needs to go only in 4.10 then @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/828
Packaging result: âcentos6 âcentos7 âdebian. JID-292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
Packaging result: âcentos6 âcentos7 âdebian. JID-293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90401765
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -150,26 +155,26 @@ public SslCertResponse uploadSslCert(UploadSslCertCmd
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-295
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402383
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd
deleteSslC
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402608
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402626
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90402863
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403174
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1802
LGTM based on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403775
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403957
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90403899
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404003
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404197
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404400
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90404501
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse(SslCertVO
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/873
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/873
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90405645
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
@Over
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90405628
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword()
t
Github user sureshanaparti commented on the issue:
https://github.com/apache/cloudstack/pull/828
@rhtyd Changed base branch to 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/828
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/828
@karuturi I understand these words: "help", "hello", "thanks", "package",
"test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'cent
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/828
@blueorangutan test centos6 vmware-55u3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/828
@karuturi a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/828
Thanks @sureshanaparti
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90411487
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under o
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90411534
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under o
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1784
@jburwell made the appropriate changes.
@murali-reddy impact of multiple NIC on DNS do you think we add a test
for that too ?
---
If your project is set up for it, you can re
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@jburwell I've fixed couple of more issues, and the issues from your code
review. Thanks for your comments.
@blueorangutan package
---
If your project is set up for it, you can reply to this
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@jburwell good to have this, not sure how many people maybe using
container/docker based mgmt servers?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1)
has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have y
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
Packaging result: âcentos6 âcentos7 âdebian. JID-297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
re
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt
+ vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
---
If your project is set up for it
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
LGTM, we found the issue happens only in master branch (ref #1754). The fix
is applicable only on master, the PR's base branch has been fixed and test has
been verified manually by @borisstoyanov
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1800
Packaging result: âcentos6 âcentos7 âdebian. JID-298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@mike-tutkowski @nvazquez @syed ping, it seems there were some changes on
master due to which snapshot file names on xenserver now have `.vhd` extension
which was not seen in 4.8, 4.9 branches. I
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1802
Trillian test result (tid-515)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26871 seconds
Marvin logs:
https://github.com/blueoranguta
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r90438253
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -538,7 +562,7 @@
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r9043
--- Diff: server/src/com/cloud/network/NetworkModelImpl.java ---
@@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp,
Service
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1618
Updated to latest master, and now with a JIRA ticket.
https://issues.apache.org/jira/browse/CLOUDSTACK-9643
---
If your project is set up for it, you can reply to this email and hav
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1622
Updated to latest master, and a JIRA ticket has been created.
https://issues.apache.org/jira/browse/CLOUDSTACK-9644
---
If your project is set up for it, you can reply to this email
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1566
Updated to latest master, and a JIRA ticket now exists.
https://issues.apache.org/jira/browse/CLOUDSTACK-9645
---
If your project is set up for it, you can reply to this email and h
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd We have now resolved all your review comments including adding of
the requested unit test coverage, and we have rebased this PR with the latest
master (i.e. contains PR #1801 fix).
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@rhtyd agreed. I apologize for being unclear -- I would like to get this
PR into 4.9.1.0, but it is not a release blocker.
---
If your project is set up for it, you can reply to this email an
Github user ProjectMoon commented on the issue:
https://github.com/apache/cloudstack/pull/1617
We are in the process of fixing the conflicts. The rebase worked fine, but
we have to rewrite one of the new unit tests to not use the `UsageEventEmitter`.
---
If your project is set up for
Github user resmo commented on the issue:
https://github.com/apache/cloudstack/pull/1435
I used it for development and testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1435
I've retested the management server, it work with Jenkins as the build is
back online.
@jburwell, do you know if there is a way to squash a commit within the same
PR ?
---
If your pr
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450802
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed to
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457877
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450578
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457155
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451135
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed to
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451387
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43 @@
+//
+// Lice
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90453232
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -339,34 +398,63 @@ private void updateDhcp
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451818
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -387,41 +400,39 @@ public boolean canEnableIndiv
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451522
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43 @@
+//
+// Lice
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90453536
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -339,34 +398,63 @@ private void updateDhcp
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90458374
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450669
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450606
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455021
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java
---
@@ -0,0 +1,78 @@
+//
+// Licensed t
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455401
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450632
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455612
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450815
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed to
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451924
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -387,41 +400,39 @@ public boolean canEnableIndiv
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90452834
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -317,20 +368,28 @@ private void updateDhcp
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451456
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43 @@
+//
+// Lice
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90456898
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90452488
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -255,7 +284,30 @@ public void reserve(NicP
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455598
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90454905
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java
---
@@ -0,0 +1,78 @@
+//
+// Licensed t
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457477
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310 @@
+//
+// Li
Hi,
I have recently experienced OOM killer killing 1 production VM on KVM host,
which was no fun obviously. But more importantly, I had swap used 95%
(16GB) and similar percentage of RAM used at the time of incident -
something I need to investigate on my own, but naturally here OOM killer
kicked
Github user murali-reddy commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@jburwell this PR is ready for merge. PR fixes intermittent failures of
suite of tests in test_privategw_acl.py.
test_04_rvpc_privategw_static_routesSuccess 553.97
test_pr
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1675
@abhinandanprateek ping re: closing this PR in favor of #1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@jburwell a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
Tests look good on KVM. However, it seems like a Good Thing(tm) to test on
KVM and XenServer as well.
@blueorangutan test centos7 vmware-55u3
@blueorangutan test centos7 xenserver-
1 - 100 of 214 matches
Mail list logo
