Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90453232
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -339,34 +398,63 @@ private void updateDhcpOptionsForExistingVms(Network
network, HostVO nuageVspHos
}
}
+ private void checkMultipleSubnetsCombinedWithUseData(Network network){
+ if
(_ntwkOfferingSrvcDao.listServicesForNetworkOffering(network.getNetworkOfferingId()).contains(Network.Service.UserData.getName())
&& _vlanDao.listVlansByNetworkId(network.getId()).size() > 1) {
--- End diff --
Please consider using `isEmpty` rather than a size check to determine
whether or not a list has elements. It is more idiomatic/expressive and less
error-prone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
