[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220737825 This is one of the only PRs I have seen consistently failing on the scale vm test. I am not sure what to think about that. Can you rebase and force push or close an

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-220738113 @remibergsma can you give me a status on this PR. I know you reverted it because of missing licenses. Should I be trying to wait for this one to get back in for 4.9

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220738431 I would like to get this one re-pushed or closed and reopened so we can kick the CI again to see if we can get things green. I am getting very close to freezing and

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-220738747 Getting close to freeze, please repush to see if we can get travis green. Thx... --- If your project is set up for it, you can reply to this email and have your rep

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
Concerning the _s, checkstyle takes offence of those in changed lines of code. So i am wondering how people can get new _s in. send by tablet, no warranties in existence On 21 May 2016 00:55, "Will Stevens" wrote: > I can confirm we currently have Zero HyperV tests in CI. Once we have more > pe

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-220738889 @ustcweizhou ^ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-220738801 @syed: Getting close to freeze, please repush to see if we can get jenkins green. Thx... --- If your project is set up for it, you can reply to this email and have

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread Daan Hoogland
Yes, Will. And it is xen specific. send by tablet, no warranties in existence On 21 May 2016 00:59, "swill" wrote: > Github user swill commented on the pull request: > > https://github.com/apache/cloudstack/pull/1297#issuecomment-220737825 > > This is one of the only PRs I have seen con

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-220739003 @syed please close and reopen or repush. we are close to freeze and I want to get some of these PRs in... --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1297 CLOUDSTACK-9203 Implement security group move on updateVM API call cherry-picked from a exoscale internal fix Conflicts: api/src/org/apache/cloudstack/api/command/user/

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220739198 @swill I think it is genuine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: [CLOUDSTACK-9337]Enhance vcenter.py to cr...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1464#issuecomment-220739360 @sanju1010 I don't know what to do with this one. I don't have any verification that this PR works, so I am not sure what information I am supposed to be going on to

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220739661 @DaanHoogland you think the issue that travis is having is a genuine issue, is that what you mean? --- If your project is set up for it, you can reply to this email

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Does it take offense at a file level or a line of code level? If it is at the file level, then it makes sense because people follow the standard presented in the file and that file is already accounted for in the checker threshold. On May 20, 2016 7:06 PM, "Daan Hoogland" wrote: Concerning the _s

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220740982 Yes, I'm just not sure it is Travis or the xen plug-in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
In the mutiny PR I had to change the names that I put final in front so that implies line level. send by tablet, no warranties in existence On 21 May 2016 01:19, "Will Stevens" wrote: > Does it take offense at a file level or a line of code level? If it is at > the file level, then it makes sens

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220741573 OK. I don't really have the bandwidth to troubleshoot this (unfortunately). This is one of the many PRs that are on the bubble which I am trying to figure out what t

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Unless that PR was not already accounted for in a grandfathered exception. On May 20, 2016 7:26 PM, "Daan Hoogland" wrote: > In the mutiny PR I had to change the names that I put final in front so > that implies line level. > > send by tablet, no warranties in existence > On 21 May 2016 01:19, "W

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220742798 I might find the time but it is long since I worked with xen. Also I must find new joy for this hobby. So no promises --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-220745686 Have a nice weekend. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
Yes, the mirror site would be on github or apache.org Step 6 in the install guide would have instructions like: a. Install System VM Templates: b. Installing other templates cloud-install-tmplt > enter OS (linux only) > Ubuntu 16.04 Installing... Or, step (b) could generate a cloudmonk

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don't

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-220755087 the sweet sweet color green... 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Hyper-V communication broken by change in...

2016-05-20 Thread mike-tutkowski
GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1556 Hyper-V communication broken by change in variable names Change variable names back to fix communication with Hyper-V Agent: https://issues.apache.org/jira/browse/CLOUDSTACK-9383

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Hi, Please feel free to review the following PR that should address this matter by reverting certain variable names back the way they were prior to PR #816: https://github.com/apache/cloudstack/pull/1556 Thanks! Mike From: Will Stevens Sent: Friday, May

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
CI is running. Thx... :) On May 20, 2016 11:11 PM, "Tutkowski, Mike" wrote: Hi, Please feel free to review the following PR that should address this matter by reverting certain variable names back the way they were prior to PR #816: https://github.com/apache/cloudstack/pull/1556 Thanks! Mike

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread ustcweizhou
Github user ustcweizhou closed the pull request at: https://github.com/apache/cloudstack/pull/1410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-05-20 Thread ustcweizhou
GitHub user ustcweizhou reopened a pull request: https://github.com/apache/cloudstack/pull/1410 CLOUDSTACK-6928: fix issue disk I/O throttling not applied Disk IO throttling (for KVM) is not applied in the merge of 4.2. Tests passed: (1) start vm (2) attach volume

<    1   2