Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

2016-05-20 Thread Shweta Agarwal
Congrats Will! Thanks Shweta On 5/20/16, 10:36 AM, "Ardhendu Shekhar" wrote: >Congratulations, Will. > >Regards, >Ardhendu > >Ardhendu Shekhar >Senior Manager, Program Management | CloudPlatform | Accelerite, Hyderabad | >Extn: 29370 | Desk: +91 40 6742 9370 | Cell: +91 988-500-2788 | >ar

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-20 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-220533410 With java 8 we will also get enhanced testing frameworks, specially junit-quickcheck, that will help us in writing more expressive and compact test cases.

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220533786 @swill the error suggests the template response is missing the key 'status' in its json response. It may happen if there has been any change around template (response

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2016-05-20 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r6362 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -594,6 +597,25 @@ private PlugNi

RE: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Paul Angus
I'm a -1 on adding another step to the installation process. I agree with Will, it will only be another barrier to platform adoption. The SSVM going and downloading the built-in template is a good milestone in a CloudStack build. To be honest the mgmt. server should be able to go get the templa

Re: Regarding: "AmazonEC2stub.java"

2016-05-20 Thread Daan Hoogland
OK, those were generated files that are now removed from the project. send by tablet, no warranties in existence On 20 May 2016 08:58, "sangeeta lal" wrote: > Dear Sir, > > I am using version 4.3.0. > > Thanks for your reply! > > On Fri, May 20, 2016 at 12:03 PM, Daan Hoogland > wrote: > >> Sa

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220545220 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220545140 @swill let's merge this? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1553 Explicitely load JDBC driver before creating our MySQL connections Solution to the mailing thread titled "MySQL : No suitable driver found for jdbc:mysql". It doesn't harm that we explicite

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220546975 @swill, @rhtyd, @kiwiflyer, triggering you guys because you were part of this mailing thread. --- If your project is set up for it, you can reply to this email and

Re: Regarding files generated by WSDL

2016-05-20 Thread Rohit Yadav
Sangeeta, We've remove wsdl auto-generates files (the awsapi package) from CloudStack. In the past, these files were generated by aws wsdl description [1] to generate client code for an EC2 compatible API that would work with CloudStack. [1] https://en.wikipedia.org/wiki/Web_Services_Descriptio

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220547372 LGTM, I am aware about the issue and the changes are therefore needed. Thanks @nlivens --- If your project is set up for it, you can reply to this email and have yo

RE: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Daan Hoogland
send by tablet, no warranties in existence On 20 May 2016 09:29, "Paul Angus" wrote: > > I'm a -1 on adding another step to the installation process. > > I agree with Will, it will only be another barrier to platform adoption. > > The SSVM going and downloading the built-in template is a good mile

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/669#discussion_r64009630 --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java --- @@ -594,6 +597,25 @@ private Plug

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220558485 @swill The failures are not related to this PR. The failure in test_internal_lb.py is due to some cleanup issue. The network deletion failed most probably du

[GitHub] cloudstack pull request: API: improve resource limits comprenhensi...

2016-05-20 Thread marcaurele
GitHub user marcaurele opened a pull request: https://github.com/apache/cloudstack/pull/1554 API: improve resource limits comprenhension Add resource type name in request and response. You can merge this pull request into a Git repository by running: $ git pull https://github.c

Re: Regarding: "AmazonEC2stub.java"

2016-05-20 Thread sangeeta lal
Dear Sir, Thank You for the information. I highly appreciate you reply. Thank You On Fri, May 20, 2016 at 1:02 PM, Daan Hoogland wrote: > OK, those were generated files that are now removed from the project. > > send by tablet, no warranties in existence > On 20 May 2016 08:58, "sangeeta lal"

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220562852 @nvazquez Thanks for the fix. As @DaanHoogland mentioned please add license header to the newly added file. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1511#discussion_r64015658 --- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java --- @@ -429,60 +434,42 @@ private void validateChain(List chain, Certific

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx
Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220576106 Yes, correct, and thanks @DaanHoogland. Could you initiate for more reviews; or anything i can do? Thx --- If your project is set up for it, y

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220577391 @KrisSterckx yes you can; For instance ping @swill, @rhtyd, @koushik-das, @remibergsma, @abhinandanprateek, @rafaelweingartner @GabrielBrascher any reviews?

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220579267 @swill I have pushed the new version of the commits @rhtyd @DaanHoogland Thanks for your review and feedback. Should be good now I think. --- If your project

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220583491 Thanks! code-wise this looks good to me now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: SystemVM cleanups

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1540 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220594320 ### CI RESULTS ``` Tests Run: 83 Skipped: 0 Failed: 0 Errors: 2 Duration: 8h 53m 51s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220595138 This is a passing CI now. @koushik-das do you have anything outstanding with this PR? @nvazquez can you close and reopen or do a force push to kick off a Jen

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220595610 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 21m 39s ``` **Summary of the p

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1555 Add Java Default Certificat Authorities into the keystore if using a custom cert SSL Related to CLOUDSTACK-1475 You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220595800 Im not sure what to think of those failures. I will run again in clean setup to see if I can get rid of those. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220595991 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 4h 12m 50s ``` **Summary of the p

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220596270 I am getting similar errors in other PRs, so I don't think they are related to this PR. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220599638 LGTM, do we retest @swill? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220599141 @DaanHoogland, triggering you for review as well, this is only a small code change --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1553#discussion_r64040574 --- Diff: framework/db/src/com/cloud/utils/db/TransactionLegacy.java --- @@ -1014,6 +1014,13 @@ public static void initDataSource(Properties dbProps

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220608044 Thanks @swill @koushik-das! Sorry I was missing a license header, I pushed it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r64042208 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java --- @@ -0,0 +1,30 @@ +package org.apache.cloudstack.s

Re: Refactoring CitrixResourceBase

2016-05-20 Thread Syed Mushtaq
Thanks guys for the Ideas. I will open a JIRA ticket and start working on it. -Syed On Thu, May 19, 2016 at 7:57 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi Syed, > That is a great idea; however, it is a very hard task. > The idea of Tim is great; actually, we already have

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-20 Thread footplus
Github user footplus commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220615734 LGTM :) It seems to work correctly on my 4.8.0 setup. Thanks. Best regards, Aurélien --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220615109 @swill nothing outstanding on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220619741 For some reason Travis is unhappy. Would you mind trying again. Sorry for the inconvenience... --- If your project is set up for it, you can reply to this email an

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220621430 @DaanHoogland yes, I will retest now. Thanks guys... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220622074 Can I get some code review on this one. It is looking to be in pretty good shape otherwise. Thanks... --- If your project is set up for it, you can reply to this e

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220624878 I have seen similar issues in a couple other PRs. Since this is a PR related to connectivity, I do want to try to get a cleaner CI run if I can. Also, travis is fai

RE: [Discuss] CloudStack documentation

2016-05-20 Thread Rajsekhar K
Hi, All, I agree with Dag Sonstebo that we need to improve the layout and navigation of CloudStack documentation. I think that the improvement should begin from the home page. New users may not find the way the information presented on the home page very intuitive. A few tweaking on the home p

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220626559 @rhtyd thank you. I will review what happened there. This is something that has started showing up intermittently, but only started happening in the last few weeks.

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220627549 Thanks @koushik-das, I need to track down what changed to cause that intermittent problem of the `template.status`. I need some code review on this one. Thanks...

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220627907 ### CI RESULTS ``` Tests Run: 83 Skipped: 0 Failed: 0 Errors: 2 Duration: 8h 27m 27s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220628087 Two clean runs in a row. I think this one is ready to put back in now... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220628402 BTW, thank you for your quick response time to work through issues on your PRs and get things stabilized. I really do appreciate it. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220628656 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 0 Errors: 4 Duration: 8h 31m 38s ``` **Summary of the p

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1251#issuecomment-220628965 Similar issues on this run. They are not related to this PR. Still need some review on this one... --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220629958 This one is coming back clean. If we can get Jenkins and Travis green I think this one is ready... --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-220629640 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 44m 23s ``` **Associ

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1417#issuecomment-220631924 Ok, thanks @nitt10prashant. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220632778 Ya, sorry, I had a backlog of commits that were ready while I sorted out some merge conflicts doing a forward merge from 4.8 and then testing the resulting master to

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220633650 @sverrirab thank you. Would you mind adding the revert of #1495 into this commit in order to clean up unnecessary packages once this PR is accepted? I think we are

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
Hi guys, I agree with Daan that if class fields have improper (not descriptive or not suitable) names we should change them. However, I do not find the change (on variable names) introduced by PR #816 good. It added an “_”(underline) before variable names; even though Apache CloudStack has a lot of

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220637398 @swill please see my comment above about the travis failures. BTW why is there sometimes two travis runs (pr and push) and sometimes only one? --- If your pro

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
It might be a total pipe dream, but if the API was also Swagger compliant, it would simplify our API documentation and would make API tooling much easier. I have not looked into what would be required, but it would definitely be a nice to have. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cl

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Daan Hoogland
Rafael [2] is a members only link (pornographia academia?) On Fri, May 20, 2016 at 5:12 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi guys, > I agree with Daan that if class fields have improper (not descriptive or > not suitable) names we should change them. However, I do not

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-220640589 Ok. Travis has been pretty consistently green for PRs recently, so I have not seen this problem elsewhere. I am not sure why there are sometimes more than once Trav

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
Hahaha, do not get addicted to it Daan ;) That is probably due to the environment I am living in right now. I am not a member per se of the GsonLD project [2]; I have just used it in another research/work. So, there is this protocol called OpenID Connect, and one of the things we did not like muc

[GitHub] cloudstack pull request: Convert patchviasocket to python (removes...

2016-05-20 Thread sverrirab
Github user sverrirab commented on the pull request: https://github.com/apache/cloudstack/pull/1533#issuecomment-220644228 Rebased the PR to latest master and reverted the relevant commit (64b72a5c5a410f41bd869cc9d40807d888e05055.). I think we should be good to go @swill ? --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018 @swill Travis passed. Looks like it is ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
It sounds like most people don't like a preceding "_" for member variables and that is fine. Do we have any formal Java coding standards for CloudStack, by the way? I'm not aware of any. The main problem here, though, is that this particular piece of code is super fragile, so it would be great

[GitHub] cloudstack pull request: Refactor system VM default network creati...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-220656462 ### CI RESULTS ``` Tests Run: 82 Skipped: 0 Failed: 1 Errors: 4 Duration: 10h 22m 36s ``` **Summary of the

[GitHub] cloudstack pull request: Refactor system VM default network creati...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1360#issuecomment-220656774 Ran again because the error was not something I had seen often. The errors in the new run are not related to this PR. --- If your project is set up for it, you can

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
You are right Mike about the “_”. The point is that in some other language the use of “_” makes sense, whereas in Java it does not, at least not the way it has being used in ACS. We have code conventions, it can be found in [1]. The problem is that it is a bit outdated and I think it could benefit

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Also, does this mean that we have zero Hyper-V integration tests run during CI? From: Tutkowski, Mike Sent: Friday, May 20, 2016 10:47 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents Yeah, it has to go into 4.9.

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
I think that if we say we support Hyper-V we should care about it. On Fri, May 20, 2016 at 1:47 PM, Tutkowski, Mike wrote: > Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V. > > From: Rafael Weingärtner > Sent: Friday, May 20, 2016 10:4

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Yeah, I'm just teasing. :) The PR needs to go into 4.9 to fix Hyper-V. From: Rafael Weingärtner Sent: Friday, May 20, 2016 10:49 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents I think that if we say we support H

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
:) According to Raja, there is some time before download.cloud.com is doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec 25, 2016 and we're still debating mirror list vs steps and what not. Now, just change the 2017 to 2016 and re-consider. We need this done yesterday!

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
I noticed ;) Yes, we do not have Marvin tests for Hyper-V (at least that is what I know). I believe most of the tests that are being executed nowadays use either KVM or XenServer; some people might be executing few of them too in VMware environments. On Fri, May 20, 2016 at 1:50 PM, Tutkowski, M

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
Agree with Daan : we shouldn't be pushing these ancient insecure templates! On Fri, May 20, 2016 at 9:51 AM, Chiradeep Vittal wrote: > :) According to Raja, there is some time before download.cloud.com is > doomed. Let's pretend that date is Jan 1 2017. Now pretend that it is Dec > 25, 2016 and

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Tutkowski, Mike
Yeah, it has to go into 4.9. :) Unless no one cares about Hyper-V. From: Rafael Weingärtner Sent: Friday, May 20, 2016 10:42 AM To: dev@cloudstack.apache.org Subject: Re: Variable renaming in classes meant for Agents You are right Mike about the “_”. The p

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Chiradeep Vittal
I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I realized that someone needs to own the account. There is no legal entity for Apache CloudStack (except the ASF) that can enter into a contract with AWS (even if it is for a few bucks a month). To make this work, alternatives

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Rafael Weingärtner
We could host a mirror here. We are in South America, Brazil. On Fri, May 20, 2016 at 2:01 PM, Chiradeep Vittal wrote: > I was proposing a new S3 bucket earlier (templates.cloudstack.org), but I > realized that someone needs to own the account. There is no legal entity > for Apache CloudStack (e

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Daan Hoogland
is there no way, within foundation bylaws, to host this somewhere on apache.org? we are using peoples wibesites for tests as well, aren't we. On Fri, May 20, 2016 at 7:04 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > We could host a mirror here. We are in South America, Brazil. >

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread KrisSterckx
Github user KrisSterckx commented on the pull request: https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799 Thanks @swill. Folks, pls review :) Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64078451 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java --- @@ -270,15 +258,15 @@ public PingCommand g

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

2016-05-20 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1494#discussion_r64080090 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java --- @@ -0,0 +1,370 @@ +// +// Licensed to the

Re: [Discuss] CloudStack documentation

2016-05-20 Thread Ron Wheeler
A couple of comments. The definition of the audience for each document should be clearly understood. Size: What is targeted for large organizations (hundreds of servers) with dedicated staff and sophisticated needs - what is targeted for SMB (5-50 servers) with limited staff and simple needs.

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220675652 Thanks @swill if we keep getting this error, I'll try to find some time to see what's causing this as well --- If your project is set up for it, you can reply to thi

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220675936 @swill thank you for your time in testing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220715003 And of course the first build I do after I merge it into master I get the `addHost` error and I did not get it once after I pulled it out. Haha... I will build agai

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220715486 @rhtyd can you specify the logs you need if I run into this issue so you can track down why it is happening? I will leave it in for now but I would like to send you

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220715917 I am getting it on almost every PR right now (if you notice the last 6 or 7 CI runs), so I will have to review this as it seems to have been introduced recently...

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220716022 I think since it is an intermittent issue, we did not catch it on the actual PR it was introduced in. --- If your project is set up for it, you can reply to this ema

Re: Migrating CloudStack content from download.cloud.com

2016-05-20 Thread Will Stevens
Cant we just host the mirror list in apache.org and then actually host the mirrors in different places around the world? A company could sponsor the few bucks a month for AWS and have one of the mirrors be in AWS and the mirror list in apache.org would just be updated to add the AWS mirror. Isn't

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220735448 @rhtyd uggg... The first two builds on master after merging this back in have both resulted in the `addHost` error. :( Let me know what you need to troubleshoot th

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
Can you add your link for [1], I think you forgot to add the link. I was not aware of a coding standard for this project. I know there has been debated a lot recently about the preceding `_` on some variables. Historically it was done that way, but recently a lot of people have taken offense to i

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Rafael Weingärtner
You are right Will. I am sorry for the link, here it is: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions On Fri, May 20, 2016 at 7:52 PM, Will Stevens wrote: > Can you add your link for [1], I think you forgot to add the link. I was > not aware of a coding standard for

Re: Variable renaming in classes meant for Agents

2016-05-20 Thread Will Stevens
I can confirm we currently have Zero HyperV tests in CI. Once we have more people contributing to CI we can try to get better coverage, but right now I am pretty much just testing on KVM. I know the accelerite guys are testing on Xen. Once I freeze, I will try to do testing of master in as many

  1   2   >