Pierre,
I meant the auto-download of default templates, not systemvm.
Note that the initial systemvm template has to be hand-downloaded anyway.
If you are a single hypervisor cloud, then that is all that is needed.
On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion
wrote:
> I would be -1 about di
Hey Everyone,
As Seb alluded to in the VP announcement thread, we have some reasonably
big news to report.
As many of you know, we have been working with the ASF to find ways to
better utilize the features of Github. Github has been working very well
as a medium for managing pull requests and han
Hi All,
I would like to refactor CitrixResourceBase class which is responsible for
communicating with Xenserver. It has grown too long (>5K lines) and has
absolutely no testing.
In my first pass I want to separate out the functionality buy the subsystem
it targets (compute, storage, network etc)
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-220427628
@koushik-das I pushed new changes including an intermediate class as you
suggested
@swill hopefully CI passes now
---
If your project is set up for it, you ca
+1
When I went through this last time, not only was it hard to understand the
flows, but the XenServer version management was a pain. Would suggest
creating a base class which always works (i.e. is independent of XenServer
version) for core functions. Then add in that which exists for a specific
v
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220431955
This is failing to build for me.
```
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elaps
Syed,
gogogo. actually it has shrunk to 5k lines since 2012 ;)
I like your initiative and initial direction. A lot of small steps to
improve the blob have been taken and I would sugest to keep going in small
steps.
On Thu, May 19, 2016 at 9:44 PM, Tim Mackey wrote:
> +1
>
> When I went through
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220433360
@swill I must have made a booboo spliting the style parts from the test
upgrades. I will look at it over the weekend.
---
If your project is set up for it, yo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220440726
@swill I will work on the changes tomorrow morning (my time, CET).
Shouldn't be very hard to do.
---
If your project is set up for it, you can reply to this email and
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220446031
LGTM.
Tested manually with a real test deployment of CS49, with my French azerty
keyboard: works fine.
---
If your project is set up for it, you ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220447959
I think with @milamberspace's review, we are only missing one code review
to get this one in. Thanks everyone...
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63955721
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java
---
@@ -0,0 +1,30 @@
+package org.apache.cloudsta
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220458013
thanks @KrisSterckx, and to make it even more very clear: basically you
will only need to install acs and nuage and configure them correctly. neat. you
guys ar
Chiradeep,
It makes sense not to have this old default very insecure guest template
still be downloaded but it would be nice to have some kind of meta-data
pointing to the latest version of an acceptable template (symlink) for
trial installs so PoCcers are swiftly on their way. Would you agree?
O
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959496
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
I definitely agree with this. I don't think people doing a PoC should have
to worry about getting a template installed on first setup. I think that
is a basic feature if we want platform adoption. Getting the first boot
process from download to first VM launched should be as smooth as possible.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959351
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private Plug
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63959786
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960622
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1298,6 +1304,27 @@ private static DiskTO g
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960701
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -5402,4 +5402,20 @@ public boolea
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63961096
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCopyFileInVmCommandWrapper.java
---
@@ -0,
Well, you have to define "worry" :)
I'm proposing an almost identical step to
http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.6/management-server/#prepare-the-system-vm-template
If they can do that, then it is not a stretch to assume they can download
the default template
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-220464828
Really like the functionality so I think we must get this in. I have some
remarks about the code that I stand by even though they are not entirely to
blame on @
sounds good, so if we put both sections together the worry is over. acs is
a complex system and requires a lot of reading so let''s not put it in a
different section. would be duplicate code anyhow.
On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal
wrote:
> Well, you have to define "worry" :)
>
Hi Syed,
That is a great idea; however, it is a very hard task.
The idea of Tim is great; actually, we already have some sort of hierarchy
that is used in “CitrixResourceBase.java”.
I would suggest you first removing the unused code, unused variable, and
duplicate methods; that would be one PR. You
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-220505362
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 18m 28s
```
**Associ
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988200
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private PlugNi
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988285
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1298,6 +1304,27 @@ private static DiskTO get
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63988259
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1549#issuecomment-220511743
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 51m 55s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1549#issuecomment-220511825
I am going to run the test again because it was an intermittent issue, so a
couple tests is not a bad idea.
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1551#issuecomment-220511935
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 29m 09s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1551#issuecomment-220512003
These errors are not related to this PR, but if you know where these errors
are coming from I would be interested in some input. :)
---
If your project is set up fo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220512147
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 1
Errors: 4
Duration: 9h 31m 01s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220512305
I don't think these issues are related to this PR, but if you have any
insight as to why they might be happening I would be interested. I will run
this CI again to s
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220512436
@mike-tutkowski I believe class name ending in Command signifies that they
are meant for agent and should be treated like API params.
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220512458
### CI RESULTS
```
Tests Run: 78
Skipped: 0
Failed: 0
Errors: 4
Duration: 7h 47m 49s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-220512533
These failures are not related to this PR, but if you have ideas why they
are happening I would be interested. I will wait till @wido has a chance to
work on this PR
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-220512874
### CI RESULTS
```
Tests Run: 84
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 36m 08s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/846#issuecomment-220513570
@kishankavala please rebase this PR as we have merge conflicts. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-220513693
Can someone with a xenserver setup validate this one? @bvbharat can you
queue this one up for us? Thanks...
---
If your project is set up for it, you can reply to t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1499#issuecomment-220513799
@alexandrelimassantana this one has merge conflicts. Can you rebase and
fix the conflicts? Thanks...
---
If your project is set up for it, you can reply to this em
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220514243
I wonder how many people are actually aware of that. :-)
Sent from my iPhone
On May 19, 2016, at 9:04 PM, Anshul Gangwar
mailto:notificati...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220514409
@dsclose can you please rebase and repush this one to kick off jenkins and
travis again. We have fixes in both travis and jenkins so we should be able to
get this on
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220514841
@mike-tutkowski then we can raise this in dev list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-220514893
@sanju1010 ping...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220515109
@nitt10prashant any update on this one? I am very close to freezing, so I
figured I would check in. Cheers...
---
If your project is set up for it, you can reply t
Dear CloudStack Team,
I am Sangeeta, a PhD scholar from India. I am working in the area of
automated software engineering and my aim is to analyse logging statements.
While analysing the CloudStack project,* I found may files having following
statement written in them*:
*/*This file was auto-g
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220516362
Yes, I can send an e-mail out in a bit.
In the short term (at least for 4.9), I can just revert the changed names
in those Command classes.
Hi,
We should not allow renaming of variables in classes which ends with Command
and TO. As these objects are meant to be consumed by Agents.
Agents may not be written in java so relying on these variable names to get the
info. One such example is Hyper-V agent.
Hyper-V support is currently br
I see that you just sent an e-mail to @dev about this - thanks!
From: mike-tutkowski
Sent: Thursday, May 19, 2016 10:46 PM
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has
been add...
Github user mi
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220516738
@mike-tutkowski No, I have not created ticket. You can create one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Thanks for sending out this e-mail, Anshul.
This is a bit of a strange situation because we need to make sure people are
either aware of the fact that properties in Command classes are serialized (and
not change existing variable names) or come up with a less fragile way of
choosing property na
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-220517071
?OK, I can create one and open a PR up against it reverting those variable
names.
From: Anshul Gangwar
Congratulations, Will.
Regards,
Ardhendu
Ardhendu Shekhar
Senior Manager, Program Management | CloudPlatform | Accelerite, Hyderabad |
Extn: 29370 | Desk: +91 40 6742 9370 | Cell: +91 988-500-2788 |
ardhendu.shek...@accelerite.com |
On 5/19/16, 12:26 PM, "Sebastien Goasguen" wrote:
>Morni
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220521199
@swill i do not see any comment on parent ticket CLOUDSTACK-8676 , i have
asked Sateesh to update the ticket , will update the PR as soon as i hear from
him
Github user rashmidixit commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-220524210
While we are on the topic of updating the tech stack, have we considered
moving to using either LESS or Sass for CSS. CSS pre-processors bring more
modularity a
Dear Dev Team,
I am Sangeeta, a PhD scholar from India. I am working in the area of
automated software engineering and my aim is to analyse logging statements.
While analysing the CloudStack project, I found a file:* AmazonEC2Stub.java*
Can anyone please tell me the reason, why* this file hav
Congratulations Will, we hope you better idea for new version of cloudstack.
Make the cloudstack best cloud ever in market. Cheers!
-Original Message-
From: Kristoffer Sheather @ CloudCentral
[mailto:kristoffer.sheat...@cloudcentral.com.au]
Sent: 20 Mei 2016 7:23
To: market...@cloudstack.
Guys, we should rename fields that have improper names. I do not agreee
with the statement at all. Your two solutions to the serialisation hazard
are both acceptable to me. leaving a non compliant or non explanatory name
in because it slipped through the nets at some points does not seem
acceptable
Sangeeta,
What version of the code are you analysing? There used to be a lot of
generated ec2 code in the project some versions back. I can not find the
java file you are talking about.
On Fri, May 20, 2016 at 8:03 AM, sangeeta lal
wrote:
> Dear Dev Team,
>
>
> I am Sangeeta, a PhD scholar from
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63997069
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private Plug
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220529332
theare is two timeouts in the before script again and one exception in a
teardown method of a test.
@swill, are these errors repetible as well? they seem so
Dear Sir,
I am using version 4.3.0.
Thanks for your reply!
On Fri, May 20, 2016 at 12:03 PM, Daan Hoogland
wrote:
> Sangeeta,
>
> What version of the code are you analysing? There used to be a lot of
> generated ec2 code in the project some versions back. I can not find the
> java file you ar
101 - 164 of 164 matches
Mail list logo
